Date: Mon, 28 Jul 2025 16:15:04 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, mert@futo.org,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset
 extension parameters that no longer exist
Message-ID: <aIfoWKXanBNGhdwt@nathan>
References: <18964-ba09dea8c98fccd6@postgresql.org>
 <aFW8R6Qlgtbp7TOk@nathan>
 <2474668.1750451081@sss.pgh.pa.us>
 <aFXQmZ2sveFAwdjY@nathan>
 <aFXlRTxMxVyMjfjq@nathan>
 <aFwebUErRdEKZy6i@nathan>
 <803ddef427b9016be04af9320925e9570d3fcc06.camel@cybertec.at>
 <aIJfucaqjZ3gh-xj@nathan>
 <8902b6f8d5c19f09f4a052295b9de41d9f6970b5.camel@cybertec.at>
 <aIORdQ-PJ15k-WjZ@nathan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <aIORdQ-PJ15k-WjZ@nathan>
Archived-At: <https://www.postgresql.org/message-id/aIfoWKXanBNGhdwt%40nathan>
Precedence: bulk

On Fri, Jul 25, 2025 at 09:15:17AM -0500, Nathan Bossart wrote:
> On Thu, Jul 24, 2025 at 11:06:57PM +0200, Laurenz Albe wrote:
>> Anyway, I'll mark the patch as "ready for committer".
> 
> Thanks.  I'd like to get this fixed in the August releases, so I'm planning
> to commit this sometime late next week, barring additional feedback or
> objections.

I looked into how easily this back-patched to v15 (where commit 88103567c
was added), and I noticed that the ALTER SYSTEM code looks a bit different
on v15 and v16.  Furthermore, I didn't see a simple way to fix it on those
versions without first back-patching commit 2d870b4.  From the commit
message, it looks like Tom didn't back-patch it at the time due to a lack
of complaints.  I'm currently thinking we should first back-patch that one
to at least v15, if not all supported versions, before applying my proposed
patch.  Thoughts?

-- 
nathan