Date: Wed, 30 Jul 2025 14:13:16 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, mert@futo.org,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #18964: `ALTER DATABASE ... RESET ...` fails to reset
 extension parameters that no longer exist
Message-ID: <aIpuzKVndJrI48B1@nathan>
References: <2474668.1750451081@sss.pgh.pa.us>
 <aFXQmZ2sveFAwdjY@nathan>
 <aFXlRTxMxVyMjfjq@nathan>
 <aFwebUErRdEKZy6i@nathan>
 <803ddef427b9016be04af9320925e9570d3fcc06.camel@cybertec.at>
 <aIJfucaqjZ3gh-xj@nathan>
 <8902b6f8d5c19f09f4a052295b9de41d9f6970b5.camel@cybertec.at>
 <aIORdQ-PJ15k-WjZ@nathan>
 <aIfoWKXanBNGhdwt@nathan>
 <768341.1753738070@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="8aGg9uhxC6bwte3D"
Content-Disposition: inline
In-Reply-To: <768341.1753738070@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/aIpuzKVndJrI48B1%40nathan>
Precedence: bulk


--8aGg9uhxC6bwte3D
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jul 28, 2025 at 05:27:50PM -0400, Tom Lane wrote:
> Nathan Bossart <nathandbossart@gmail.com> writes:
>> I looked into how easily this back-patched to v15 (where commit 88103567c
>> was added), and I noticed that the ALTER SYSTEM code looks a bit different
>> on v15 and v16.  Furthermore, I didn't see a simple way to fix it on those
>> versions without first back-patching commit 2d870b4.  From the commit
>> message, it looks like Tom didn't back-patch it at the time due to a lack
>> of complaints.  I'm currently thinking we should first back-patch that one
>> to at least v15, if not all supported versions, before applying my proposed
>> patch.  Thoughts?
> 
> No objection here.  Now that that's a couple years old, it should have
> had enough time to bake.

It applies relatively cleanly down to v15.  The only thing I had to change
was to replace guc_free() with free() on v15.  I was a little worried about
changing the signature of check_GUC_name_for_parameter_acl(), but
codesearch.debian.net doesn't show any outside uses.

-- 
nathan

--8aGg9uhxC6bwte3D
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename=v1-0001-Allow-ALTER-SYSTEM-to-set-unrecognized-custom.patch.v15