Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 7 Aug 2025 12:38:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
	kristianlejao@gmail.com
Subject: Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c
Message-ID: <aJQfz3G-ZipUNTRx@paquier.xyz>
References: 
 <CAD21AoBpo6Gx55FBOW+9s5X=nUw3Xpq64v35fpDEKsTERnc4TQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="+nt9rq1IbwK4qDuh"
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoBpo6Gx55FBOW+9s5X=nUw3Xpq64v35fpDEKsTERnc4TQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aJQfz3G-ZipUNTRx%40paquier.xyz>
Precedence: bulk


--+nt9rq1IbwK4qDuh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Aug 05, 2025 at 11:00:54AM -0700, Masahiko Sawada wrote:
> The attached patch includes the draft fix and regression tests (using
> injection points).

+$psql_session->query_safe(qq[
+    select injection_points_set_local();
+    select injection_points_attach('heapam_lock_tuple-before-lock', 'wait');
+]);

It seems to me that an isolation test would be a better fit here.  TAP
tests are usually a good fit for injection points if you need to do
direct node manipulations, like restarts or stops.  The whole test
posted only does SQL-ish things, and you could rely on a loopback
server as we do in the SQL tests of postgres_fdw?
--
Michael

--+nt9rq1IbwK4qDuh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmiUH88ACgkQnvQgOdby
QH0z+g//abA/+ISlW8HnzbDRXuG81Rmsr6ErQYTnxuaf+5kXLI/AB5mlFPIzIAwW
dOIAUQAD1H4G0vAzI7Zrw6oXy4aUK07kQkuiuKKaweX5Qj/F6Kl3zsX8EZwVj6ye
OuyKMYdcmK/5EOwMrsyy98/7DPjYQYcLMtLyeUf3dE0vc7dhJ4V5i0/sCZ/IcFZV
t1tMEshc77lYQzIKl2B0SCkEG64xGGXmsvjndUkkTLwHYacKZXpAKHg+FWDgvy+t
IGjXg/ZBh2RBxOm0t/sRIuGh4x6jxAJKHSaCQh7zcxRnbAMc1htDDUkElm+xJNFk
G1XbTmCOG1hdcWUH71Tbayu8lE/HobGN4/7r4SvvnTYQejm7yUSNVLGZxZLwYnGG
t8LM7bYIO6CX1nggOCe5JKHW/rkAIZyVNk0ie7dkfijf3+zZfxQLg3Q6q1wwaKLu
edRnCz4qgChBfvISZVbyA0QRDtE3r/2Bn3Z6Zc+F5cHlBDnSzrVv81Jy5wvXJrLt
7ZKPlTNhy0l1E1q8J5WxihDEMBo4AhpeFBTQKiuzSUySrtMb/hbjarghBPL5ycC+
afq398v2n62l/WoFs2/9dF7Y0M/OaIp7sciSpN4AljXFFBP6R2n0A8nabEpzBktm
45AlPFy2Zp6VEGY40FIyoFflYgPMAXIYVm0iGOQOzP6iS6rN2WM=
=NEvp
-----END PGP SIGNATURE-----

--+nt9rq1IbwK4qDuh--