Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 18 Aug 2025 15:58:45 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
	kristianlejao@gmail.com
Subject: Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c
Message-ID: <aKLPJet54cgC3JNA@paquier.xyz>
References: 
 <CAD21AoBpo6Gx55FBOW+9s5X=nUw3Xpq64v35fpDEKsTERnc4TQ@mail.gmail.com>
 <aJQfz3G-ZipUNTRx@paquier.xyz>
 <CAD21AoB0C7t7gHr-+AfPq5Lswmw=uU1w+3aT88fTPVzdyAd2sA@mail.gmail.com>
 <aJU5LMlFXWoix7Ip@paquier.xyz>
 <CAD21AoCm1XYSD_R1capjuvLZ_3fKXnCu0C751Vk3hVOBDSwaCQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Kawa0UL1gFoRNqki"
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoCm1XYSD_R1capjuvLZ_3fKXnCu0C751Vk3hVOBDSwaCQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aKLPJet54cgC3JNA%40paquier.xyz>
Precedence: bulk


--Kawa0UL1gFoRNqki
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 08, 2025 at 12:15:19AM -0700, Masahiko Sawada wrote:
> On Thu, Aug 7, 2025 at 4:39=E2=80=AFPM Michael Paquier <michael@paquier.x=
yz> wrote:
> >
> > On Thu, Aug 07, 2025 at 10:29:41AM -0700, Masahiko Sawada wrote:
> > > Yes, it's definitely possible to create the test using isolation. I
> > > wasn't sure how to invoke isolation tests only when injection points
> > > are enabled.
> >
> > For meson, I think that I would tweak the isolation test list based on
> > get_option('injection_points'), and do a similar thing for Makefile.
>=20
> Thank you for the advice! I've changed the regression tests to use
> isolation tests.

That's enough to reproduce the MULL pointer dereference, thanks!

I would suggest to add a description at the top of foreign_recheck,
documenting the purpose of the test.

+# "s0_lock" execute a FOR UPDATE query but it stops before locking the res=
ult=20
s/execute/executes/, with an 's'.

Fujita-san, are you planning to look at the proposal?
--
Michael

--Kawa0UL1gFoRNqki
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmiizyUACgkQnvQgOdby
QH3lLQ/+KxFG9zJ9BtGEKdwu11Kd/Ws4cR3RTZNL348kYtkpHsTyG8BgYmRmFAtQ
EywFkOM9SfU88/0judS+p/WcybiKz4ZaPjNJAtbzkAoo4ItdBO8rmxNoyUWXXYsh
suuG3Ts2rCzdHc+uRlGAG2xxlouUUzwTPqnjVKjgy3kewwiiWcX9R68t5PtdPJkF
N02cOFVGftqM5Am76VgYZBO4O8BmxoLBQoOnYt2ggz28hPHO3jtBR2CwajtBkp5y
+bw8+8LThgi9Xmrj5IWoA7G8AIePUV4QrF6k9pDSeFisdYPJN7WNv+PiTkbVCxCR
c6LvuCJJ4suSwA8mrxteel7GCrkpoZBNKoj8sSOJv2tut87NX6SeEMlP2vQMXif8
EyuOTz3pvu/5sZR08UdNcBLBC4fPSuUSP7MSaEKew8cPbCTwuVfa5cR0V4hK/mka
GO3mh20alJEQIrloxXVMRKtRwPgITXW2yuT7qrS3a/XFGKn824C0gwGbj+6jTeul
yQdrAKUZUy5PeumuTZ2aYxjBdNUptwgNzvlq3So0NaaC2G/Xk0fIE/Yt7sPR5PBL
fKGQerKHZD5Yl2FOSmq+7XrTk1Sn7L7lfPDMVXnh/V9NakEYxLUjkdxIlIaJldAU
aaimGMBI8hziR7S7VhrxNDT/ZcjRe8kOs1zJNpLmyQoy9Lh0dbs=
=4RcY
-----END PGP SIGNATURE-----

--Kawa0UL1gFoRNqki--