Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 22 Aug 2025 06:36:56 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	wangsh.fnst@fujitsu.com, osumi.takamichi@fujitsu.com,
	pgsql-bugs@lists.postgresql.org, Andres Freund <andres@anarazel.de>
Subject: Re: "unexpected duplicate for tablespace" problem in logical
 replication
Message-ID: <aKeReH7_GwoMUoLi@paquier.xyz>
References: <20240116.105804.1924548897701268962.horikyota.ntt@gmail.com>
 <CA+TgmoYADF0ddp4JO_a8AiUDKCLFGTAw7ii8OniLBzmwVG8njg@mail.gmail.com>
 <Zffgupps4Gv9BVXL@paquier.xyz>
 <CAD21AoAcGtSOxp-6b7JWVNsyuefk2QwLN2aF2Ki+1bq+X=6fzA@mail.gmail.com>
 <CALDaNm2b3XtaA6GQCD55z-eOyxXR2s_oBifesb7FgpKLJNYR0A@mail.gmail.com>
 <CAExHW5vaHu=s6eopJ2jxyGNRG--uEsJwYk92yxa2L_80+Y=1YA@mail.gmail.com>
 <CAExHW5vBePcL9iEFasECB-wmYksZ9nUVnjnzOqkHYvtbCn==0A@mail.gmail.com>
 <CAExHW5uaSBDktUEyohUYy_QGRZgN=zd=B9gdp2MyDMJZOCisBg@mail.gmail.com>
 <aKa4wnxX6h2siDIq@paquier.xyz>
 <CAExHW5vojKfVMYij=bU3NgPS8ajx7udB1CiibqJruYj71JcoNw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GwRbYt24DeI3hwUY"
Content-Disposition: inline
In-Reply-To: 
 <CAExHW5vojKfVMYij=bU3NgPS8ajx7udB1CiibqJruYj71JcoNw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aKeReH7_GwoMUoLi%40paquier.xyz>
Precedence: bulk


--GwRbYt24DeI3hwUY
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Aug 21, 2025 at 07:54:55PM +0530, Ashutosh Bapat wrote:
> How about the following:
>=20
> ---
> Map a relation's (tablespace, relfilenumber) to a relation's oid and
> cache the result.
>=20
> A temporary relation may have the same relfilenumber as a permanent
> relation, or as other temporary relations. In order to uniquely
> identify a temporary relation we also need the
> proc number of the backend which created it. The proc number is not
> available to this function. Hence ignore temporary relations.
>=20
> Returns InvalidOid if no permanent relation matching the criteria
> could be found.
> ---

That's simpler.

> Said that if you insist on adding just "Temporary relations are not
> supported", we can go ahead with it.

That would be simpler as well, providing the information.

> Vignesh, since you are the original author of the patch, do you want
> to take care of addressing the comments? Otherwise I can.

It's fine.  I am going to take care of that.
--
Michael

--GwRbYt24DeI3hwUY
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAminkXgACgkQnvQgOdby
QH0zyBAAhzbRhYrtDfI8V53s8q3q+85MQemxrq8/2RC4tdM1uaVYVT1p3YLjXkZz
IbGDa02BojbnIB+DdJBTSo6pYYbZrtF2aCeC5E+xNS/Qkmruve76J5aWTkKuGZ4a
Sro1e7lhfdCuGprsaj7w7sQ8+M4PKi0QNa8wv5X7LwKPmPVcqapkujAlycxDjyrY
wJMaRbWV0QebnUoMyR7tblYjTOsBB60H9EMfJlY/00rVzhNtT1LdFK98WiDsME2h
gGbKWo/sQ1qtqc1oSmJSvcQn2fc0nU9iFpTIVBqpdaRR4BbbwKBoNKQhy3o1psUM
fiA3td/8VniHePTP1V851kUbG6DnKcCikkscQYtBrcky2B325BMoAxV0M7p7xzb1
Uu+gL4Ep556NlnFIrVzRDK3Hk+rGf1CCGc7gYnMyz1uWwfy2myEP0o7RG7hHhT+E
PBersNL/a/jYlVS3eYOTtdTVjRrleQZiRuCds4GU5AdMj9HBjJhRWEXE5ZNbo4XZ
xNOUro5Asem/fgJtaE6mot2ygBIGc65HaVGStTfghnHVjQM8jKVFXJr3bXXtV3yw
Vmz96/1A5Fd5HtO8jqJY2ABc2AuxHhzr9+mF2KXnUgFYSbPUzg+2VHWaL7QkgIKC
q2kFjlCWh19G/PKyRcUn2MG7Duug6EXAdm5QigYXCYPxA6Y1uJE=
=Rqos
-----END PGP SIGNATURE-----

--GwRbYt24DeI3hwUY--