Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 31 Aug 2025 13:53:50 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Ran Benita <ran@unusedvar.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: Broken PQtrace CopyData display
Message-ID: <aLPVXkOipoBSWSb1@paquier.xyz>
References: <a3383211-4539-459b-9d51-95c736ef08e0@app.fastmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="myiSA0NbygZOH+8n"
Content-Disposition: inline
In-Reply-To: <a3383211-4539-459b-9d51-95c736ef08e0@app.fastmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aLPVXkOipoBSWSb1%40paquier.xyz>
Precedence: bulk


--myiSA0NbygZOH+8n
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 29, 2025 at 10:45:18PM +0300, Ran Benita wrote:
> I used PQtrace to trace a logical decoding session, and was confused to s=
ee
> lines like this:
>=20
> 2025-08-29 22:09:57.633980	F	38	CopyData	 'r\x00\x00\x00\x00\xffffff8e\x0=
7\xffffff85x\x00\x00\x00\x00\xffffff8e\x07\xffffff85x\x00\x00\x00\x00\x00\x=
00\x00\x00\x00\x02\xffffffe0\xffffff84\xffffff89R\xffffffd7\xffffffb8\x00'
>=20
> The data doesn't make sense and has the wrong length. A quick look shows =
that
> the \xffffff85 parts are a signedness issue (on my compiler char is signe=
d).
>
> @@ -212,7 +212,7 @@ pqTraceOutputNchar(FILE *pfdebug, int len, const char=
 *data, int *cursor, bool s
>          else
>          {
>              fwrite(v + next, 1, i - next, pfdebug);
> -            fprintf(pfdebug, "\\x%02x", v[i]);
> +            fprintf(pfdebug, "\\x%02x", (unsigned char) v[i]);
>              next =3D i + 1;
>          }
>      }

Yeah.  Not a lot of people use the libpq tracing, but it would be
better to show non-printable data in a consistent way.

> The diff below fixes this particular problem, though they say bugs are li=
ke
> mushrooms, if you find one then there are probably others nearby, so a mo=
re
> comprehensive fix may be warranted.

There's one more mushroom: pqTraceOutputByte1() also uses a %02X
without a cast for non-printable data.  Note as well
logicalmsg_desc(), auth-oauth.c, mbprint.c (which uses an unsigned
char type in input to force things).
--
Michael

--myiSA0NbygZOH+8n
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmiz1V4ACgkQnvQgOdby
QH3j9w/8DtzzHovcsN6AM67cWx1V2tyoD5GY+JLmOqV+lyg7rSu8i1Ip0nE4ZzZu
YwpUpQ+FWWYN704We3U+28e/DwIdz1iGScVh7EJsgV5RJTs/C8yMFKHEHcRDzN+6
MvKwSYjeCeNPcMEOYfe7B/Qcf9Y6BV1XTjHmlKCq6tMAHpZ4rjtuGSHZgVCsDp6o
Sxf7Ipa6Wtimxx3H2IjaDBKwKg2yKRPk0D+3rYx+KG4Jo+shq0oY+UT3yJD3JZ7j
63h4wG9OrhGxeh7krzIuYvmUFtTgbECwz3EHCdBw5//rqoJ7JC+zdZF7eoioW81P
soT5P4+wkD6o2v4QikFVU0iqUPkrEaKpsvLxMjMnkGrbVYh3Gb2skrwdup4S+2AO
NyTAKWLadCkb8jUCO8NFGAi0SQH3Q6LJI73vBCQkvmL8HhyuhUqJlgeFaKTq86eT
6EcqdfQw5aewnrby88YbvUcr91+r9SI5ibDL50g85wKzh1P3KjZurrYCPtweIVw9
x2e1RlQzg8Wwbh2Gdop6RG09TCmHiwEUX20sFEF2oxOCVRvoCqvnJ0QZFwHXjpBx
/PWf4VX9+U2TPTMiDwTwj/daYVlN0K49gpSynVR/RVCBkzG97sq14Muy6w5ZhWwP
X+z2ysqN/emMxIMqG9wQc9lfKejMkiiGf5PFAMb1uca+3xs6sGE=
=z8C8
-----END PGP SIGNATURE-----

--myiSA0NbygZOH+8n--