Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 3 Oct 2025 09:57:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Etsuro Fujita <etsuro.fujita@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
	kristianlejao@gmail.com
Subject: Re: TRAP: failed Assert("outerPlan != NULL") in postgres_fdw.c
Message-ID: <aN8fYwIw0p7ZMYGA@paquier.xyz>
References: 
 <CAD21AoBpo6Gx55FBOW+9s5X=nUw3Xpq64v35fpDEKsTERnc4TQ@mail.gmail.com>
 <CAPmGK15xnqyJ1r3iRmyJEd-iALq31Pt+UAooUyRjoKf3gJ5Feg@mail.gmail.com>
 <CAPmGK16e1JgMN=MYsz1=kkmL29sa92_LOTOQNwL9fG2+QH-=Gw@mail.gmail.com>
 <CAD21AoDv6ffWfVTBQgHGNR1rhywpKH246hJWiJvwBtPsGfxmJQ@mail.gmail.com>
 <CAPmGK164pycWPoMH8JeeWv0J8dF8kp=E89VJePYXh+Fhm+H0Hg@mail.gmail.com>
 <aMtRUQqnowiYFIha@paquier.xyz>
 <CAD21AoCD=Fg6cx9HQGY1JUy+ZVd5_k_zTqPn7HjPPL2CjncbHg@mail.gmail.com>
 <CAPmGK15rRYceZQ5DHcXXxMQLSU9r2CW=wXJc8+w76gkrkuFamw@mail.gmail.com>
 <CAPmGK14uTcaer74Cr5n62i0Lis9bnbX4F+YKrttrLq0Zj9+Eow@mail.gmail.com>
 <CAD21AoALtwy43TYR7tXoOPHKEPkutagYYY1TmbNzoR_6+fzA1g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MkyYC/7LsFLlylc6"
Content-Disposition: inline
In-Reply-To: 
 <CAD21AoALtwy43TYR7tXoOPHKEPkutagYYY1TmbNzoR_6+fzA1g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aN8fYwIw0p7ZMYGA%40paquier.xyz>
Precedence: bulk


--MkyYC/7LsFLlylc6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 02, 2025 at 03:20:32PM -0700, Masahiko Sawada wrote:
> I've updated the patch based on your comments. Please find the attached patch.

Looks sensible here in shape, a few style nits noticed while reading.
x
+# This test exerices EvalPlanQual with a SubLink sub-select (which should
+# be unaffected by any EPQ recheck behavior in the outer query)

The setup phase has a mix of tabs (used in the DO block) and
spaces used, that may render weirdly depending on one's setup when
showing the diffs.  It looks to me that your intention is to use
spaces.

s/exerices/exercises/  And I would add a short explanation about the
reason why this script exists at the top of eval_plan_qual.spec.  If
you don't feel strongly about that, feel free to ignore me.

One other bit I have noticed on the way, due to the extra whitespaces
at the bottom of the file:
$ git diff master --check
contrib/postgres_fdw/specs/eval_plan_qual.spec:52: new blank line at EOF.
--
Michael

--MkyYC/7LsFLlylc6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmjfH2MACgkQnvQgOdby
QH3ryw/+ICyzDJXnD8PBfx4DA4UUcZEZw6HEU88O593ojZWN1jJsu0HFuK3Kujwf
ZVh51jCgM55szvQk4Eq939J2kcAxWEx4hafH5Z4VSv7iMAh0hzVN2hMjDSHjS9uc
JUxAdvQ8YB8tYSOg1nm2uJPUphRS9YWYwAfUis1LQX2xZbgBA9Vn0AI4baxV1SYg
AK1elMum3FZASer8cPmylAZLp04rmclqzCDbQQlZuVDCHUm2dKamVLBTBsqv+nKR
fNBO4usExJ+B4WcjN+AflWqyxVoRlj2moNCcH54j0HL8u3M6xIsiMVVt9VhhJ5aw
dmErl9Y99UaIy3rhs+khxvKYpRE3Z9KEVwL5ca862Et0eC6gB5c4yDgcOxUw7exO
mH/SLjHGQli1FRBeeTmVG1SB0JBZg2JBLgHRWJGGTMdaKzNupf+zwU3Qo3Po3RVE
7OpgMylpxG186sTekqSLrOATJcmL/XTA47mUYYCcD/jdLHburP0J8ywdvPvfORFt
pqUwONi+20vIKqQnaU6AeVHCQoqEEJPt/V4PjLVaq3xuJl5JSus67ABstz2rV2xL
Zx6nVSeGYwbNFn3SRLyRBpP04PZZ8egipovul7Pt/qzClYbTx8Y99bDOct20qxYQ
czxf4O5dXn1oTlu0mpwGt3mBW3Y4hdxa10d9JbYjm2KSLWBIzSo=
=AGYI
-----END PGP SIGNATURE-----

--MkyYC/7LsFLlylc6--