Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 1 Nov 2025 09:17:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Xuneng Zhou <xunengzhou@gmail.com>
Cc: Noah Misch <noah@leadboat.com>, ryanzxg@gmail.com,
	pgsql-bugs@lists.postgresql.org, Euler Taveira <euler@eulerto.com>
Subject: Re: BUG #19093: Behavioral change in walreceiver termination between
 PostgreSQL 14.17 and 14.18
Message-ID: <aQVRlV6ZOsUz5fd1@paquier.xyz>
References: <19093-c4fff49a608f82a0@postgresql.org>
 <CABPTF7XKZV2d4eWhH0ybfv5J0hHyzPxPDmebzQXsSt-8XvO1sA@mail.gmail.com>
 <20251027041241.ab.nmisch@google.com>
 <aQGfoKGgmAbPATp5@paquier.xyz>
 <CABPTF7VsyWXAQyc-qc8i1OkwsP5hWE6WoGVCH1zbiUhX0=rFCw@mail.gmail.com>
 <aQKlC1v2_MXGV6_9@paquier.xyz>
 <CABPTF7XE--Dc97LXj5Xum1U4v5=CQnrVYFbVjWTWu4J7gCNXAg@mail.gmail.com>
 <aQQqBUuRAS38u3w8@paquier.xyz>
 <CABPTF7UR3CTc5m0Gzkm-18qnbXTujYzCicmRatOYsMr1LQ+z3g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ZTvaZnL0Dq75vBNt"
Content-Disposition: inline
In-Reply-To: 
 <CABPTF7UR3CTc5m0Gzkm-18qnbXTujYzCicmRatOYsMr1LQ+z3g@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aQVRlV6ZOsUz5fd1%40paquier.xyz>
Precedence: bulk


--ZTvaZnL0Dq75vBNt
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Oct 31, 2025 at 06:50:06PM +0800, Xuneng Zhou wrote:
> On Fri, Oct 31, 2025 at 11:16=E2=80=AFAM Michael Paquier <michael@paquier=
=2Exyz> wrote:
>>
>> On Fri, Oct 31, 2025 at 12:07:01AM +0800, Xuneng Zhou wrote:
>> > Using a wrapper function seems better here.
>>
>> For a cleaner git history, the wrapper function and the assertion
>> should be split as its own commit, with the actual fix applied first.
>> Just an opinion.
>=20
> It makes sense to me. I've split the patch for HEAD into three patch
> sets.  Please see the attached files.

Thanks, that looks sensible.  I'll revisit what you have at the
beginning of next week (local Tuesday) with a backpatch down to v13 in
mind.  If others have comments and/or objections, please feel free to
chime in.

Note that the changes in 040_standby_failover_slots_sync.pl are not
needed in v3-0001.  No need to send an updated patch just for that.
--
Michael

--ZTvaZnL0Dq75vBNt
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmkFUZUACgkQnvQgOdby
QH2YkA//Rm9aqWUSB5Y0yIkl/AGdBVrqjFMu1jJfP0YfIViYS/AiWQVXUUK48HVL
qLHmJUw9EKyh5A4wftuJ4WKBskMQ1dTMAsRNc/vqM29cid+bq0NJnVphCwe9zyO0
1fWtloB/0N0DxQPZZ4nwU5SNyYNVZ/E1sjt2oguikzLJBtsMXgHsjjyX8HbM2Fy1
c5A5GzE5+7MEmG/Xwq4PvPqbKHgVvVRmvvvXkctoxRpTq0wvy6+K1f2vtIlfzsl7
71SqW4IElKkaeQd0jkrRkIgVaoAR7od0CuAEvxNLw2tqtiKe8rSI89PbtfCWkkax
IJdOhHAAAQBwtz/1/exXuErmIzFAEebsvBTMZzVtjeWxREmFyJUJK7lxPej4iIwN
sSV5MCQIyROllIy0ijN6UER79PhetFVxvFODX5TDGAcs9c5CAh5Cr1qLmKfPX0oI
0QEHbVCFPcE3AG86N3Q/nDVBLvtwMpCvlcyoXhZYi85JV0jEkmtWqsbDfxfUbnYc
xSoEy/tZPXIgm1rHU8AyUuafCkTJkvCX2nqE/XfDTlOlimSUWaly0gfql3CMOfkL
g6LW6nPxYDZbb20GtmZCKJwEqBB7lYACS/GXyTS86EbiN97ZcycC16QBxToWzRGC
s83fBxaSGecbaIOC6fAtc1gwRJz84o8xzR08unHvO7tTCntDMaQ=
=nGKJ
-----END PGP SIGNATURE-----

--ZTvaZnL0Dq75vBNt--