Feedback-ID: i0fe9450f:Fastmail
Date: Tue, 9 Dec 2025 13:16:32 +0900
From: Michael Paquier <michael@paquier.xyz>
To: VASUKI M <vasukim1992002@gmail.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, Tom Lane <tgl@sss.pgh.pa.us>,
	BharatDB <bharatdbpg@gmail.com>, torsten.rupp@gmx.net,
	pgsql-bugs@lists.postgresql.org, byavuz81@gmail.com
Subject: Re: BUG #19095: Test if function exit() is used fail when linked
 static
Message-ID: <aTeioHWzG2Wrwfcf@paquier.xyz>
References: <CACTYHzhCNsee-4xv-HDhw8zmMWByB7YHLuUHh-bsztgZ94ewpw@mail.gmail.com>
 <483765ED-0490-4972-9769-4943716BE204@yesql.se>
 <aSZ3RUjc7BVE6-9j@paquier.xyz>
 <CACTYHzjbVeKV289+TB1mg+tVmpnOJWrtezTvRjUwYoc875p1XA@mail.gmail.com>
 <CACTYHzjjssid_jtZiLh8BTYHAvnxbSLXceyGtxM3NB6Kfv510g@mail.gmail.com>
 <22D3D4EC-BCC3-4E52-B5A9-E1C6E363517B@yesql.se>
 <aTDWg-ezihyoelN3@paquier.xyz>
 <CACTYHzimf5+6gp6HzCerZpWh4o2_TW6-S3k3+2YK5mnoQa-+tg@mail.gmail.com>
 <aTIqMdS7QPdkcT29@paquier.xyz>
 <CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="c+EMNgcsTX47rjpp"
Content-Disposition: inline
In-Reply-To: <CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aTeioHWzG2Wrwfcf%40paquier.xyz>
Precedence: bulk


--c+EMNgcsTX47rjpp
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Dec 08, 2025 at 10:11:08AM +0530, VASUKI M wrote:
> Regarding the whitespace comment - I had already ran the pgperltidy on the
> perl script libpq-check.pl before  sending the patch,and I also verified =
the tab
> indentation with cat -T  to ensure the tabs were being used.FS,The curren=
t version of
> the scripts in v6 should already follow the standard pgindent/pgperltidy =
formatting
>=20
> If there is still any specific section that appears mis-indented on your
> side, please let me know and I will adjust it.

The only documentation that I have been following on this matter
exists in src/tools/pgindent/README.  That may be an issue with your
environment, I cannot say for sure.  And I am pretty sure that my
environment is handling things the way the README tells.

Anyway, after more review of the refactoring patch, I have noticed
that we were losing quite a few details about the reasons why we are
doing things the way they are.

So I have added more details about to keep things a maximum consistent
with what we had documented:
- The shared library check requirement, mentioning that the check is
skipped for static libraries in the Makefile case (for meson, we use
libpq_so, so that did not seem strongly necessary to add there,
perhaps we should).
- The explanation for __cxa_atexit, related to OpenBSD, reusing the
same wording as previously, but in the script.
- The explanation for __tsan_func_exit with ThreadSanitizer, reusing=20
the same wording as previously, but in the script.

Then applied the result as 4a8e6f43a6b5.  Running the check for meson
may bring some surprises, but we'll see.  The buildfarm looks OK for
the moment.  Once we are completely in the clear, let's move on with
the second patch.
--
Michael

--c+EMNgcsTX47rjpp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmk3op8ACgkQnvQgOdby
QH0WXhAAn4tvHErsRx/fjIAEX9jEsxkiyfEh4/ZCGlj5m8nHkJmpScKwMdPVR3x+
izVeoczOvDGcDWqO5jbz/5KpfXRSugyra5jt3iYOTTOPdhpd9EWGgtUEcHzkRbHv
Tzi6331CDrvDxrOX/QRXnXMLIm5Gum30G5U/Gf8FQ/T+S514/s08EznLgaZPK1JB
KpK1EDvsVF9VPoM2K2Wu6tTUiwSv6lWiEa8q0w43v7SMl+i1fLuFr2nSdBNma96/
fQfXCxWa5YceklIQk4v9zE0tSG1Figkx8+eeycA9K7lM8wOpsDh4ZhDkFPmp3WMl
hvItHLhAkVlSTSiw45OaX09notuj8sSuwpY5RJcY+euc/S4XoILh+KIe6cej2GJD
WHsyHW2/NclA9C9MfWtwphaaRFDJ32Tf5PMTkrFzSzurtrLI/w2avExTiXQs3AEn
jxdNpJdXU8qU3NJc7Wns5vvTlMNto+weUaHoJHbEVQt8zVesEMSA8YbneoVbNbJn
YP6G91ArWHQrxyzqeW4UbN8mbgm4RoGTIkHxI+bYrjR4tIbCbelagn80GhsDV8K/
Jl9c9w0dvq1eUd+efmHOOf2/bSWXXSE5hzmvowIhQDOpOw3npXcfeRYeZl7bPuzR
xAwGqefjxPnpycJRl0Tcu0Fyi6SRa9sbXxiboOI9tskz0M6/ecs=
=DW0v
-----END PGP SIGNATURE-----

--c+EMNgcsTX47rjpp--