public inbox for [email protected]
help / color / mirror / Atom feedFrom: Michael Paquier <[email protected]>
To: Peter Eisentraut <[email protected]>
Cc: VASUKI M <[email protected]>
Cc: Daniel Gustafsson <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: BharatDB <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
Date: Tue, 9 Dec 2025 15:26:00 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
<CACTYHzjbVeKV289+TB1mg+tVmpnOJWrtezTvRjUwYoc875p1XA@mail.gmail.com>
<CACTYHzjjssid_jtZiLh8BTYHAvnxbSLXceyGtxM3NB6Kfv510g@mail.gmail.com>
<[email protected]>
<[email protected]>
<CACTYHzimf5+6gp6HzCerZpWh4o2_TW6-S3k3+2YK5mnoQa-+tg@mail.gmail.com>
<[email protected]>
<CACTYHzihgbTyYNQsEGcYmfkPd79r+_Jiz+PhN1xW+3NoJGEhyQ@mail.gmail.com>
<[email protected]>
<[email protected]>
On Tue, Dec 09, 2025 at 07:10:09AM +0100, Peter Eisentraut wrote:
> meson gives this warning now:
>
> ../src/meson.build:31: WARNING: The variable(s) 'NM' in the input file
> 'src/Makefile.global.in' are not present in the given configuration data.
>
> Looks like a small addition on src/makefiles/meson.build would fix it.
Oops. Let me see.. Indeed, the warning shows during the "Configuring
Makefile.global using configuration" step. This information has been
showing up in my logs while testing meson.
The attached takes care of the issue here. Adding that to pgxs_bins
may look adapted at first glance, but I don't quite see the point in
exposing this information to PGXS, so pgxs_empty is a better fit?
What do you think?
--
Michael
Attachments:
[text/x-diff] meson-warning.patch (470B, 2-meson-warning.patch)
download | inline diff:
diff --git a/src/makefiles/meson.build b/src/makefiles/meson.build
index 0def244c9011..c6edf14ec449 100644
--- a/src/makefiles/meson.build
+++ b/src/makefiles/meson.build
@@ -154,9 +154,10 @@ pgxs_bins = {
pgxs_empty = [
'ICU_CFLAGS', # needs to be added, included by public server headers
- # hard to see why we'd need either?
+ # hard to see why we'd need these ones?
'ZIC',
'TCLSH',
+ 'NM',
# docs don't seem to be supported by pgxs
'XMLLINT',
[application/pgp-signature] signature.asc (833B, 3-signature.asc)
download
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: [email protected]
Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
Subject: Re: BUG #19095: Test if function exit() is used fail when linked static
In-Reply-To: <[email protected]>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox