Date: Mon, 9 Feb 2026 15:48:05 -0600
From: Nathan Bossart <nathandbossart@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Sergei Kornilov <sk@zsrv.org>,
	=?utf-8?B?0J7Qu9C10LMg0KHQsNC80L7QudC70L7Qsg==?= <splarv@ya.ru>,
	pgsql-bugs@lists.postgresql.org,
	=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@kurilemu.de>
Subject: Re: basic_archive lost archive_directory
Message-ID: <aYpWFcfk1xueHiCc@nathan>
References: <202601301728.sfkizrto3t5i@alvherre.pgsql>
 <9b9341b0-942e-4d34-b94f-92bd918fad04@ya.ru>
 <1317421770387925@cea5cfd9-50d3-4d85-a924-a7cc75f8f215>
 <CAHGQGwF3tFP=oQgYHoS3h9TMeFbZwXc6+xdPTW8CkMV2TkjTmg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHGQGwF3tFP=oQgYHoS3h9TMeFbZwXc6+xdPTW8CkMV2TkjTmg@mail.gmail.com>
Archived-At: <https://www.postgresql.org/message-id/aYpWFcfk1xueHiCc%40nathan>
Precedence: bulk

On Tue, Feb 10, 2026 at 02:46:39AM +0900, Fujii Masao wrote:
> Basically I like the idea of moving the checks for archive_directory from
> check_archive_directory() to basic_archive_configured(). This would not only
> address this issue, but also other problems caused by performing these checks
> in the GUC check hook.

Note that the check_configured_cb is called for every segment to archive.
That means we'd be calling stat() much more, which seems like unnecessary
overhead to me.  And we still need to be prepared for the archive directory
to disappear at any time.  I'm wondering if it would be better to simply
remove this archive directory existence check from the check_configured_cb.

-- 
nathan