Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 22 Feb 2026 12:40:10 +0900
From: Michael Paquier <michael@paquier.xyz>
To: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>, huseyin.d3r@gmail.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19393: pg_upgrade fails with duplicate key violation when
 CHECK constraint named *_not_null exists
Message-ID: <aZp6mrxzlNc1KmRf@paquier.xyz>
References: <61c535617992fff830961ecc09a9c20096bc1f36.camel@cybertec.at>
 <202602211127.yhfjy43if2kk@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Obcz3A34aAvyOnLx"
Content-Disposition: inline
In-Reply-To: <202602211127.yhfjy43if2kk@alvherre.pgsql>
Archived-At: <https://www.postgresql.org/message-id/aZp6mrxzlNc1KmRf%40paquier.xyz>
Precedence: bulk


--Obcz3A34aAvyOnLx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Feb 21, 2026 at 12:56:24PM +0100, Alvaro Herrera wrote:
> Thanks for this!  I have pushed it now to 18 and master (right before
> the embargo for next week's release -- not really apologizing about
> that, since this is clearly something that's going to bite users as they
> move up to 18).  Two notes:
>=20
> 1. this will cause an ABI break report for AddRelationNotNullConstraints
> in branch 18.  I considered the idea of adding a shim function
> preserving the original API, but I think this is not a function likely
> to be used by third-party code.  So I'll address this by adding an entry
> to .abi-compliance-history instead.

While I get the feeling of urgency, I am wondering if this particular
fix should have been delayed and pushed for next May's release.  We
are already doing one quick release for the regressions found in the
CVE fixes..

Based on my read of the fix, I feel rather safe that this is OK.  But
as I have quoted upthread, the reason why I did not reply yet was to
wait for next week's release to be out before acting.  That's your
code of course, so no objections from here, just a slight doubt about
the timing.
--
Michael

--Obcz3A34aAvyOnLx
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmmaepoACgkQnvQgOdby
QH3lkg//XgLvdgXEC3BIWpnojVdkDPqpd8moNFugd7/V0EU1g+Fyp+RdmnMMoXI+
mMm5bmWmxmCdlXxWuO+U5ri3WMPVVRkEvObDTs7HHBzXkZzxNBhw1d63vxMqCg5W
3PohKMWSkDVkqMggQWNy0dKodqaIneWwKI5+EtsAtioTqKoTpfXyIc+bWBxo4xWI
1Z6mtB26X9kXL0vfJfQR8BM84IftgxguLYBLLynFZ7S9oBfRcQeGp8iwIwZSVJhq
XLQFVwY26DfNnR1wBXCAbx6Ipm1cIizv41rwpMgDsjUXFA6I+HUamNoX4kpmKS3z
PJ5ZFDLwTBgVaZKx8F0+K6llwniIOMAqf+tpE8cIhiD252gWekE7GxBsG+lxyJIy
RYWpWQxGyX9ilHSm2fmKRh/+R/MeubZYjKNm+FNG8mwsvK6NVz/Lb4NiSDGrCwx9
KYQ2sHd/VancFPE0MIWbgqaQH0knzQw+urf/1t/Nw45TMFx4vxM2flm5xGafh/Ai
1cFeojYZD7TtkFo5Z4s0AMzgGygSq+J4cQhN0lonDCwWf4e2cEImbywvZ5mh0IKC
s/A+TwtsM+G35qjRz7gQZ2qOCVuKBiPIzie7XRaT3QsmONE1peMYpAt2dfTOCSYN
AmxHEmFm9pQfnNAFpbFEF7uOIhh86VCkhIrGA5DJ9xw48peZ/vs=
=Zko3
-----END PGP SIGNATURE-----

--Obcz3A34aAvyOnLx--