Subject: Re: BUG #17148: About --no-strict-names option and --quiet option of
 pg_amcheck command
To: Daniel Gustafsson <daniel@yesql.se>, Julien Rouhaud <rjuju123@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>, Tom Lane <tgl@sss.pgh.pa.us>,
 Euler Taveira <euler@eulerto.com>, chenjq.jy@fujitsu.com,
 PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
References: <17148-b5087318e2b04fc6@postgresql.org>
 <B9A9C944-9EAC-421C-8044-EF109ADAC4D4@yesql.se>
 <A6A434CC-AA6D-4DD2-A26E-B6E226CCAD9B@yesql.se>
 <fb17eac7-f5cf-4e6f-9b67-f5fb4855d1d9@www.fastmail.com>
 <F5A1A42D-184C-46B7-8FBF-17AA000D28E0@yesql.se>
 <429f6e0e-31eb-4741-8bf8-e9e827b3076d@www.fastmail.com>
 <acde4807-7cd4-2c15-b73a-ac8e71c71191@enterprisedb.com>
 <53F68B28-4FDB-4AC9-882C-A620D3389EB0@yesql.se>
 <1426271.1629294170@sss.pgh.pa.us>
 <CABUevExiPH790T7+xmFRHW1cht4d8VH88LZ9EP1FrKj25ydy1Q@mail.gmail.com>
 <55B64E31-A6E6-4805-9650-AE3A78A2DF34@yesql.se>
 <3CF09700-ECE9-4FAF-B22C-7E55BC09AD01@yesql.se>
 <CAOBaU_afptUUcB1FL4esMvjtY-qah5aPWhYGWPvXVEn7AoSHGQ@mail.gmail.com>
 <B64B6CC3-1672-4010-B96B-7D9D547701D9@yesql.se>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <aa186eac-2701-210a-bbf1-3e1bec945e23@enterprisedb.com>
Date: Fri, 27 Aug 2021 13:21:52 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.13.0
MIME-Version: 1.0
In-Reply-To: <B64B6CC3-1672-4010-B96B-7D9D547701D9@yesql.se>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/aa186eac-2701-210a-bbf1-3e1bec945e23%40enterprisedb.com>
Precedence: bulk

On 20.08.21 12:49, Daniel Gustafsson wrote:
>> On 19 Aug 2021, at 04:45, Julien Rouhaud <rjuju123@gmail.com> wrote:
>>
>> On Thu, Aug 19, 2021 at 2:53 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>>>
>>>> On 18 Aug 2021, at 15:49, Daniel Gustafsson <daniel@yesql.se> wrote:
>>>>
>>>> Since there is consensus for removing --quiet, I’ll propose a patch in a bit
>>>> for removing it and fixing up the tests.
>>>
>>> Turns I was a bit undercaffeinated when skimming the tests, it really wasn’t
>>> that invasive.  The attached diff removes --quiet and fixes up the tests and
>>> docs to match.  Anyone who wants to keep --quiet should..  ehm, not keep quiet.
>>
>> The patch looks good to me.
> 
> Applied to master and 14, thanks for review!

I see that we still have the PQsetErrorVerbosity() call for --verbose, 
and we still issue warnings with --no-strict-names.  Did we want to keep 
these two behaviors?