Message-ID: <aa56abed-7444-3508-4216-a4e10b79c295@gmail.com>
Date: Mon, 28 Oct 2024 11:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: BUG #18674: Partitioned table doesn't depend on access method it
 uses
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>,
 Kirill Reshke <reshkekirill@gmail.com>
Cc: pgsql-bugs@lists.postgresql.org
References: <18674-1ef01eceec278fab@postgresql.org>
 <CALdSSPgvKRX1pZE7GLKpDESw0wbBH4qBZPQSdSKYY2btCrfuSQ@mail.gmail.com>
 <CALdSSPjGzuo0eodxdP9WZS4Q7nvv-2k3W=9ie2XoMedBjkr1Fw@mail.gmail.com>
 <Zx879T_oFkiHv9St@paquier.xyz>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: <Zx879T_oFkiHv9St@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/aa56abed-7444-3508-4216-a4e10b79c295%40gmail.com>
Precedence: bulk

Hello Michael and Kirill,

28.10.2024 10:23, Michael Paquier wrote:
> The path of adding the dependency between an AM and a table/matview is
> heap_create_with_catalog() when these are defined.  We can just expand
> that for partitioned tables and simply fix the problem.  Attached is a
> patch to do that, with tests around create_am.sql based on USING
> checking the contents of pg_depend.

0001-Fix-dependency....patch works for me, but while testing, I've also
observed another questionable behavior:
CREATE ACCESS METHOD heap2 TYPE TABLE HANDLER heap_tableam_handler;
SET default_table_access_method = heap2;
CREATE TABLE pt (a int) PARTITION BY LIST (a);
\d+ pt

doesn't show heap2 as access method for the table.

Shouldn't default_table_access_method affect partitioned tables?

Best regards.
Alexander