Message-ID: <ab22a3c7-8045-f30c-ebbf-ac5cbae0b739@gmail.com>
Date: Wed, 20 Sep 2023 09:00:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: BUG #17928: Standby fails to decode WAL on termination of primary
Content-Language: en-US
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>, Sergei Kornilov <sk@zsrv.org>,
 Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-bugs@lists.postgresql.org, Fujii Masao <masao.fujii@oss.nttdata.com>
References: 
 <CA+hUKGJV1Ow_S86Fj25J_orojXkn4WPeARyY8-Xr88c85rJHEQ@mail.gmail.com>
 <ZPaq3KwARVHWzune@paquier.xyz> <ZP+4YYrPZk0GFlc3@paquier.xyz>
 <CA+hUKG+=jiXcE9uOkf3KHDb_ZAkjahQ8jzBXsEOAoXH=y0Z=uw@mail.gmail.com>
 <ZP/I93ZSL0Mvt5rS@paquier.xyz>
 <CA+hUKGKj3vgopo9YC3hk7zDgkAGAA+aP6ZPGgTa-QVLvn7EK7A@mail.gmail.com>
 <ZQTwsT6tsbx6BYn3@paquier.xyz>
 <CA+hUKGJOXdpWO_6wK0q3jsEwk5cJ6fAQj1T1mE9cFj6R+tPtrw@mail.gmail.com>
 <c3f123ca-03f7-b7ce-1e49-f8fee4c16545@gmail.com>
 <CA+hUKGK53D8OYxTQiQ9qzJsA7ymcHTqqh7V_PUM06TCT=HOJqg@mail.gmail.com>
 <ZQlvihvHo5JspVpV@paquier.xyz>
 <CA+hUKGJVke-Dwy8-ehuCj_cF8d94C-L3gR8G5=wA967FgFimGA@mail.gmail.com>
 <ee604ee6-f464-1502-0289-f1046c85c182@gmail.com>
 <CA+hUKGKp_Go=EqA65r6naxrmXFfD-uH3DwPbm7tRCu9d2T=VyQ@mail.gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: 
 <CA+hUKGKp_Go=EqA65r6naxrmXFfD-uH3DwPbm7tRCu9d2T=VyQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/ab22a3c7-8045-f30c-ebbf-ac5cbae0b739%40gmail.com>
Precedence: bulk

20.09.2023 01:51, Thomas Munro wrote:
> The solution in this version is to call get_insert_len() instead of
> using the result of emit_message() for the values returned by the
> advance_XXX() functions.  The result of emit_message() is actually the
> LSN of the following COMMIT record so can't be used directly for
> building xl_prev chains.
>
>> And may be "xlp_prev" is a typo?
> Fixed.

I've retested this version (patches for all branches, plus wal_log_hints,
plus Valgrind, and also retested code changes with my
099_restart_with_stanby.pl) and found no issues. IMHO, this patch is
ready to float off.

Thank you!

Best regards,
Alexander