Content-Type: multipart/alternative;
 boundary="------------vABvAiptlIHLII8fphxWL4ly"
Message-ID: <ab31fa66-face-4866-8e2f-b947f4ba42a6@windriver.com>
Date: Wed, 6 Mar 2024 16:51:41 +0800
User-Agent: Mozilla Thunderbird
Content-Language: en-US
To: pgsql-bugs@lists.postgresql.org
Cc: Changqing Li <changqing.li@eng.windriver.com>
From: Changqing Li <changqing.li@windriver.com>
Subject: A build failure since only include header "postgresql/server/port.h"
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?S1lBYkl4YnNPZEh4d3hXQXp6ZGY4eUxhOWVkOVY5cGtXSDIwQ0R4R0tENFNo?=
 =?utf-8?B?SnhZcDEvRllpWFhMVUgyVkJuYzQreHI2cnZEZVdaNDRNZ0Z5a2s0akk3UjhD?=
 =?utf-8?B?U0NUUUt5dEdmWUhjVzBUNHFwT2F3Q3ZJcVVCeWNiSGpvQUZmaTNyT2syU2Zp?=
 =?utf-8?B?MWNYN0szRlIyenZQaUR5SGs0VUtTTDdreUU2ZnFLV0pHUnFNWndIdkY1NWg2?=
 =?utf-8?B?MWoyTzNYaDhzR1ZweEFYMUxudDdDSDZ2WGlkWTQxSkRpdVpxd0ZHV0U3R3da?=
 =?utf-8?B?Z0x3c2NvRDQ3dFkvcGJHVUJDTmFzaU5LanJTODRXd1BCZGlPVk1TTXBYVXpt?=
 =?utf-8?B?NmErVUNUUjZiZll1SS9QN0o1ME1KOTVtSzVwR1BpMXBqSmV3QUN4Vlp3Y3ZC?=
 =?utf-8?B?K0N1bW1VSnZGa0I5Uy83RmxHbmcxeVBldUhTNVJYUGN6VXZBUE05ZkJaTUV0?=
 =?utf-8?B?cWhFU1RVQW1EeU9zeS9hYU4za3NYYk9ZR1JHTjJ6WDdXeDhHSDdSR0RQaE1J?=
 =?utf-8?B?MGUrL1ZieVVXOUFVbTNLdHY2QzVDU3o4Q1BueTYxbFRiRmlnWlZjWXdLeGlT?=
 =?utf-8?B?SHdFM3gvVm1kU1BpZzdzend5RUQ1R0JDL2RKTG4zazlmTC9CWFRPOHlkL29P?=
 =?utf-8?B?VXhKWDArUWZHZjBmZUxZYzNWa3VPR2tTK3R4SHQrdE10eGtxaWZrVEY2aUFV?=
 =?utf-8?B?d3BEblNDcGhGT01hMmM5VVZ5aTQ3ZWY3YWU3bndCZEViREhKQ25qTytZVGNV?=
 =?utf-8?B?anIwVERGQlNZUVVOTGFSaTd2QTZjUVZ5YThxdGhGRk5SWDBhOExYRnBQL2Vz?=
 =?utf-8?B?cjBOSHBzYnlHQlRORDh0YTdYckxVdklyZU52K3hZQllnQmZ3dDdubTNrd0Rm?=
 =?utf-8?B?UTJCd2c0R0Z5a0psaW04R3VLOVovVllFUGR1M1BVVUVRTTRoNjEvYXBIRUFx?=
 =?utf-8?B?SDZrZ0x2d09Ed3JvQ1BLLy80dVlFTGJEbWx0UTd3c3QwaHlQQ3hwdzdrWVov?=
 =?utf-8?B?WFFpQUN6dnZZRnJuMG4yY1M5Z3lyenJCRldkWjlCRlBUNU5DcTBsYkx5UEsx?=
 =?utf-8?B?QmdqdWcxQUVaRVUxajZaTUpZZ1BPejlhVVI4QzBlVGdjZGFYQ3hTbWZVaFNh?=
 =?utf-8?B?R0d5MU1Sa2R3WGRlVi8zOGpMMEVGS2JnanU5ck5pRm1uT0hVSTZhUHVuT0ZO?=
 =?utf-8?B?YkdHc1lrMW5hQll3aHcreW0yTkEwU0xJWFUrV1hnQ250R3J3TzZJMHZOZUtR?=
 =?utf-8?B?emJ5U0kxKytjcVNmZ3R3NGFNYzZBY1JYbmR0RzA1OG9uZS9GWnF6RjBKbzZL?=
 =?utf-8?B?amk3eXNxTEo4c2VseGxCNy80UExheXhLWXQ4Syt5ZzUwd1loRHQ5UG1qNnVP?=
 =?utf-8?B?UHVQRW1EVkl1Z29Xa0ZSVGJKZjBmVmV2aXpOOUV1bVpiQkZ1dlo4OExEeUpK?=
 =?utf-8?B?VlIxdzJFK2M0MWtlQk5hTDhvdEw3MmJoRnF4WHp3eE9IWDRiWGJQMlI5Tkgv?=
 =?utf-8?B?MGp6K0RpdTJUd2MzcnI1WjJLZFI2cTB0anVXeE9RZCtETDJqL0JyalBUOGpV?=
 =?utf-8?B?SEpjdmZWU2hMMEF0THhkTmJId2RUWjZzM1h2Y1B0V0lOTU8yUlFhbmlWakZI?=
 =?utf-8?B?cGRSSnVkNEJBMUl3enBHNStxYUM1VHI2NlF5UmQyVzUrOUt4WmlGMGFkcVY0?=
 =?utf-8?B?MlVneGhHU2FVYmc2MllvQkJjeXRnd0l6WE9QdWo1N3lLTXFSV2JXemVCYjZN?=
 =?utf-8?B?dkFLYWxlRzJlY0hvQmE0SnpqcHVBL25jR05vRGJvb0tuRFpUR3UxdVN6L1BM?=
 =?utf-8?B?Zmh2eDVkQmVzR3dHZ3RKTEpIeFdOT0xreFc4RFZGZEdPSUs4bWEvYksrd0ZH?=
 =?utf-8?B?R3VIY1RNRzdsUHJobFNPNzJTR1ZiRndCN1YrN2toQVlMY0ZnK2VlQjQ3cWN3?=
 =?utf-8?B?SW95K2o5SFh0SFRrZWxhY3k1WVBiVFFocWd1amt6b01sejdaWC9oZWQ5MDdR?=
 =?utf-8?B?QUFtYUt5MWhmNFFFL1hORGJob2FpckEzcFJrYnVJOG10eW40d3FPMGhJL0Yx?=
 =?utf-8?B?YndaK2FkM1l4VDVFeDVVUDVhNVFGOXpEUERCRCs5bjRmT1lEN3JqRysyOU51?=
 =?utf-8?B?S2YxOVJWLzQ4REhhM2w4WmlmdGJTa21QTVkxcmRXSHVLZ2VPdHV1TXJTSWlI?=
 =?utf-8?B?K3c9PQ==?=
X-OriginatorOrg: windriver.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 
 09a09aa3-8f64-4184-2ed0-08dc3dbaa803
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB7312.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 08:51:47.4630
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 8ddb2873-a1ad-4a18-ae4e-4644631433be
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 
 J1nxmvqOzfbGP4a65Q93HYWuTrA+JgMvCEPZtB09tNgDXToWjd6n/k5wDjeZRTb7s2lC6hqmXg/ONQ1ArHq1zre8TZEoSUpPqPjuKqKxGrE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8517
X-Proofpoint-ORIG-GUID: wbvkMoRrE9vNpPjjMqF62NHaAmbwrwOn
X-Proofpoint-GUID: wbvkMoRrE9vNpPjjMqF62NHaAmbwrwOn
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-06_04,2024-03-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0
 phishscore=0 malwarescore=0
 suspectscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0
 priorityscore=1501 adultscore=0 bulkscore=0 clxscore=1011 mlxlogscore=756
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.19.0-2402120000 definitions=main-2403060069
List-Id: <pgsql-bugs.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-bugs@lists.postgresql.org>
List-Owner: <mailto:pgsql-bugs-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-bugs>
Archived-At: 
 <https://www.postgresql.org/message-id/ab31fa66-face-4866-8e2f-b947f4ba42a6%40windriver.com>
Precedence: bulk

--------------vABvAiptlIHLII8fphxWL4ly
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Hi,

I am building pgpool2, and there is  a snprintf.c,  which use 
PG_STRERROR_R_BUFLEN, so I include header "postgresql/server/port.h".

It works well before.  but after I upgrade postgresql from 15.5 to 
16.2,  I will met following error:

usr/include/postgresql/server/port.h:488:28: error: a parameter list without types is only allowed in a function definition
   488 | typedef void (*pqsigfunc) (SIGNAL_ARGS);
       |                            ^

Since commit 
https://github.com/postgres/postgres/commit/b66fbd8afe6eb80e3e48495e002fda9aa92df583#diff-c6b9d5a7f7f2c4a96f8b818cf7845acda4cd6297bc2f7d7181be24d8e35dbf32, 


SIGNAL_ARGS is used in port.h, it is defined in c.h,  But port.h don't 
include c.h, and cause above error.   Should we include c.h in port.h?

I also tried include c.h in port.h,   but met another error when 
building pgpool2.  I also reported this to pgpool2 community: 
https://www.pgpool.net/mantisbt/view.php?id=830


Could you help to give an suggestion about how to fix this issue?


Thanks

Changqing


--------------vABvAiptlIHLII8fphxWL4ly
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body>
    <p>Hi, <br>
    </p>
    <p>I am building pgpool2, and there is&nbsp; a snprintf.c,&nbsp; which use
      PG_STRERROR_R_BUFLEN, so I include header
      &quot;postgresql/server/port.h&quot;.</p>
    <p>It works well before.&nbsp; but after I upgrade postgresql from 15.5
      to 16.2,&nbsp; I will met following error:</p>
    <pre>usr/include/postgresql/server/port.h:488:28: error: a parameter list without types is only allowed in a function definition
  488 | typedef void (*pqsigfunc) (SIGNAL_ARGS);
      |                            ^

</pre>
    <p>Since commit
<a class="moz-txt-link-freetext" href="https://github.com/postgres/postgres/commit/b66fbd8afe6eb80e3e48495e002fda9aa92df583#diff-c6b9d5a7f7f2c4a96f8b818cf7845acda4cd6297bc2f7d7181be24d8e35dbf32">https://github.com/postgres/postgres/commit/b66fbd8afe6eb80e3e48495e002fda9aa92df583#diff-c6b9d5a7f7f2c4a96f8b818cf7845acda4cd6297bc2f7d7181be24d8e35dbf32</a>,
      <br>
    </p>
    <p>SIGNAL_ARGS is used in port.h, it is defined in c.h,&nbsp; But port.h
      don't include c.h, and cause above error.&nbsp;&nbsp; Should we include c.h
      in port.h?&nbsp;</p>
    <p>I also tried include c.h in port.h,&nbsp;&nbsp; but met another error when
      building pgpool2.&nbsp; I also reported this to pgpool2 community:&nbsp;
      <a class="moz-txt-link-freetext" href="https://www.pgpool.net/mantisbt/view.php?id=830">https://www.pgpool.net/mantisbt/view.php?id=830</a></p>
    <p><br>
    </p>
    <p>Could you help to give an suggestion about how to fix this issue?
      <br>
    </p>
    <p><br>
    </p>
    <p>Thanks</p>
    <p>Changqing<br>
    </p>
    <p></p>
    <p><br>
    </p>
  </body>
</html>

--------------vABvAiptlIHLII8fphxWL4ly--