Message-ID: <abb6240f-4fa9-47a0-8b4d-89573ad957fc@postgrespro.ru>
Date: Wed, 28 Feb 2024 14:25:04 +0700
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: "type with xxxx does not exist" when doing ExecMemoize()
Content-Language: en-US
To: Tender Wang <tndrwang@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 David Rowley <dgrowleyml@gmail.com>
References: 
 <CAHewXNnT6N6UJkya0z-jLFzVxcwGfeRQSfhiwA+NyLg-x8iGew@mail.gmail.com>
 <d3da9856-0394-48e6-9f41-543c589e9585@postgrespro.ru>
 <CAHewXNm9KEn8CMOK4q0zutkX4BK8o754LgQbzYKgcj7_g1GgjQ@mail.gmail.com>
 <7a6a807c-193f-4333-937b-8211b1330579@postgrespro.ru>
 <CAMbWs481ZsCBi+63mRatE0VByijSFwhu=OBARFptM4rsza-2Yw@mail.gmail.com>
 <aacdf19f-778d-4a92-a2ba-2fa5f56401b4@postgrespro.ru>
 <CAHewXNknsjG6JoDM48FWyyiFesG=K18vJMOY_LzPBDNV7DvmuQ@mail.gmail.com>
From: Andrei Lepikhov <a.lepikhov@postgrespro.ru>
Organization: Postgres Professional
In-Reply-To: 
 <CAHewXNknsjG6JoDM48FWyyiFesG=K18vJMOY_LzPBDNV7DvmuQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/abb6240f-4fa9-47a0-8b4d-89573ad957fc%40postgrespro.ru>
Precedence: bulk

On 28/2/2024 13:53, Tender Wang wrote:
> The attached patch is a new version based on v3(not including Andrei's 
> the test case). There is no need to call datumCopy when
> isnull is true.
> 
> I have not added a new runtime memoryContext so far. Continue to use 
> mstate->tableContext, I'm not sure the memory used of probeslot will 
> affect mstate->mem_limit.
> Maybe adding a new memoryContext is better. I think I should spend a 
> little time to learn nodeMemoize.c more deeply.
I am curious about your reasons to stay with tableContext. In terms of 
memory allocation, Richard's approach looks better.
Also, You don't need to initialize tts_values[i] at all if tts_isnull[i] 
set to true.

-- 
regards,
Andrei Lepikhov
Postgres Professional