Date: Wed, 18 Mar 2026 14:29:58 -0500
From: Nathan Bossart <nathandbossart@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: pgsql-bugs@postgresql.org
Subject: Re: ALTER FOREIGN DATA WRAPPER can drop dependency on handler
Message-ID: <abr9Nhe8UOdoN10L@nathan>
References: <35c44a4b7fb76d35418c4d66b775a88f4ce60c86.camel@j-davis.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <35c44a4b7fb76d35418c4d66b775a88f4ce60c86.camel@j-davis.com>
Archived-At: <https://www.postgresql.org/message-id/abr9Nhe8UOdoN10L%40nathan>
Precedence: bulk

On Wed, Mar 18, 2026 at 12:09:54PM -0700, Jeff Davis wrote:
> --- a/src/backend/commands/foreigncmds.c
> +++ b/src/backend/commands/foreigncmds.c
> @@ -786,6 +786,11 @@ AlterForeignDataWrapper(ParseState *pstate, AlterFdwStmt *stmt)
>  		ereport(WARNING,
>  				(errmsg("changing the foreign-data wrapper handler can change behavior of existing foreign tables")));
>  	}
> +	else
> +	{
> +		/* handler unchanged */
> +		fdwhandler = fdwForm->fdwhandler;
> +	}

This matches what we do for the validator a few lines down, so it makes
sense to me.  Could it be worth adding a test or two?

-- 
nathan