Feedback-ID: ie0a040ee:Fastmail
Message-ID: <ac80cff7-cc8f-4eee-ba4f-12d0fc902e0c@eisentraut.org>
Date: Wed, 20 Mar 2024 07:02:48 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Regression tests fail with musl libc because libpq.so can't be
 loaded
Content-Language: en-US
To: Christophe Pettus <xof@thebuild.com>,
 Wolfgang Walther <walther@technowledgy.de>
Cc: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
 PostgreSQL Bugs <pgsql-bugs@lists.postgresql.org>
References: <fddd1cd6-dc16-40a2-9eb5-d7fef2101488@technowledgy.de>
 <2852940.1710599083@sss.pgh.pa.us>
 <443da167-ee01-47d2-9c83-105694b4cbd5@technowledgy.de>
 <CA+hUKGJhp0opkCybdOrbQSMyHX8cRuLh2ygkqtivizCqK6kfOA@mail.gmail.com>
 <CA+hUKGL=CE7Gg5p7ijbtEWhnPR-Ua4gemhuz-kQpSy3dD1+SYQ@mail.gmail.com>
 <ef1b47df-0808-4bd7-b08c-5153d5d75f4c@technowledgy.de>
 <68C88EE3-CDCB-4993-9173-3A773F491F3A@thebuild.com>
From: Peter Eisentraut <peter@eisentraut.org>
In-Reply-To: <68C88EE3-CDCB-4993-9173-3A773F491F3A@thebuild.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/ac80cff7-cc8f-4eee-ba4f-12d0fc902e0c%40eisentraut.org>
Precedence: bulk

On 17.03.24 11:33, Christophe Pettus wrote:
>> On Mar 17, 2024, at 02:44, Wolfgang Walther <walther@technowledgy.de> wrote:
>>
>> Nailed it. PS_USE_NONE fixes it.
> 
> Given the musl (still?) does not define a preprocessor macro specific to it, is there a way of improving the test in pg_status.c to catch this case?  It seems wrong that the current test passes a case that doesn't actually work.
> 

We could turn it around and do

#if defined(__linux__)
#if defined(__GLIBC__) || defined(__UCLIBC__ )
#define PS_USE_CLOBBER_ARGV
#else
#define PS_USE_NONE
#endif
#endif