Subject: Re: BUG #17148: About --no-strict-names option and --quiet option of
 pg_amcheck command
To: Euler Taveira <euler@eulerto.com>, Daniel Gustafsson <daniel@yesql.se>
Cc: chenjq.jy@fujitsu.com, pgsql-bugs@lists.postgresql.org,
 Julien Rouhaud <rjuju123@gmail.com>
References: <17148-b5087318e2b04fc6@postgresql.org>
 <B9A9C944-9EAC-421C-8044-EF109ADAC4D4@yesql.se>
 <A6A434CC-AA6D-4DD2-A26E-B6E226CCAD9B@yesql.se>
 <fb17eac7-f5cf-4e6f-9b67-f5fb4855d1d9@www.fastmail.com>
 <F5A1A42D-184C-46B7-8FBF-17AA000D28E0@yesql.se>
 <429f6e0e-31eb-4741-8bf8-e9e827b3076d@www.fastmail.com>
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Message-ID: <acde4807-7cd4-2c15-b73a-ac8e71c71191@enterprisedb.com>
Date: Wed, 18 Aug 2021 13:44:00 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <429f6e0e-31eb-4741-8bf8-e9e827b3076d@www.fastmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/acde4807-7cd4-2c15-b73a-ac8e71c71191%40enterprisedb.com>
Precedence: bulk

On 17.08.21 19:00, Euler Taveira wrote:
>> Well, problem is that it’s plain not true.  If you pass --quiet 
>> --verbose you
>> will get a lot of output, albeit less than if not using --quiet.  
>> Consistency
>> with other tools is obviously good, but only when it’s correct IMO.
> Indeed, it is not a good design. It should be one option --verbose that
> increases the verbosity according to a number or an enum value. --verbose=0
> means "quiet". However, that ship has sailed.

I was confused by this the other day as well.  Having all of

   -q, --quiet                     don't write any messages
   -P, --progress                  show progress information
   -v, --verbose                   write a lot of output

is surely a lot.

If you look at what --quiet does, it

1) disables logging warnings if there are no matches for object patterns 
and --no-strict-names is given, and

2) sets PQsetErrorVerbosity(free_slot->connection, PQERRORS_TERSE).

I think this both of these things could be deleted and we could get rid 
of the --quiet option, to simplify all this.  Neither of these behaviors 
is in common with any other PostgreSQL tool.