public inbox for [email protected]  
help / color / mirror / Atom feed
From: Michael Paquier <[email protected]>
To: [email protected]
To: [email protected]
Subject: Re: BUG #19422: Malformed raius packet
Date: Fri, 10 Apr 2026 15:21:20 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>

On Tue, Mar 03, 2026 at 04:20:37PM +0900, Michael Paquier wrote:
> Looking at RFC 2865, there is nothing about a limit of size for the
> attributes.  This means that we are only limited by our
> RADIUS_BUFFER_SIZE.  Hence, we could bump radius_attribute.length to
> uint16 and add some casts in the check for RADIUS_BUFFER_SIZE so as
> we don't overflow the addition before adding an attribute to the
> packet?  On the other hand, we could aim for simpler and just reject
> any attributes larger than 255 bytes.  I doubt that anybody would be
> insane enough to use fields larger than that 255 bytes anyway.  Both
> solutions are equal in simplicity here.

It is worth noting that RADIUS support has been removed as of Postgres
19 in commit a1643d40b308, so I doubt that we need to take any action
here.

Or would somebody be interested enough to send a patch?
--
Michael


Attachments:

  [application/pgp-signature] signature.asc (833B, 2-signature.asc)
  download

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: BUG #19422: Malformed raius packet
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox