Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 27 Apr 2026 16:23:01 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, pgsql-bugs@lists.postgresql.org
Subject: Re: to_date()/to_timestamp() silently accept month=0 and day=0
Message-ID: <ae8O1YKVbykFGcsM@paquier.xyz>
References: <CAJTYsWWNfF+hMpbsTDF8NMr+AuqoDfNxR=oHUZm7xqGP+dJ9rA@mail.gmail.com>
 <aenQ37wBgKqZb7a8@paquier.xyz>
 <FE1D12FF-7E5D-4ED0-A59F-BEA6DEF7EE2C@yesql.se>
 <1444609.1776958814@sss.pgh.pa.us>
 <CAJTYsWUJFHhqiGD+6vw6m0ELqjajoKev2UutFUMB2uQDjm6+TA@mail.gmail.com>
 <aeqZukF8X29eWtqy@paquier.xyz>
 <B96867CD-3533-40BA-AE09-43DB2CA5DC48@yesql.se>
 <CAJTYsWV1wEuv2ZbBHt4BQ2O4-Na6JdxSU3b--GFzs-j5cG_pVA@mail.gmail.com>
 <CAJTYsWVEk5vdy8of2DCWzDNJgHUNL0p0Dt6b1zkgmvmNo3ht6w@mail.gmail.com>
 <1B595919-2596-4CB3-BC39-DDCCB9876E56@yesql.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="9gUoB0IdXOpycywT"
Content-Disposition: inline
In-Reply-To: <1B595919-2596-4CB3-BC39-DDCCB9876E56@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/ae8O1YKVbykFGcsM%40paquier.xyz>
Precedence: bulk


--9gUoB0IdXOpycywT
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 24, 2026 at 02:44:04PM +0200, Daniel Gustafsson wrote:
> LGTM for the most part, I don't really think we need to use both to_date and
> to_timestamp though, we can save a few cycles there.  I rewrote the comments to
> match the rest of the file, and moved to where to where we test for year 0000
> since it seems like a better place.  Also took the liberty to use year 100 in
> one of the testcase, while the year is superfluous for the test in question,
> year 100 was previously untested so this will increase test coverage for free.

That seems fine to me.  If we decide to change this behavior later on
and error on these pattern, at least we'll know about them.
--
Michael

--9gUoB0IdXOpycywT
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnvDtUACgkQnvQgOdby
QH1qMw//QnQ0XA1W0NhqvqZU18XckCsVfYb7Dc2x8Upt2hWpmuDqBwXPU+uOQKRE
984FwtvSfqu5pN3owzi8xlR/LL0JcyKlF4uI6AMScCrrhNqGLXkCHKlzqYWTnJeY
AZGkQ2uhOoPatatBcGPcTu+I7AUIivwWWFyHufK53vewSqM6vNBCq7nwFOgZWvim
lUoW+8wYkUo1LMuaUhBSfQThdoVJQjPV3wTpTuyhazuwNigRYZzc2dPlZdWN9Ygd
fQybTsLjX77SNDV2mxWDb/0pUr+5CZnjJr7Jg/ILK4A6OTy+t+itw6C+NJSxG8Pj
VLDR/RyeIww8fZjKkm+VRs1p7CsprRN8Yvxlas26VUMOICA62C812R8F4l0F+6Jk
QgPz57sHXPkPDLz7OfoYDxe54rEwgOix3gCeo8B46epe+KeyBz0/MHUgnrfZuX4b
MAVO5EbgaIP/0PRmrUYqG+w2WAOJRUI1okT6xU0jGV3XC50+Hu8GLiAXB7SvYpw2
3rdLfvoU+mZWSyzCNg2vnI9vsif8+miKTxkmgCxZxRHNl/jOFkLURRWWpybx1v4/
3KTLeUUSMau98hrGW+84B9WBZC55nWOd0Rk38qLLVdHRJU3w7rp62UWdXAqnfEJ8
sE1d7q7iqkA28lTsaxARoCuDXIJr+LyzT1oRfGzhFQaR4DDabkw=
=npdR
-----END PGP SIGNATURE-----

--9gUoB0IdXOpycywT--