Feedback-ID: i0fe9450f:Fastmail
Date: Sat, 25 Apr 2026 07:32:04 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Joe Conway <mail@joeconway.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	ansh01072001@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19457: RE: pgp_sym_encrypt silently accepts non-FIPS
 ciphers (bf, cast5, 3des) when OpenSSL is in FIPS mod
Message-ID: <aevvZLh_lYs-jo-s@paquier.xyz>
References: <19457-4bab15c17aea36c7@postgresql.org>
 <3A2299BC-1684-4CEB-BD65-1DEBFB446F24@yesql.se>
 <aervokmPnxlO6Oqs@paquier.xyz>
 <99F0B98C-2276-4C01-B553-BDD0806CAEEF@yesql.se>
 <1612210.1777041534@sss.pgh.pa.us>
 <71c66a3b-4c0d-447b-8b84-ef15ac047561@joeconway.com>
 <98BDEEAC-A401-41D8-B9C0-A1EBEBF2E08E@yesql.se>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="6JewWzP4caI3GBv0"
Content-Disposition: inline
In-Reply-To: <98BDEEAC-A401-41D8-B9C0-A1EBEBF2E08E@yesql.se>
Archived-At: <https://www.postgresql.org/message-id/aevvZLh_lYs-jo-s%40paquier.xyz>
Precedence: bulk


--6JewWzP4caI3GBv0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 24, 2026 at 05:27:27PM +0200, Daniel Gustafsson wrote:
> Sounds good, I'll have a look at the two proposed patches.

Thanks, Daniel.

FWIW, the patch sent by Shishir is mostly a copy-paste of what I have
provided in terms of tests (exactly the same) and documentation
(mostly the same).  He has added a paragraph about the set of ciphers
that are allowed in FIPS.  Do we actually need to mention these
explicitely? Perhaps a link to an external source would be more
adapted?  I am not convinced that this is a good addition for
pgcrypto, but feel free to disagree.

The second difference is this diff, impacting the outputs of the
tests and the decision-making:
@@ -162,6 +163,9 @@ pgp_load_cipher(int code, PX_Cipher **res)
     if (i =3D=3D NULL)
         return PXE_PGP_CORRUPT_DATA;
=20
+    if (!i->fips_allowed)
+        CheckBuiltinCryptoMode();

Daniel should have the last word on that, I guess, as it is his
feature, but the semantics I have chosen are harder than that:
- If the GUC is off, block everything.
- If the GUC is on, allow everything.
- If the GUC is fips, block the non-fips ciphers and allow the fips
ciphers.

This behavior would be more consistent and symmetric with the other
functions, at least IMHO.

Thanks,
--
Michael

--6JewWzP4caI3GBv0
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmnr72QACgkQnvQgOdby
QH14lg/9FAjXbnfI8+L89QZYAjRjoJyJMgGzDBYFsdohCxAfjx6Cd25Hhnqb8zxG
ljmUb90W+o21fjYvHVY9caUa8dxrCqh10w7oGkIQQhazRSiPdKkWueOZW0tSGyV6
CoonH5ozQ0PAw8gbIcy01qp3ChXF1Yqtc7XMMCCC3L7VRe52MVrMMlpLmYnrjjS8
b1nd22lww12oWf9i5Eq5w1wmvvqj48rIDSS8jVkQygW2+DiNmb2x6lqKvWAvyFss
ebVAhkn8gPqM461vS+6TFA4fStN1CBJhsAAkqjUDe6mQeQmmDbHiViS5ee+O7HiY
Nfo8g9d/Szw5QZI/dFhUhh1MXLENRKuf+QKiWGVFOsKk7GLq6UYsPpf2rv33m0+P
POjq3lLATbgYkJX48ZTZ8XhK5K0yqJzW1v3L4MSLbiV6aNHMeyEhYi558YMQr8cw
dHrR9WWVSM5b0tMeshTyyFikOCb0VUBxFwKu8L3g21Xo1k0eU1yyjK8Qn3V23kJy
r6gM2BRmjXYp76M5r/aJlmEfxOJ7zPEdQUzdBSfTDWjeMS3IJyKn/VOQEuo4nrSw
ORzkm7jexL16mX+TH1UeuL+mMrwsoQg93+t3HDpryTezZMUSRaWA1UyW9i+lV8ZX
nXB92Ou2G1YylNFkXQejdWhm27wXPF7ZYtupCKIw6oXGXlwPkOo=
=151y
-----END PGP SIGNATURE-----

--6JewWzP4caI3GBv0--