Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUOC3-0017pz-0C for pgsql-bugs@arkaria.postgresql.org; Tue, 02 Jun 2026 12:26:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wUOC1-00ETWy-0n for pgsql-bugs@arkaria.postgresql.org; Tue, 02 Jun 2026 12:26:01 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wUOC0-00ETWq-11 for pgsql-bugs@lists.postgresql.org; Tue, 02 Jun 2026 12:26:00 +0000 Received: from fout-a2-smtp.messagingengine.com ([103.168.172.145]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wUOBy-00000000k7h-1FX4 for pgsql-bugs@lists.postgresql.org; Tue, 02 Jun 2026 12:25:59 +0000 Received: from phl-compute-09.internal (phl-compute-09.internal [10.202.2.49]) by mailfout.phl.internal (Postfix) with ESMTP id E3B74EC00F3; Tue, 2 Jun 2026 08:25:56 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-09.internal (MEProxy); Tue, 02 Jun 2026 08:25:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kurilemu.de; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to; s=fm2; t=1780403156; x= 1780489556; bh=zcKrkJLkz6Cm0RaPOKKGI7bHFc7FSem4y5A10o5G8Qw=; b=F gClE9LexuYkK09uMOPthWctY+vOjwx8TTT1heMh0VKExj0+rW//7bFrx/shyo7gT FFu8zdgyvGlihd+PDPwlkhHR71k7UFHM96FnqWSXPqtva3SD4rZfE4Rkb2uw18g6 hIbojSLLaCoIPWSZkx+KolrLEpTU7LGZLwvZ90Eq6eaQlJoMlQLVRt/lB5Unoppt B6SG2oU7qbLOGSyNRrS1kowSf/AroovA6+nDvG/gCKw00tglC6rJT6HGtgmd9IBi Auvrujm7e422SECDkSssaxbQm88lIJE5cqFon72qIZOeLsobRXK/Mkkku5fzcPSx 9/h5y6mFdDctmOxXSr/RA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :reply-to:subject:subject:to:to:x-me-proxy:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; t=1780403156; x=1780489556; bh=z cKrkJLkz6Cm0RaPOKKGI7bHFc7FSem4y5A10o5G8Qw=; b=Cc4fpVTcEMOXfcMOD t9wvpFj6hUMPwDZU6gQb3V2RDj9hANoEzT9BSs+h6VLlMcDESmhVyEvmU2YHzjeU F4jy+lr+k08yhmU2qA+2WR6iJIW3+lKsme0zcXjPOhyw51xY5zuBwCf1qoUKuYid wLNMop6UrDOhz1Oa6U3XkpnxMZkd1K+Fi+7uzN9myWQTw6aQethvAnch+WWOQJzd i/BOwnIPmMDuOJ9pW9M3Sr0V0xcM/BCE2ZPlVC8vOxv9uC14Vh/fH7RoijbO2izM ZBl3qGvyRSCCm+ASGhxXc0mJeKpnKe264M9m5doeInVBQ1GaOdxZsij7akk3b5RS y8cJw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEXZ1kPtunSzmK8EAbCCWKUEpALF03KuzY7jjubfZq0xSsk4fi/olVVlWSHDuLezA tOEIrLmyh7/ILI6Kw8/stq9zvR+srC87cuQSNM7SccH/XdGxdSrs8I7yCUV0PpYntEbq19 6SaR48AGrNCiUQ5/N2kU+bIcHbeem2wbsn5KWZwY9F0m50i00xRCNGENVwDFaqsVaqiYbu brHg+jSh+gpSEJYHbx4rzYawm1vTDK4tJzxzTM9JcU5wcZHzZmzsXJhAk+kgC6JqhUAznC tY6G5X7WOOdycwyjkg2h4Bo4o4pmS+Hk9zjbGDYvizdQxw+ATQZAAEPFh4RguKLMTJb4gd E6kcDEByw+Chk6Y3xO59js8E7Ptn1PBoECdBfKpr4guI+16068uvomW8AdYrTrKn9VIp3R aPz1o3gVe8RQMJO9BlwlmbgotJZ0S8dFOxt5qH0SeL/nqB3AJj0H7d1mWYQDZhcQOdxXZn 6xJ9NDClYARk59trKyBY/bAz963q3D1mmJekbi2KXmKjAq6dnFmQ7I3aih2a/Bzq1kpTAI gSA1KyDzywABTKZNUczkGXjsBfUFpe2TxhTTiT6QcJxjeHJ+U9i5gTl7OddWtIESdeWlZk wbYGwoPD2Mehqa+pSEA39NCDBuZcrpSIvRaNmDcdWIo3O9f6cAoq9mxY4r3Q X-ME-Proxy: Feedback-ID: ie3de48e3:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 2 Jun 2026 08:25:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kurilemu.de; s=schmee; t=1780403151; bh=hqB9DEDOTMuxksGfB5bviH6Fcpd3LQVq5heQnVmslYs=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=idn3+JxKu7/N6UYoctGNZTpkmXaNE+Tpi/OytYRl9L84cL0JCUWD+sqvA7urEU+TV mBmfzX+azmlb8VfYqmEM8+k8Jb4sztFX89ESJO5ZK5584gk4zJcclfbrRNI4ngcQ0w Ky16mEYQQbHprOxvcaa1wejBIzpYvu8Y6KHWnQHNKiuC9SW+WerPyPqa/w4t36UQWi fKUQgSDfBk9IV3oXMRNH1kYLzuz9mJcAS5gME08LjLTwvIHentbEmGl8MtkBmT7i5p R0pJaGxWjbw6IgjrYMyLb8j+wEYBJIA53l0OkBXOtMYuT3rIftj+74c5bwq1iXWr/C dlfLsVi4u9wgg== Received: by ida.kurilemu.internal (Postfix, from userid 1000) id E03D6B00642; Tue, 02 Jun 2026 14:25:51 +0200 (CEST) Date: Tue, 2 Jun 2026 14:25:51 +0200 From: =?utf-8?Q?=C3=81lvaro?= Herrera To: =?utf-8?B?0J3QuNC60LjRgtCwINCa0LDQu9C40L3QuNC9?= Cc: pgsql-bugs@lists.postgresql.org, Antonin Houska Subject: Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98783F14-E583-4CFB-9AE0-7B3945449724@postgrespro.ru> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Nikita, On 2026-Jun-02, Никита Калинин wrote: > > On 2 Jun 2026, at 00:12, Álvaro Herrera wrote: > But does the error message need to be that detailed? Perhaps something like > > "ERROR: wrong magic number in "pgrepack" decoder plugin" > would be sufficient. Maybe. Getting 0x00000000 would be quite different from 0x7f7f7f7f for instance, or a completely random number, so I don't want to judge ahead of time. > Nevertheless, I tested the patch and can confirm that there are no > assertion failures anymore. > > I also ran it under ASAN and did not observe any issues. Thanks for testing it. > Would it make sense to add a test for this case from the bug report? Sure, I would do that. -- Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/ "Saca el libro que tu religión considere como el indicado para encontrar la oración que traiga paz a tu alma. Luego rebootea el computador y ve si funciona" (Carlos Duclós)