Feedback-ID: i0fe9450f:Fastmail
Date: Wed, 27 May 2026 09:30:11 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
	Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
	Radim Marek <radim@boringsql.com>, Marko Tiikkaja <marko@joh.to>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19490: Streaming standby on 16.14 stops applying WAL on
 MultiXactOffsetSLRU when primary is 16.8
Message-ID: <ahY7E7mjjyHkm17J@paquier.xyz>
References: 
 <CAJgoLkJfFgL-V+pYB7=R81AbURTE6sMhzVHDQDhVGnfXRSJ9Wg@mail.gmail.com>
 <CAJgoLkKCu0wCwPQZSo5no=XATU-4LMK4QfKBwV928o2uKcxe=g@mail.gmail.com>
 <CAJTYsWU6tdEvVh4YKLxz7+amZ7+Wb7_s-FBjsMMeLNj1fKeSNg@mail.gmail.com>
 <ahVTk8HKRPcz4iZ-@paquier.xyz>
 <CAJTYsWWXvbBJe+WYJZcnoSTyVz9vk5ro3x2qAq_uvXvK2KwaMQ@mail.gmail.com>
 <AC1516B2-2E78-4C70-8A6E-2966F01A1058@yandex-team.ru>
 <ahVnc8-EjV6WlM5-@paquier.xyz>
 <9DF05C0C-D165-4821-80C2-FFAF47C07FF4@yandex-team.ru>
 <d52502b3-48cf-4eb4-a966-a0a46a4637de@iki.fi>
 <90F2A05B-FEEB-4695-87ED-32F53C6AC097@yandex-team.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="MAoqJLCIwv/CPtmg"
Content-Disposition: inline
In-Reply-To: <90F2A05B-FEEB-4695-87ED-32F53C6AC097@yandex-team.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/ahY7E7mjjyHkm17J%40paquier.xyz>
Precedence: bulk


--MAoqJLCIwv/CPtmg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, May 26, 2026 at 11:29:58PM +0500, Andrey Borodin wrote:
> On 26 May 2026, at 17:28, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
>> looks correct

Neither do I see an issue in doing the first steps of
RecordNewMultiXact() without holding the lock.  The consistency that
we get across all the stable branches after this patch makes the whole
logic neater.

> I observe:
> Without the change startup deadlocks.
> With the change standby catches up, the DEBUG1 message "next offsets page is not
> initialized, initializing it now" confirms the compat block fires correctly.

Cool, thanks for the patch and double-checking things, Andrey!  I did
not check the fix beyond a check-world (aka no cross-version replay
done here), but looking closely through the code I don't immediately
see why this would be wrong across the v14~v16 range.
--
Michael

--MAoqJLCIwv/CPtmg
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmoWOxMACgkQnvQgOdby
QH0b1A/7Br7VxLD5VZ57VBsrXhLqlenHYJpHeXmy4ajlKQ7H2IKQfxCmewFjDWAC
7yZ0TxQ8+/bX0wM4/DubiqQ2Q6Na0qoR4ZEdnTUNlJQ09nGKxgYbaoTEbOCay/WG
95fDrLayoUh2K1mJkp03wiVKXA8fOrjZTeaSbs+jv0VqZCylY8hghRSlfOJSATGr
IdfFdBxaEtW7j4T7/bRoXyNYcWhT/iCuiU7d+j5E/QruYrvJTRs6EWdjs4+ParN7
jxAE+oSOd098ZCRrTGGEDRBWxOAOZiiV799ib8sA9VmPdVlrkjQo3PKZThQt9GqP
Kxlf8r+CcPbjZfGVXeNJbfmv985LjvUDFTjYBT5kUTcmRB9Q7dJ2cMXyj7zsljNZ
NxPzBMI+tR/tG/5550RLBKMfLph0iydFrHupqHHe8rulf+H/AwtzsS7VzJF0XlMk
vJDU64bi+zpTtybL/ntrF0dQfOHWrR9L+Ryd3mFVImHn5LbShp9+2+2IT9b01lN/
Zkuzq9wE3d9hnTSM2HXBfHA3KrHNet1dv2t2Onxf6Ib6iZBuk1pM9HE2I+MnYcPY
PcGO90QGmcBZcSG6WMh9h/09IkugQuDn11RZKEX3ksUtEdiHccGAgpsCEJeScxKt
A3KWlLf9+TvGOsek/yUKzbpgQhTGuT8vfU9BpeNJDalcIb8Vpfw=
=y/mZ
-----END PGP SIGNATURE-----

--MAoqJLCIwv/CPtmg--