Feedback-ID: ie3de48e3:Fastmail
Date: Mon, 8 Jun 2026 21:50:16 +0200
From: Alvaro Herrera <alvherre@kurilemu.de>
To: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: Antonin Houska <ah@cybertec.at>,
	Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
 "n.kalinin@postgrespro.ru" <n.kalinin@postgrespro.ru>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19500: pgrepack logical decoding plugin can crash assert
 builds via SQL decoding API
Message-ID: <aicUE9JzOQCp1lLE@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="qnq35le53r53khhg"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <TY4PR01MB17718C5A3450599FB1C6DFA5A94112@TY4PR01MB17718.jpnprd01.prod.outlook.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aicUE9JzOQCp1lLE%40alvherre.pgsql>
Precedence: bulk


--qnq35le53r53khhg
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On 2026-Jun-05, Zhijie Hou (Fujitsu) wrote:

> I have no objection to the proposed approach. But I would like to confirm
> whether reporting an ERROR in the startup callback (when the context is not a
> REPACK decoding worker) is considered acceptable.
> 
> Like:
> 
> repack_startup(LogicalDecodingContext *ctx, OutputPluginOptions *opt,
> 			   bool is_init)
> ...
> 	if (!AmRepackWorker())
> 		ereport(ERROR,
> 				errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
> 				errmsg("this plugin can only be used by REPACK (CONCURRENTLY)"));

Hmm, yeah, that works for me, we can ditch the magic number then.  I'm
considering something like the attached.  I added the test case and
edited nearby comments.  Will stare some more at it tomorrow ...

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/

--qnq35le53r53khhg
Content-Type: text/x-diff; charset=utf-8
Content-Disposition: attachment;
	filename=v2-0001-Disallow-direct-use-of-the-pgrepack-plugin.patch