Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 26 Jun 2026 17:16:23 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: vilensipkdm@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: Set huge_page_size on 32bit system
Message-ID: <aj41V5ACiv9OfkIF@paquier.xyz>
References: 
 <CAMp4U1d177Jf9ZJwXGKom6APx3LSFATa=Z-M=N5kLzvTUcxutw@mail.gmail.com>
 <20260626.132415.904994526137946499.horikyota.ntt@gmail.com>
 <aj4Nh0a9WiZXAjA5@paquier.xyz>
 <20260626.171307.1289242154888665760.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GnoZCR8fRdtYtG6U"
Content-Disposition: inline
In-Reply-To: <20260626.171307.1289242154888665760.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aj41V5ACiv9OfkIF%40paquier.xyz>
Precedence: bulk


--GnoZCR8fRdtYtG6U
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jun 26, 2026 at 05:13:07PM +0900, Kyotaro Horiguchi wrote:
> At Fri, 26 Jun 2026 14:26:31 +0900, Michael Paquier <michael@paquier.xyz>=
 wrote in=20
>> So it seems to me that the mistake is that huge_page_size uses INT_MAX
>> as upper bound.  We should use MAX_KILOBYTES instead; this definition
>> exists to exactly prevent this kind of computation mistake in 32b
>> environments.
>=20
> Ah, you're right. MAX_KILOBYTES exists for exactly this purpose.

Changing the states of the GUC tables in the stable branches would be
OK in this case.  Now, it took so many years for somebody to complain
that setting huge pages at 1TB on a 32b build does not work that I
cannot really get excited about a backpatch.  So I would just do the
switch on HEAD, and call it a day.
--
Michael

--GnoZCR8fRdtYtG6U
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmo+NVcACgkQnvQgOdby
QH3mwA//bA9HC1mq/r7qHUwEa/bYp9CV/w9ep082n7NoWwk0R+S/dn7PyZYbhE4R
kafuUI5NxppM//aKV5fsAUuQTkS8CfN74iN+VGB8hK/jGSDaDxeBJHLUQk99+3D1
EDXCCtKE5p8dbs/G9BxjqnAKL9F+SCzbMFb7tKMa3bdGkF12bIBBRnqxPhRUBrah
lyZeVCVPHos3t3VyCGiPaUPk+Jbrmf8fhVzpvAAJG8rjeMH5nkTNaXeqyhndqCh7
2T189f7eWTuIMqxA3pE/HWhN6tPMYuAKrhkQe/4gIchgUGwL3861+l+pPh4qv+OC
F8sQdBAxBAqqDAwm9tgwqUIsZkLUd/t++tqJnOSlgBxdmDER3/2cg8Jf2ZyKqkiu
BA81Ftw8s2Ww88yqzdY2BDhGyp/a8oQlRBMz7HX4eEWJXfCQC7o6yn+8YepNjLS1
ftr1pZyzkJWCx498p+eIBgsDpUoJC4JZAXBc4tr7AA2/Gx5oT6Xsdlh2srrFGgQA
V4ZEg4wDjEFGY6775/gg9rshXQsUcuD7p9Y7p7m6edOWp6uw/gXsGPUBFoDfDfTE
xHgiGwhS2ieEJ6Jgg9DTLDpghB42VQvHYJlQASjHgVRG8Hd7ibr7n0Gg1o39TSVa
O4UjGyrx9HzyS5s4ZwX0ZXeePz3G/jqUkj132mnN2AHK/ECXqrU=
=EigG
-----END PGP SIGNATURE-----

--GnoZCR8fRdtYtG6U--