Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 26 Jun 2026 14:26:31 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: vilensipkdm@gmail.com, pgsql-bugs@lists.postgresql.org
Subject: Re: Set huge_page_size on 32bit system
Message-ID: <aj4Nh0a9WiZXAjA5@paquier.xyz>
References: 
 <CAMp4U1d177Jf9ZJwXGKom6APx3LSFATa=Z-M=N5kLzvTUcxutw@mail.gmail.com>
 <20260626.132415.904994526137946499.horikyota.ntt@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="dvO+DWcYnEl2ujit"
Content-Disposition: inline
In-Reply-To: <20260626.132415.904994526137946499.horikyota.ntt@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aj4Nh0a9WiZXAjA5%40paquier.xyz>
Precedence: bulk


--dvO+DWcYnEl2ujit
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Jun 26, 2026 at 01:24:15PM +0900, Kyotaro Horiguchi wrote:
> We could also make the later calculation use a wider integer type, but
> such a value would not be usable anyway on a platform where it does
> not fit in Size.  So it seems better to reject it earlier in
> check_huge_page_size(), before reaching CreateAnonymousSegment().

The top of guc.h includes the following thing:
/*
 * Maximum for integer GUC variables that are measured in kilobytes of memory.
 * This value is chosen to ensure that the corresponding number of bytes fits
 * into a variable of type size_t or ssize_t.  Be sure to compute the number
 * of bytes like "guc_var * (Size) 1024" to avoid int-width overflow.
 */
#if SIZEOF_SIZE_T > 4
#define MAX_KILOBYTES	INT_MAX
#else
#define MAX_KILOBYTES	(INT_MAX / 1024)
#endif

So it seems to me that the mistake is that huge_page_size uses INT_MAX
as upper bound.  We should use MAX_KILOBYTES instead; this definition
exists to exactly prevent this kind of computation mistake in 32b
environments.
--
Michael

--dvO+DWcYnEl2ujit
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmo+DYcACgkQnvQgOdby
QH1GrA//SsV2wj8KtWFcSNkK5SKuQU5eTAiqWsi+W2u28QDfZ+8zkz4ZZc4ipXn6
BOLlt4ZY9U0vi3Aw5jyhMOaNbCOFWz1wBj51gbIZVEoUBLGCmleCZmTjNNilbGPW
woXr/G/YZ7uKXO4uqmpw/irtABIjak3BssUwjF+WyVDn7QNEFcIltOwMGF5VhJT4
StfpZSMAi7ShZfVFBMZlxR69S1ZdWmMfnHdw7yf+nzOJLxfCkrEZaRbdpOSUmIJ0
yMSGns3taozxOj3lcQ8dnYOzvhBRpQdrAaFWAH219sjvj7jR5E4IjBg7vtWtp4pk
Z5E5ckj5GpWOxO5rXtsNEfqChpL4lxiA+72m2ZFL9ItidrX5UjMPXNGK4ntCGvLo
ExnefDKEklzDXGR7KcvNTjMJc64cnp1myZRXQNkiK3tWEe+ozROBZ5m+bPPkp5m0
oTU8rfSqkpVuB2SdOPg9OPXwwNdqen3T+bYEkRW6iIhIIxSVaHp6jR4fklr3PJjC
7MFUj9Cx/6o27JqimU0pdDhRPFxjmJ+KhF5/8KsIAAtdSC/myNr/QxoVqDlZl1/7
DDfBKynhkm6tLCJRrAR2PWkt6wlRD41Y8OUvDWUlrdEi03LUC4Mi5H3UJOxyeWmV
3csKCK2rDJFF+o4I/LTz7LYajbyRoOhXdguwuTUHJ/6GuWHpn6k=
=GnSD
-----END PGP SIGNATURE-----

--dvO+DWcYnEl2ujit--