Feedback-ID: i0fe9450f:Fastmail
Date: Sun, 21 Jun 2026 07:51:25 +0900
From: Michael Paquier <michael@paquier.xyz>
To: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
	Sami Imseih <samimseih@gmail.com>, zlh21343@163.com,
	pgsql-bugs@lists.postgresql.org, Andres Freund <andres@anarazel.de>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: BUG #19520: PANIC when concurrently manipulating stored
 procedures with pg_stat_statements and track_functions =
Message-ID: <ajcZbT3S7yuDDMl4@paquier.xyz>
References: <ajaEdjQ8A7o-UqMU@paquier.xyz>
 <ajbGDFqkoL0eNHyd@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="2choOSa2ofoPKvJw"
Content-Disposition: inline
In-Reply-To: <ajbGDFqkoL0eNHyd@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/ajcZbT3S7yuDDMl4%40paquier.xyz>
Precedence: bulk


--2choOSa2ofoPKvJw
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jun 20, 2026 at 06:58:27PM +0200, Alvaro Herrera wrote:
> Yeah, this sounds more or less reasonable.  The callers that pass
> missing_ok=3Dfalse could still use the original function name though, no?
>=20
> (Personally I would do for an ABI compatibility in back branches with
> this new function, and an API breakage in master by simply adding the
> new argument everywhere, but keeping the old function name.  This way we
> don't preserve unnecessary API ugliness forever.)

Yes, that would be the idea:
- On HEAD, keep the old function name, add the parameter.
- On the back-branches, use the new function name with the new
parameter.  And contrary to you limit the use of the old function
name.

Using the old function name in the back-branches where missing_ok is
false would also work, of course.  My suggestion just makes one less
call showing up on the stack.  The previous patch posted is not for
HEAD, only for v15~v18.
--
Michael

--2choOSa2ofoPKvJw
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmo3GW0ACgkQnvQgOdby
QH0s6A/+Pr/yIx4Pe/n7132eI0V2Qm5uDo/vpCzCWPsHOOQPfwAE9ZoQJ2mq/Urz
fflwwUUzU3f3gb7QL65+eU+i5cPvn55GwNteoQMb9aUTvs4B1yhUfSCdWaow/9zh
2jszxpNTcQc9YQWPexfItCQJ6jrlN9f/VklbGZ5M5GzBr7D+D5h6iO7kUlCvFRJP
NnnbU1E5CZxoE0X+I232e71Sp0m+5Uz9hUcgikWrMw5H2zEFlM7+NBv3EsPObQgb
rslGwKo7+iJiopjOuUOwnespyqTy2rIsdnfD8+r6KP6ucsZ5Xxug6b1buPlnp56y
6kmTFQKybQTR3C8+Si4uy9MUDpR7Ug8FuD+yoxC+0Qt3RUfpvMLOqkD02BVmo4ge
LK0k+gb9rBtOkp61pLxWECzj58MQ+FylJgluXtzw/cX/dY0lcy2g5syLlgBsbcTU
hLpCHUnpx7Lo+P2vjHwPE6bsTv3Vl7aRSGqMSUC19QWmGtxj0d0ss7CVwcLB9Bd0
UGyORx1JvCpB7SxfcfxuV2/IvpY6F++d+UCcE6afZr+vYAM6r8d2u4JrCrxYs4oz
0s5u3Sim3LZBiPXTY1FM+ir7m0kHPrV50IRWgIGxqIyd6w9Yzg6Ro3cq9xiLATpG
yfnMykD70SRWd30tTu18CltJm4tNMgXT7tyUNoyBC7GAq10bAYc=
=+N/V
-----END PGP SIGNATURE-----

--2choOSa2ofoPKvJw--