Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 22 Jun 2026 16:50:34 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: igi@sraoss.co.jp, pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19529: Documentation appears inconsistent with pg_dump
 --statistics behavior for CREATE STATISTICS objects
Message-ID: <ajjpSqKEpXKA7Ww9@paquier.xyz>
References: <19529-c7eb1e7a0b07eae6@postgresql.org>
 <CAHGQGwG2ZrigPrGrtbYC8RQeiutwh8u50H_OjhNGA_b7+AA3wg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="HBa9UT1q4XP980Fa"
Content-Disposition: inline
In-Reply-To: 
 <CAHGQGwG2ZrigPrGrtbYC8RQeiutwh8u50H_OjhNGA_b7+AA3wg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ajjpSqKEpXKA7Ww9%40paquier.xyz>
Precedence: bulk


--HBa9UT1q4XP980Fa
Content-Type: multipart/mixed; boundary="LXPelvPcmWTJBfni"
Content-Disposition: inline


--LXPelvPcmWTJBfni
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Jun 21, 2026 at 12:55:34AM +0900, Fujii Masao wrote:
> This looks like a documentation oversight in (maybe) the commit that
> added extended statistics support to pg_dump.

This is a doc oversight.  While working on the support of extstats
for this release, I have looked at holes like this one in the docs,
and did not consider the pattern of a linkend based on
sql-createstatistics.

The report mentions pg_dump, but we have the same wrong pattern in the
doc pages for pg_dumpall and pg_upgrade, leading me to the attached
for these three holes.

Thoughts?
--
Michael

--LXPelvPcmWTJBfni
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename=extstats-restore-docs.patch
Content-Transfer-Encoding: quoted-printable

diff --git a/doc/src/sgml/ref/pg_dump.sgml b/doc/src/sgml/ref/pg_dump.sgml
index ae1bc14d2f26..0e0d53926af6 100644
--- a/doc/src/sgml/ref/pg_dump.sgml
+++ b/doc/src/sgml/ref/pg_dump.sgml
@@ -1703,7 +1703,6 @@ CREATE DATABASE foo WITH TEMPLATE template0;
    When <option>--statistics</option> is specified,
    <command>pg_dump</command> will include most optimizer statistics in the
    resulting dump file.  This does not include all statistics, such as
-   those created explicitly with <xref linkend=3D"sql-createstatistics"/>,
    custom statistics added by an extension, or statistics collected by the
    cumulative statistics system. Therefore, it may still be useful to
    run <command>ANALYZE</command> after restoring from a dump file to ensu=
re
diff --git a/doc/src/sgml/ref/pg_dumpall.sgml b/doc/src/sgml/ref/pg_dumpall=
=2Esgml
index 8834b7ec141e..238c87c13f5f 100644
--- a/doc/src/sgml/ref/pg_dumpall.sgml
+++ b/doc/src/sgml/ref/pg_dumpall.sgml
@@ -893,7 +893,6 @@ exclude database <replaceable class=3D"parameter">PATTE=
RN</replaceable>
    When <option>--statistics</option> is specified,
    <command>pg_dumpall</command> will include most optimizer statistics in=
 the
    resulting dump file. This does not include all statistics, such as
-   those created explicitly with <xref linkend=3D"sql-createstatistics"/>,
    custom statistics added by an extension, or statistics collected by the
    cumulative statistics system.  Therefore, it may still be useful to
    run <command>ANALYZE</command> on each database after restoring from a =
dump
diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.s=
gml
index 38ca09b423c3..cc44983a9a8d 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -834,8 +834,7 @@ psql --username=3Dpostgres --file=3Dscript.sql postgres
      Unless the <option>--no-statistics</option> option is specified,
      <command>pg_upgrade</command> will transfer most optimizer statistics
      from the old cluster to the new cluster.  This does not transfer
-     all statistics, such as those created explicitly with
-     <xref linkend=3D"sql-createstatistics"/>, custom statistics added by
+     all statistics, such as custom statistics added by
      an extension, or statistics collected by the cumulative statistics sy=
stem.
     </para>
=20

--LXPelvPcmWTJBfni--

--HBa9UT1q4XP980Fa
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmo46UoACgkQnvQgOdby
QH1avhAAkw8D0kxtJoiCsmFWhj934xX5BrnIZbHjO8y6cM54MFtbBruWW1/8+PCu
hGmZ5WakS0wEPmpjmNH25awFO+X+22HJYZnH+tG/jc+iVHb8ydet1wICDbiJiNWV
V8ZXNSm0lC6b3q8XvjECnwPCrG67JrkxUi3wXk2KktB48yCoimpzFuXUyYdJ82Vq
U1ZFYrTfGWYrC/ZKgQ24ODpljQYRJDfDl7QGaTzKCxsy3wRc4m+uhuwuK3j/zlqr
bZmzLRpi4X/0FiotE2ZxE0WTY2kevs6RfnSDeMnuL73KIYjgl8iZAkAy3Q1vrL0e
MKa+78//aIgQbjYl96bdRInhbm7Nj+VJDTzyen1o0A5s2WDsDK4KgEes4ddrYXum
Fhgnp5Xw4GTRhAoOqc5skbcIX4p7vG6+/bl50fSw+pTMfhItxhYXRMpAmqqNd7nJ
qKcKRpkbGx4QlSlLT+QqRMbCQQ5bKRcc98tFf9IgsFG1l6mjPsMcWdhIGrdPPSho
G6/qSqJWBvnRHHyi0gVhRbV30cZ1ky43tSy5ItSc+pv03gNHeGv6vCcKkEK00Rt/
R2bWIQ9Q9oF2kpr3IxihpKpwWN0eiDagoQBAsOOp2cDq/wVd6H8wUKRSufunYeX+
HBBZSG1LsDxA4+Wkcppz5ExykEoLbZWQRhNIUodNmy2MdbbBjGY=
=SMUo
-----END PGP SIGNATURE-----

--HBa9UT1q4XP980Fa--