Feedback-ID: i0fe9450f:Fastmail
Date: Mon, 22 Jun 2026 17:28:58 +0900
From: Michael Paquier <michael@paquier.xyz>
To: =?iso-8859-1?Q?=C1lvaro?= Herrera <alvherre@kurilemu.de>
Cc: Ayush Tiwari <ayushtiwari.slg01@gmail.com>,
	Sami Imseih <samimseih@gmail.com>, zlh21343@163.com,
	pgsql-bugs@lists.postgresql.org, Andres Freund <andres@anarazel.de>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: BUG #19520: PANIC when concurrently manipulating stored
 procedures with pg_stat_statements and track_functions =
Message-ID: <ajjySntrzTKTrBb3@paquier.xyz>
References: <ajaEdjQ8A7o-UqMU@paquier.xyz>
 <ajbGDFqkoL0eNHyd@alvherre.pgsql>
 <ajcZbT3S7yuDDMl4@paquier.xyz>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="/iYDm/a1PC/hXmGI"
Content-Disposition: inline
In-Reply-To: <ajcZbT3S7yuDDMl4@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/ajjySntrzTKTrBb3%40paquier.xyz>
Precedence: bulk


--/iYDm/a1PC/hXmGI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jun 21, 2026 at 07:51:25AM +0900, Michael Paquier wrote:
> Using the old function name in the back-branches where missing_ok is
> false would also work, of course.  My suggestion just makes one less
> call showing up on the stack.  The previous patch posted is not for
> HEAD, only for v15~v18.

By the way, regarding .abi-compliance-history, I am planning to remove
the latest entry after reading how ABICompCheck.pm works in the
buildfarm code.  It uses the latest commit as a base point of
comparison, and compares it with the latest commit specified in the=20
ABI file.

Removing the entry in the same commit that adjusts the pgstats routine
to be ABI-compatible should work, and there is no point in adding an
extra entry to re-document the opposite ABI change.  Any comments
perhaps?
--
Michael

--/iYDm/a1PC/hXmGI
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmo48koACgkQnvQgOdby
QH07nxAApVLOVIN6zvzZGMYJ0G366zgl1qjq27dh1gzAifMFAlO7QXdnf2BaOZug
EoeamOgFZMsPctpC56UkVv+eXJO1zPOSGOSMRUwRBctmU4GqLw9xQl1TqV1hU/s+
wVAsKeUzyQ+PyxDb7pCT9ENQGjf+hJZUb37uGloNUQ5odEGqGdjDY7dYPM8c4jQ7
vF1d0EWw669XGqJ9pvTI8b4BlL2IILyePBCCau2N1xaF1PcBY4oMUe52U2BQSZXQ
DU0+BGaXeJMCTtc9xqnMbJeLiLBqNfdaruueE+J3LOP12tL8aU1S1BYSq11oqNax
tRGxi/7z7Ts/KbylMNUyS0I/y9XvpuWTw41ZaVHWocs19PIYEMApc+k00cgXDhDq
lIJCUJkrSOP4LFswz8yXNd/ch+jz/nxsmOPZHv6UrCc8mV6zNzLoEJJb4l9VkjL0
UmmXkgmHeU1iM49jkrzRzKZnhoWnJdGOQnt6/Wahd+BR+R52dKO4+Fnmes3j/+5/
N4JB9KINK4H/qpFoTsXpyMr4wQXVund2UCLU4NJUXemb1UwTRZJ6r+AeyjRlAB1+
zk6Jw5th6aWDMlzHcRW1QDy95q4GUAeqs53ZbQie6asxrDHlIncfY/9U/MUX6Phb
b3Eljngh09ZOFZEAoL8vtB92kI7UmP/8056KfrYXGKz0I6FB3+Y=
=Ks2a
-----END PGP SIGNATURE-----

--/iYDm/a1PC/hXmGI--