Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 9 Jul 2026 07:49:55 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Imran Zaheer <imran.zhir@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
	Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Alexander Lakhin <exclusion@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
	Konstantin Knizhnik <knizhnik@garret.ru>
Subject: Re: BUG #19519: REPACK can fail due to missing chunk for toast value
Message-ID: <ak7UE1KPZnAGfhW1@paquier.xyz>
References: 
 <CAEze2WhCRX86ZY2QN7vuGc3wsAyOJbArFSc0i5KtMVnsguA7Kw@mail.gmail.com>
 <akw336Xpi9Ck9-Oz@paquier.xyz>
 <CAEze2WgBjhf6KTKuJ-UqHHGj9Z66f62grmJgZ1EazvMH9HU+XA@mail.gmail.com>
 <akxZiYmGhvNfPVvh@paquier.xyz>
 <akyM9G67ZIhPXjmQ@paquier.xyz>
 <CAFC+b6rOdx6rMi_numCrK8cM4z_HWQKrAcBY0dfrRcRWTRpsBQ@mail.gmail.com>
 <ak16dMkUP1pS0rCn@paquier.xyz>
 <ak2jc7mIhcMDkm-k@paquier.xyz>
 <bc6ec409-41ca-4889-a5c7-4e2f7a3f081c@iki.fi>
 <CA+UBfa=r2yE7swa_xX9X0y4uq0wury5_AAHr_yHvG3A+9mKzcA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="102DEOgmqU/wm0fG"
Content-Disposition: inline
In-Reply-To: 
 <CA+UBfa=r2yE7swa_xX9X0y4uq0wury5_AAHr_yHvG3A+9mKzcA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ak7UE1KPZnAGfhW1%40paquier.xyz>
Precedence: bulk


--102DEOgmqU/wm0fG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jul 08, 2026 at 08:00:28PM +0500, Imran Zaheer wrote:
> The tuplesort_getheaptuple() will contain both live and recently
> deleted tuples. However, the proposed fix passes missing_ok=true for
> all tuples coming out of the sort, which means a toast fetch failure
> for a LIVE tuple would be acceptable and will be silently skipped. Or
> am I missing something?

Argh, thanks.  Using missing_ok=true for the sort path is broken.  The
flag should be false, instead.  When dealing with the sort of the
tuples, we would already have made sure that the tuples with missing
toast chunks have been discarded, so a plain error with a missing
chunk would point to an invalid case.

I'm taking some time today to rework the patch set.  Will add this
adjustment in it.
--
Michael

--102DEOgmqU/wm0fG
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmpO1BMACgkQnvQgOdby
QH19Yw/7BsRnLcWFUr3H8mY0JbNkb9ICyA6Kh7XPQch6UHPPjVIwTjXycWt0fvca
J/R7BvabWsZ7QzDoQikm54JXDMFZaKNLaVE9CpDsfnlRIJwugkI/lJwhhDiZkPn+
6OzILMgtrA51lbDK0Dw0ItN1pMfEdH5j2943IzsRR9r3qmyXykdkPEMY+xtmNkxu
qywe+XEaRHfG+qGKCBHhRk6vvyYRa6SDoTH257RW3R5toGu0/d4HUxKn3YIxhay+
dCK7Mh1VLVE9rNEtI6LSuGCKK/LLDm4sd8mqU1aPDx/8d4tUfhNkSJ+U8vdrPDPw
1Hzy6VPbBOxwfxpeN4dMc3EpKuRQ4MHv0FJNr6ID9hxnR33AC0bw535dLpM7zzdm
0/NWpahbB+m+2BuUTD3LuKPt3vx0FudUxR+DANKdY4tNKbipCIptE9dafT0qw2D+
cvO69vHR0eucC604ZkHpGV8UiZSzjCWfKCUf8S1/GOkX3IAHonDMO1+2/w6tcOok
Nl+cqqYB1LmQQdv4jCJfbgkJghnTUjhlrXwcgBM9G51bunlWA3aFEkLJ9QW9Egfb
R0gtFk3TF0I/NOvZEVNP5/e8dzZ/3VkkMcIJCXblEQgW89DW7hEabY9/9iWM4Tr8
Tj92z7TDE95k9dQr8GH/hr4ga8g1yI/3eKcd/enEWKpHt4Xf1MM=
=qdl/
-----END PGP SIGNATURE-----

--102DEOgmqU/wm0fG--