Feedback-ID: i0fe9450f:Fastmail
Date: Thu, 9 Jul 2026 14:43:06 +0900
From: Michael Paquier <michael@paquier.xyz>
To: Konstantin Knizhnik <knizhnik@garret.ru>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
	Srinath Reddy Sadipiralla <srinath2133@gmail.com>,
	Matthias van de Meent <boekewurm+postgres@gmail.com>,
	Imran Zaheer <imran.zhir@gmail.com>,
	Alexander Lakhin <exclusion@gmail.com>,
	PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19519: REPACK can fail due to missing chunk for toast value
Message-ID: <ak806l8j5A45y2LD@paquier.xyz>
References: 
 <CAEze2WhCRX86ZY2QN7vuGc3wsAyOJbArFSc0i5KtMVnsguA7Kw@mail.gmail.com>
 <akw336Xpi9Ck9-Oz@paquier.xyz>
 <CAEze2WgBjhf6KTKuJ-UqHHGj9Z66f62grmJgZ1EazvMH9HU+XA@mail.gmail.com>
 <akxZiYmGhvNfPVvh@paquier.xyz>
 <akyM9G67ZIhPXjmQ@paquier.xyz>
 <CAFC+b6rOdx6rMi_numCrK8cM4z_HWQKrAcBY0dfrRcRWTRpsBQ@mail.gmail.com>
 <ak16dMkUP1pS0rCn@paquier.xyz>
 <ak2jc7mIhcMDkm-k@paquier.xyz>
 <bc6ec409-41ca-4889-a5c7-4e2f7a3f081c@iki.fi>
 <21477053-efd1-485a-8f72-c2e292fcf2a0@garret.ru>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="a67+Z34m1ziIjQdN"
Content-Disposition: inline
In-Reply-To: <21477053-efd1-485a-8f72-c2e292fcf2a0@garret.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/ak806l8j5A45y2LD%40paquier.xyz>
Precedence: bulk


--a67+Z34m1ziIjQdN
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 09, 2026 at 08:17:06AM +0300, Konstantin Knizhnik wrote:
> Changing `table_relation_fetch_toast_slice` signature breaks compatibility
> with some extensions, for example duckdb.
> I wonder if we can change only=A0 `bool (*relation_fetch_toast_slice)(...,
> bool missing_ok)` callback signature, but preserve signature of
> `table_relation_fetch_toast_slice`, adding one more function
> `table_relation_try_fetch_toast_slice`:

Thanks for the input.

Adding more functions implies to change the size of TableAmRoutine,
which may be bad.  For now I'd be tempted to just focus on how to fix
the problem on HEAD in a way we are happy with.  We could sort out an
optional back-branch version as a second step.
--
Michael

--a67+Z34m1ziIjQdN
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmpPNOoACgkQnvQgOdby
QH0KkBAAnfSyoTCFHELWr+xb/UND6xCWeVrKrvQd2jMQk1tG947iatHGF0SbBvF1
zeoMTaglaQTxQE9sjlGlYYHGr+m3KDSsKLVrc0PcIdCDX8v4hVadzWpuFnT7Z4Gm
7HHfzje+iOx9XI8iJF6EVrr2D6rcDCO/zr6/LlR5qM16BHRt0M0RAyN9+srniMRe
9xIzBEPrjplbNDt2P3gwFpNJygvxKM2njAgsnij56v6G2uz14NixkUlE+U7ix/w1
jHDw42k43hSbJvYpGM/b0tGptxkJj/yFhotKTzwdf1Ung+LwSxiaLZCwiYhKRWIE
d1tIXL1v6sViB927hU0/f5olCQ8TdezPfAobJFoCiT+626QpMr5Qs7Ta6uhnKJd5
2qRvLFb2pyvwmrBCVTuwDTK+dUkTNV/Uh9iaQsLBlOLx/cxc/nUaIms66cpryUom
6fqKSka886fbR7P8q996PaFazUOD3EKDch9ueoS30ki0R/rJqQXhP8Uldc+PZwpg
3iIYadtw+sOBuOiQZIm9m4EuUP5dg+p6MGp+hmod2Ava3oAfhC0nDzdf5bk4VrEz
BZ1NZmQWAZxjBQMWPlLPyoB35t49TngRFUSfwly1Lsozj8ZMmJ6ebjWyN49waMM9
cI78C5U098WHXFlZPX2rCwA0GMNEkQvIZzKN7/0WkSYFGD73A60=
=fMIQ
-----END PGP SIGNATURE-----

--a67+Z34m1ziIjQdN--