Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhSos-00063Z-Iq for pgsql-bugs@arkaria.postgresql.org; Sat, 06 Jun 2020 07:00:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jhSoK-0001kC-JI for pgsql-bugs@arkaria.postgresql.org; Sat, 06 Jun 2020 07:00:08 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhSoK-0001d5-Cl for pgsql-bugs@lists.postgresql.org; Sat, 06 Jun 2020 07:00:08 +0000 Received: from courriel-2.mines-paristech.fr ([77.158.173.19] helo=antispam-1.ensmp.fr) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jhSoD-0003J3-Eo for pgsql-bugs@lists.postgresql.org; Sat, 06 Jun 2020 07:00:07 +0000 Received: from smtp-4.mines-paristech.fr (smtp-4.ensmp.fr [77.158.173.143]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by antispam-1.ensmp.fr (antispam.mines-paristech.fr) with ESMTPS id CE82B564C2; Sat, 6 Jun 2020 08:59:59 +0200 (CEST) Received: from pseudo (159.237.219.88.rev.sfr.net [88.219.237.159]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp-4.mines-paristech.fr (Postfix) with ESMTPSA id 3CCBA2C0049; Sat, 6 Jun 2020 08:59:59 +0200 (CEST) Date: Sat, 6 Jun 2020 08:59:57 +0200 (CEST) From: Fabien COELHO X-X-Sender: fabien@pseudo To: Tom Lane cc: Andres Freund , PostgreSQL Bugs , David Rowley , "Jawarilal, Manish" Subject: Re: pgbench bug / limitation In-Reply-To: <1510961.1591380652@sss.pgh.pa.us> Message-ID: References: <384920.1591027137@sss.pgh.pa.us> <512846.1591057287@sss.pgh.pa.us> <1507639.1591375547@sss.pgh.pa.us> <1509305.1591378355@sss.pgh.pa.us> <20200605174418.zbb4egfe5wxhv2yd@alap3.anarazel.de> <1510961.1591380652@sss.pgh.pa.us> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-CLAMAV-SCAN: ok X-VRSPAM-SCORE: -100 X-VRSPAM-STATE: legit X-VRSPAM-CAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedrudeggedguddtjecutefuodetggdotefrucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffujgfkfhgfgggtsehttdertddtredvnecuhfhrohhmpefhrggsihgvnhcuvefqgffnjffquceotghovghlhhhosegtrhhirdgvnhhsmhhprdhfrheqnecuggftrfgrthhtvghrnhepveefgfeuhfegfeffueeljeefjeevgfffleevleekgfduieeftdfgudffledvjeeinecukfhppeekkedrvdduledrvdefjedrudehleenucfrrghrrghmpehmohguvgepshhmthhpohhuth X-VRSPAM-EXTCAUSE: mhhouggvpehsmhhtphhouhht List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hello Tom, > Agreed. Seems like the best answer is to get in bed with the Windows > representation of fd_set, since we cannot avoid knowing that it is > different from other platforms' versions. I suggest that we might as > well get all the way in and dodge the FD_SETSIZE limitation altogether, > as per the attached utterly-untested draft patch. ISTM that the patch your propose, a full reimplementation of the abstract poll/select fd set interface for windows, is overkill because it adds about 80 lines of code. ISTM that just redefining some macros is enough to get the same performance benefit without adding much to the code base, but maybe I'm missing something. At least, I do not think that getting rid of the FD_SETSIZE redefinition for windows is worth all that trouble. -- Fabien.