Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiYxS-0002ih-RV for pgsql-bugs@arkaria.postgresql.org; Tue, 09 Jun 2020 07:46:06 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jiYxR-0002mj-Ey for pgsql-bugs@arkaria.postgresql.org; Tue, 09 Jun 2020 07:46:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiYxR-0002mb-82 for pgsql-bugs@lists.postgresql.org; Tue, 09 Jun 2020 07:46:05 +0000 Received: from courriel-2.mines-paristech.fr ([77.158.173.19] helo=antispam-1.ensmp.fr) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jiYxO-0002zn-AX for pgsql-bugs@lists.postgresql.org; Tue, 09 Jun 2020 07:46:04 +0000 Received: from smtp-4.mines-paristech.fr (smtp-4.ensmp.fr [77.158.173.143]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by antispam-1.ensmp.fr (antispam.mines-paristech.fr) with ESMTPS id AB60155EAB; Tue, 9 Jun 2020 09:45:58 +0200 (CEST) Received: from petersbourg.cri.ensmp.fr (sfr-16.cri.mines-paristech.fr [77.158.180.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp-4.mines-paristech.fr (Postfix) with ESMTPSA id 941B52C0286; Tue, 9 Jun 2020 09:45:58 +0200 (CEST) Date: Tue, 9 Jun 2020 09:45:58 +0200 (CEST) From: Fabien COELHO X-X-Sender: fabien@pseudo Reply-To: Fabien COELHO To: Tom Lane cc: Andres Freund , PostgreSQL Bugs , David Rowley , "Jawarilal, Manish" Subject: Re: pgbench bug / limitation In-Reply-To: Message-ID: References: <384920.1591027137@sss.pgh.pa.us> <512846.1591057287@sss.pgh.pa.us> <1507639.1591375547@sss.pgh.pa.us> <1509305.1591378355@sss.pgh.pa.us> <20200605174418.zbb4egfe5wxhv2yd@alap3.anarazel.de> <1510961.1591380652@sss.pgh.pa.us> <1673150.1591455433@sss.pgh.pa.us> User-Agent: Alpine 2.22 (DEB 394 2020-01-19) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="2056645051-1852571189-1591688758=:274691" X-CLAMAV-SCAN: ok X-VRSPAM-SCORE: -100 X-VRSPAM-STATE: legit X-VRSPAM-CAUSE: gggruggvucftvghtrhhoucdtuddrgeduhedrudehfedguddviecutefuodetggdotefrucfrrhhofhhilhgvmecuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhrhfvufgjkfhffgggtgesmhdtreertdervdenucfhrhhomhephfgrsghivghnucevqffgnffjqfcuoegtohgvlhhhohestghrihdrvghnshhmphdrfhhrqeenucggtffrrghtthgvrhhnpeeljeegfffgvdeggfduffeuffdvuefgiedtjeefhfehffeiiefffeegkeeigfekheenucfkphepjeejrdduheekrddukedtrddvgedtnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhht X-VRSPAM-EXTCAUSE: mhhouggvpehsmhhtphhouhht List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --2056645051-1852571189-1591688758=:274691 Content-Type: text/plain; charset=US-ASCII; format=flowed > I cannot foresee a setting where over 60 clients per thread (ISTM there is at > most one wait per client) would make much sense, so let's not help the user > run ineffective benchmarks. Maybe we should even issue a warning when > #client/#thread is high. Even if there is a bench where a thread could really > handle 1000 clients (implying 1000 pg processes server side), probably the > user could suffer to run that bench with 16 threads. Here is an attempt at given advice in the doc & a warning when launching. -- Fabien. --2056645051-1852571189-1591688758=:274691 Content-Type: text/x-diff; name=pgbench-doc-threads-1.patch Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename=pgbench-doc-threads-1.patch ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9yZWYvcGdiZW5jaC5zZ21sIGIv ZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNoLnNnbWwNCmluZGV4IDhlNzI4ZGMw OTQuLmU5ZTdiNmI1YTcgMTAwNjQ0DQotLS0gYS9kb2Mvc3JjL3NnbWwvcmVm L3BnYmVuY2guc2dtbA0KKysrIGIvZG9jL3NyYy9zZ21sL3JlZi9wZ2JlbmNo LnNnbWwNCkBAIC0yMzA5LDkgKzIzMDksMTIgQEAgc3RhdGVtZW50IGxhdGVu Y2llcyBpbiBtaWxsaXNlY29uZHM6DQogICA8cGFyYT4NCiAgICBBIGxpbWl0 YXRpb24gb2YgPGFwcGxpY2F0aW9uPnBnYmVuY2g8L2FwcGxpY2F0aW9uPiBp cyB0aGF0IGl0IGNhbiBpdHNlbGYgYmVjb21lDQogICAgdGhlIGJvdHRsZW5l Y2sgd2hlbiB0cnlpbmcgdG8gdGVzdCBhIGxhcmdlIG51bWJlciBvZiBjbGll bnQgc2Vzc2lvbnMuDQotICAgVGhpcyBjYW4gYmUgYWxsZXZpYXRlZCBieSBy dW5uaW5nIDxhcHBsaWNhdGlvbj5wZ2JlbmNoPC9hcHBsaWNhdGlvbj4gb24g YSBkaWZmZXJlbnQNCi0gICBtYWNoaW5lIGZyb20gdGhlIGRhdGFiYXNlIHNl cnZlciwgYWx0aG91Z2ggbG93IG5ldHdvcmsgbGF0ZW5jeSB3aWxsIGJlDQot ICAgZXNzZW50aWFsLiAgSXQgbWlnaHQgZXZlbiBiZSB1c2VmdWwgdG8gcnVu IHNldmVyYWwgPGFwcGxpY2F0aW9uPnBnYmVuY2g8L2FwcGxpY2F0aW9uPg0K KyAgIEZpcnN0LCA8YXBwbGljYXRpb24+cGdiZW5jaDwvYXBwbGljYXRpb24+ IHNob3VsZCBiZSBnaXZlbiBlbm91Z2ggdGhyZWFkcyB0bw0KKyAgIHByb2Nl c3MgaXRzIGNsaWVudHMsIGRlcGVuZGluZyBvbiB0aGUgY2xpZW50LXNpZGUg bG9hZCBpbmR1Y2VkIGJ5IGJlbmNobWFya2luZyBzY3JpcHRzLg0KKyAgIEEg dHlwaWNhbCBzZXR0aW5nIHdvdWxkIGJlIHRoYXQgYSB0aHJlYWQgbWFuYWdl cyBhIGZldyBjbGllbnRzLCBzYXkgYmV0d2VlbiAyIGFuZCAxMC4NCisgICBT ZWNvbmQsIGl0IG1pZ2h0IGJlIGFkdmlzYWJsZSB0byBydW4gPGFwcGxpY2F0 aW9uPnBnYmVuY2g8L2FwcGxpY2F0aW9uPiBvbiBhIGRpZmZlcmVudA0KKyAg IG1hY2hpbmUgZnJvbSB0aGUgZGF0YWJhc2Ugc2VydmVyLCBhbHRob3VnaCBs b3cgbmV0d29yayBsYXRlbmN5IHdpbGwgYmUgZXNzZW50aWFsLg0KKyAgIEl0 IG1pZ2h0IGV2ZW4gYmUgdXNlZnVsIHRvIHJ1biBzZXZlcmFsIDxhcHBsaWNh dGlvbj5wZ2JlbmNoPC9hcHBsaWNhdGlvbj4NCiAgICBpbnN0YW5jZXMgY29u Y3VycmVudGx5LCBvbiBzZXZlcmFsIGNsaWVudCBtYWNoaW5lcywgYWdhaW5z dCB0aGUgc2FtZQ0KICAgIGRhdGFiYXNlIHNlcnZlci4NCiAgIDwvcGFyYT4N CmRpZmYgLS1naXQgYS9zcmMvYmluL3BnYmVuY2gvcGdiZW5jaC5jIGIvc3Jj L2Jpbi9wZ2JlbmNoL3BnYmVuY2guYw0KaW5kZXggMDhhNTk0N2E5ZS4uM2Q2 MDgwZmM4MyAxMDA2NDQNCi0tLSBhL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNo LmMNCisrKyBiL3NyYy9iaW4vcGdiZW5jaC9wZ2JlbmNoLmMNCkBAIC01ODQx LDYgKzU4NDEsMTUgQEAgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpDQog CWlmIChudGhyZWFkcyA+IG5jbGllbnRzKQ0KIAkJbnRocmVhZHMgPSBuY2xp ZW50czsNCiANCisJLyoNCisJICogVGhlIGJlc3QgI2NsaWVudC8jdGhyZWFk IHJhdGlvIGRlcGVuZHMgb24gdGhlIGluZHVjZWQgY2xpZW50LXNpZGUgbG9h ZCwgd2hpY2gNCisJICogZGVwZW5kcyBvbiAtLXJhdGUsIG9uIHRoZSBleGVj dXRlZCBzY3JpcHRzLCBvbiB0aGUgc2VydmVyIGNhcGFiaWxpdGllcy4uLg0K KwkgKg0KKwkgKiBKdXN0IHdhcm4gaWYgdGhlIHJhdGlvIGxvb2tzIGhpZ2gu DQorCSAqLw0KKwlpZiAobmNsaWVudHMgPiAxNiAqIG50aHJlYWRzKQ0KKwkJ cGdfbG9nX3dhcm5pbmcoIm92ZXIgMTYgY2xpZW50cyBwZXIgdGhyZWFkLCBj b25zaWRlciB1c2luZyBtb3JlIHRocmVhZHMiKTsNCisNCiAJLyoNCiAJICog Q29udmVydCB0aHJvdHRsZV9kZWxheSB0byBhIHBlci10aHJlYWQgZGVsYXkg dGltZS4gIE5vdGUgdGhhdCB0aGlzDQogCSAqIG1pZ2h0IGJlIGEgZnJhY3Rp b25hbCBudW1iZXIgb2YgdXNlYywgYnV0IHRoYXQncyBPSywgc2luY2UgaXQn cyBqdXN0DQo= --2056645051-1852571189-1591688758=:274691--