DKIM2-Signature: i=1; m=1; t=1790915545; d=paquier.xyz;
	mf=PG1pY2hhZWxAcGFxdWllci54eXo+;
	rt=PHBnc3FsLWJ1Z3NAbGlzdHMucG9zdGdyZXNxbC5vcmc+;
	s=fm1:rsa-sha256:d39psnEMeeAIoKG9yIDZBIniYT57XLoH7jOhtSLQKyfYfIW
	NsHmg+a/spNtvNm2X4NYUMbTunPvZFjI3fiELDFRzbY+aK4rCZh/cJsQ6cp0A8/i
	VrFnpx6b5x/7iS0lBXwLJviKlKj1+AoV7A5WLCxguuUQHOhCRgqpRLIAvXk4W2Rf
	9FbS5iRA3yZoksB8YSdYiUQQtEWQaDkFvXzV3ZcDlRqwlET0DiXACxKrxrGlLAr/
	ANFcDS1APBTLq7Nv3ZnpfQc7PP1fsO64uzTs7A+JRLzNkA1KPIeaAyD5DNGsWLkC
	Yq9Pxv1sFrtvH+gkDqDY7qMkBhIQYi3kEx053cA==;
Message-Instance: m=1;
 h=sha256:HRwrRqBSQkAhx9xibGcfem7L1KIhzrlgx4S3K0qUtFA=:LmrW38RhFtrLPgiqiCf4dqdTJGrr7/DD3LRcEgoBCxQ=;
Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 2 Oct 2026 13:32:20 +0900
From: Michael Paquier <michael@paquier.xyz>
To: shihao zhong <zhong950419@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
	"theshallow27@gmail.com" <theshallow27@gmail.com>,
	"pgsql-bugs@lists.postgresql.org" <pgsql-bugs@lists.postgresql.org>
Subject: Re: BUG #19730: PostgreSQL `pg_backup_start` accepts newlines in the
 backup label, producing an unrestorable `backup
Message-ID: <ar8z1ClV9rWfAxVo@paquier.xyz>
References: <19730-85a6044c9e72774a@postgresql.org>
 <CAGRkXqTGP7BRT5Xv+xJoSc3egpPtC0h-LH-w4GxzQSt5qg7iLg@mail.gmail.com>
 <CAKFQuwbjp=jg5_K3W3pP8cuO68B5R=NOuRRo6ZCvTMyZMyW8rQ@mail.gmail.com>
 <ar8px1yG51ESobdm@paquier.xyz>
 <CAGRkXqS7znpXT6P-iLnTZthnMm1EtUx+N8yZ-WSkU3i38vi1fg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="GXBdl70wXimBiiyb"
Content-Disposition: inline
In-Reply-To: 
 <CAGRkXqS7znpXT6P-iLnTZthnMm1EtUx+N8yZ-WSkU3i38vi1fg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ar8z1ClV9rWfAxVo%40paquier.xyz>
Precedence: bulk

--GXBdl70wXimBiiyb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Thu, Oct 01, 2026 at 10:07:41PM -0600, shihao zhong wrote:
> Fair enough. Patch attached. It is the check from the report, with
> the error wording of b380a56a3f95, and a test next to the "backup
> label too long" one in 020_archive_status.pl.

WFM.

> One thing to note. A label that ends with a newline works today, and
> this patch rejects it. A script that reads the label from a file can
> hit that, so I think this should go to master only.

Of course, this is not something that would go into the stable
branches in any way.

Perhaps other will have some comments.  Let's see.
--
Michael

--GXBdl70wXimBiiyb
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmq/M9QACgkQnvQgOdby
QH3L3BAAnFJQRZ8FYex2M5MHrda35kyoL+rCC4SNmVO6lgePf4hwxIwOHaRiWTzu
bV/jbFYX8fPwrHdY/3FcQGDquHBCWMCWrIUeZYTmqI7//tBsaYwMnGOeEI7wn6uT
0CwZjaIpcv2tpbLkrnka8A4rgXxAEZCAo9kQ8H/QBMYV49khTk/V+g0QBD1HFwL9
mtkGSz5NEzqJ5r11DmoalxC8wF87c/bd4E695QkyobzfQNnA015ob5NZucGab9ll
t1AX3aXe/xmCtm8xUC6vGrAcONV+yafXKzWQHccJy6rpUr3Rqr79dwcD5Efpg49G
WpaUNrtlb0UkhDvfpPj9MicrLW/8SiLpmCj7EXt2YlcM703wyQY9ABV1BtX+ooes
r0KqCabOaEHlQKjVRh+Uh5I98kFzKwxKft70Vu5Lzr251DeTs0Nblj/46My/oakl
r1iFlwCoHt4n0JxQroBBaqa5pwJ3peCAXz01TZaZwnwcvAhDQWBeKqNp9wq15Fv9
Z3TDglFnu4NbtjAvulm8VyFPnsSCBMgKuwG8lIjDypNH9po70ATz1tsEN5pcNDoV
CsvU75/hGxIbGiOiGIkKs1cMrj+AGfNzvVf46835NiUND4gd/e/uqmHWtt+h8Dvk
GxofW8n+Vk4nPhiyUmGxYpcTaT3EO9df1fQsJMw6PDxeQdmvN+g=
=6u4u
-----END PGP SIGNATURE-----

--GXBdl70wXimBiiyb--