Feedback-ID: i0fe9450f:Fastmail
Date: Fri, 25 Sep 2026 07:52:07 +0900
From: Michael Paquier <michael@paquier.xyz>
To: jian he <jian.universality@gmail.com>
Cc: Corey Huinker <corey.huinker@gmail.com>, imchifan@163.com,
	pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #19715: pg_restore_attribute_stats() rejects range
 statistics for a domain over int4multirange
Message-ID: <arWpl7GpyleJ-HjT@paquier.xyz>
References: <19715-b8be35083016f289@postgresql.org>
 <CADkLM=exLKefGZjw+6HZ4TaVr0ra2+t44=64DpRs5eX4wdqfuw@mail.gmail.com>
 <arSlchrpWvs8m8M2@paquier.xyz>
 <CADkLM=ci+m6KW1r1RutSOV-OOvv9FTNrOU0+7wNq8R2+p-91Nw@mail.gmail.com>
 <CACJufxFpoeswdX3hV_vg+Tr78Q++01yk06k5Y4aPapYm_-hW3Q@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="IurGZ7S5WzgE4qwc"
Content-Disposition: inline
In-Reply-To: 
 <CACJufxFpoeswdX3hV_vg+Tr78Q++01yk06k5Y4aPapYm_-hW3Q@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/arWpl7GpyleJ-HjT%40paquier.xyz>
Precedence: bulk

--IurGZ7S5WzgE4qwc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Sep 24, 2026 at 02:44:19PM +0800, jian he wrote:
> Similar in import_pg_statistic.
> change to
> typcache =3D lookup_type_cache(typid, TYPECACHE_LT_OPR |
> TYPECACHE_EQ_OPR | TYPECACHE_DOMAIN_BASE_INFO);
>=20
> Disclaimer: Since I saw both of you actively working on this issue, I
> haven't tried this myself.

Yes, I was wondering about that a bit, feeding a single typcache entry
across the board.  And while looking at the code, I was reminded about
the following exceptions:
extended_stats_funcs.c: if (typid =3D=3D TSVECTOROID)
stat_utils.c:   if (*atttypid =3D=3D TSVECTOROID)
stat_utils.c:   if (atttypid =3D=3D TSVECTOROID)=20

I think that the existing code is also broken when defining a domain
over tsvector if we don't feed a domain base type in these three
spots.
--
Michael

--IurGZ7S5WzgE4qwc
Content-Type: application/pgp-signature; name=signature.asc

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmq1qZcACgkQnvQgOdby
QH30lA/+N00IF3zqmIdN5L2ZbnCempYV5/AkyFp8BgprtceepOHgP/LOvovd7bel
h8yWk8C8L5ToW2iKMIsshkfyRNKYjAdAFPG0C7bfj3ZIABIqCaiF4KPVLrvxvxz4
pAJaAZTEi/B0g5hfc7wCGsRCi303fVqO8debi3UktM7gGfK4bSXBeNEIYUxeW8Vr
udAXKb4/y2gOb4T5z0WB51ardWTYqIrah36W3aE9X/5AdQhG2tksj3W8S+r9Orvz
yvVB0FzHkz1EpWlKgbk99jz2jz2jqwnim5SegbE1R9LvYo/4Kp+5PwBOqYJx6Dbz
1K3TonskZyF90KJ3Z2BCJ223TEeOaTeerbc7w8AbftYldOOW/+sbxILDsmHUTr09
5F8CQmpOodZJKMqARSOZEfN9HxaP2Y22vXOCk3bY4lc7jNnQ7H1eKb/5r1b79GEm
GCcw+6QstNu6pBukJjKkbgiylPHp8cpBqaRMpEJZDCYSxxnbn+pz62cCpLHKR7ev
IYQxyg+OK74Y65Xblc2eUZfVXB/mAbmCy+b3XlfHdSqSsVb3pQqCZCnkBlR6bOqK
ZT/9WBubTTqd/wQEu8RLxqoysahLF8aL33RmFSDxPnSqb0Bgt7+kGRY1Fo6r2vmV
sPlm10HQBo4rBcZPQgyXoAKW8U+Fg2zLV9pZFF91THqm6BZvBHM=
=A7rv
-----END PGP SIGNATURE-----

--IurGZ7S5WzgE4qwc--