Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xLU7i-00000001XTn-14N9 for pgsql-bugs@arkaria.postgresql.org; Mon, 26 Oct 2026 23:29:02 +0000 Received: from localhost ([127.0.0.1]:56456 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xLU7h-00000008Q8j-2wrA for pgsql-bugs@arkaria.postgresql.org; Mon, 26 Oct 2026 23:29:01 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:60982) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xLU7h-00000008Q8a-1ryx for pgsql-bugs@lists.postgresql.org; Mon, 26 Oct 2026 23:29:01 +0000 Received: from fout-b6-smtp.messagingengine.com ([202.12.124.149]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xLU7f-0000000199I-11YW for pgsql-bugs@lists.postgresql.org; Mon, 26 Oct 2026 23:29:01 +0000 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfout.stl.internal (Postfix) with ESMTP id D8CD11D003FC for ; Mon, 26 Oct 2026 19:28:57 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Mon, 26 Oct 2026 19:28:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1793057337; x=1793143737; bh=gf7mk/tyGv 9X/iyjOm1a7K6Ev7tkITI9nvsqQt3Uxp8=; b=m4JGzW5pgXPbciu4iPJNi0QE+G Ect2f+xnIA7jzWV0+xz3ICv3d7VUyms8eig5z3roEvljon5m4AAB3M0BnuSfNkaL dwgq9bXkASWmLsztImTWqC6zWoEAHaUz1UMAYhJvUHPYmsMd8fe+i42GbMbTRDf+ 3EoEULJlgegEYJScVFsVyt8EsEpno6EGQ+MHnBxbt3eHa+duvekHpBeDPcbvqw9S jJqg2WhZiuSpUir91ZJZxgApDrt1c2i40AadzEgFl16S9od73J4Wyxy26b7BpJpP p9bSi4OG+mAREGe3sBy8EQmxKAfg+ScUNCkUjIEQdQvEfUxXQsJY+lRbq5YA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1793057337; x=1793143737; bh=gf7mk/tyGv9X/iyjOm1a7K6Ev7tkITI9nvs qQt3Uxp8=; b=cRak4k9TtxpfuBmDbmYoVmFWI5en2hKSN/GGuJqT3KjrdjuxSxK 35EuWvArsALHNHv4m4QFZQrpcCSjSDLJ6L3AUQyIjVwQ4uC5dpIfOYXA5upjXDbb HKVzWejc+EU1tBboGTL7ZhR0hY+QcBgNLDT/H8SVJOdQ8w1m2v0SFEpZTYBnUAwv Yi5YpNCfKlu80ibNDCjlwSebL5IbeIUX+4OuL78LPP86QI8fea3rZuSEMDGvuCOg ZiRw0WdnjAYbhTH7WdF6xvU6SxCzhNkdnEi/B2cWNnwra4OxneZY+v753FIpE9Fa rVnrZAPkYEboiKFq9xixAgZC1MCx9nUnrng== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=sign d=paquier.xyz a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1793057337; d=paquier.xyz; mf=PG1pY2hhZWxAcGFxdWllci54eXo+; rt=PHBnc3FsLWJ1Z3NAbGlzdHMucG9zdGdyZXNxbC5vcmc+; s=fm2:rsa-sha256:HkvtSzhQBXxGEWz51oySvQ1UwBk5K+UUjZ361tZ2E5R9KcP lsa+j3pG+Q5k5Ugyoszw7H2PiSBSO3SxvArxztsOUEBSVFj4Qno82xbUbQJIfbdm /uZfIbaw2ISPGJb9zn4mcMpnIyXg+hSFKT0iK8DqmL8MbYqUR1rXoFQ+PeyMR72f inB2d4yoPJyzuCkiobHFpKXYyxV4SCOG5g8BQZ4saDYo0j3TmIMJLWhRhV0Ln2d6 o8ZbX7uktVYZsn8ndkk+dCt+vrvBg9c/8pEjoR3bHGeDk9Rw1QwvWIQuMEK1CDXz keztql686FDsI8sBQfzIaHg/wQVKavxBhLlHV2w==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-disposition,content-type,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:B+OrwByP0hVk0MQae0tpU09OWXG677RFM9+YkLEQR3o=:iirvCgUNQ7+1L/hnn2iIVF4J4dwIflapgk5MqJK0ywU=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTGHDQg1P74V8D2QrkvAYZOlZywnJ3KFzAtl+d7MLorOJnFpb1ZM8PNXPlGd+Zk2kV SLwdp6jComvzn3A1jsHOw+ys31ffgEE0u2EJUFY1xkePdgJDn/hga+VGm7ADHVR/WTkHfR DkE1s2SQLk1JP9P7NaHM/WpcjUIaBavqHwM5W9o6Mwv/WxBJNJiZa4njV9nOl/3eBm8Hj/ 3/1L9Q5lcMFrKdwA4B/51VyTSm3yKdqGPDeSds1eaY5jAMwVWNsZDpkDrKdr5OW/xJsq8X axek6TOkTu/CpxmJ44IFN0jZhtjNZUI6Y8NRrKiw73t0ERNAOFsjS7QYk5vDcMUzAS5tjY IOp4fRWeg+64mo+YC+oIaHTt0rNmS+UMZJawYYHCtNVChBTgkezWgAghPnaMOl0Kq7YxmP qwDOlSxJnZHCe+NuYYM6On4tI8rXJgF5lbOqn/XWqwerA4tVUMBsAaWuRRLc+r4YzwjKZX DJ2rEVOZQT53/wIJ9tNNZWCN+wyPuyPXTZRIwS9r6Y7b7BmoOU/mXGtdYGhCffpx67Qzh2 M9+DRTonrcA/9xHnhQA7labNnMxldHFepLsUFUTWWd4VM8WLbVW53LOtmy01vrRysGIdcU +THTMwxq+LkSuf5cVcDL/HS/HOhYHhxzGVXCYzsolD/8KrGyMLQ6IcFP3FZw X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Oct 2026 19:28:55 -0400 (EDT) Date: Tue, 27 Oct 2026 08:28:52 +0900 From: Michael Paquier To: Sami Imseih Cc: Staroverov Ilja , "pgsql-bugs@lists.postgresql.org" Subject: Re: pg_stat_statements replaces SQL/JSON ON EMPTY / ON ERROR keywords with parameters Message-ID: References: <457969A9-5D24-422F-B09E-F388053DE028@localhost.localdomain> <83202E93-9039-410B-B4F2-A141DD7D80E1@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WNW20JTM4AwXZO/e" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --WNW20JTM4AwXZO/e Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 26, 2026 at 01:23:22PM -0500, Sami Imseih wrote: > The column names in the SRF column definition list don't make those separ= ate > entries. I think JSON_TABLE column names should follow the same rule. Exp= licit > PATH values are not included in the query ID, so I don't think omitting P= ATH > should make the column name part of the query ID. >=20 > So I think `JsonExpr.column_name` should be marked `query_jumble_ignore` > instead of using a custom query jumble function. Okay. How would this choice impact the PGSS outputs? Perhaps we should first expand the tests with PATH keywords touching multiple columns first? I was hesitant to do so while introducing the tests, and only focused on the obviously-broken case with the ON ERROR/NULL keywords handled as constants in the PGSS outputs. -- Michael --WNW20JTM4AwXZO/e Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmrf4jQACgkQnvQgOdby QH0fIBAAhEakYx0jZh/bxPL5Y8fwUaHvIsrt9aKkYIH/b2PQ0T6HfSqnElV+g10H grk1ZycqJXEO9zzpCn0bsWzbzYLyKxvAnv//fxFMc4GgyxN5PiB+66eGUJvfDNEZ O28QBcRxna5JSSp8h9zgVSb48+0R28q8udu+6rJJnAmsSKadlwvYOuoPcMLJPchT fzK/ILm3Px2DMASG0GA73ZElMf4MKhT4QKbQJeR3cVBqfKzbe7w4FeSffVdcozLM 8vHi4qR3ZNzT9aLcnWtNfZGLAUyE31ME7jlbeF7O7vJqVtkFSuzqB6wDtja1rvJ7 aRxmEMNiEniO3c3Iz/yuqj9Fa1o7DCTrQqSjTDHc72pIh1kzaOsoT5uFkXHv/7BZ 05eUiLpjHAE5FKEl2aHxAn2yv+EAAR1EutlYS/pAIBIPf+Q2bZw1IJIA7RQlT2Mc /HL2UCc9f6U7qFlL0ctqutIQWE5yjlMwJruJFYNvqpRNJh8Nx2QI6EI+LB8rR5Hx Qrt7G1Lyu9Dgz/arfNpdL+giv/LMPBOuIcqyVI8y9NjtiG4HMf4B+j2A0ji38BZU YXfYxCJ2jZ8g6FQWiycVIytp2eaP1IaHTcCa0b7Kg+5t+RSavIDKw3JJPkEheP7r h0F+yRj0pLCKOkcoR4C+WUZ/eQvhFfg8FVSmZKgE3RkpTVrajXo= =MdGE -----END PGP SIGNATURE----- --WNW20JTM4AwXZO/e--