Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJPJk-000000009S2-137o for pgsql-bugs@arkaria.postgresql.org; Wed, 21 Oct 2026 05:56:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xJPJj-00000003swD-1PV3 for pgsql-bugs@arkaria.postgresql.org; Wed, 21 Oct 2026 05:56:51 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJPJi-00000003sw4-3NQV for pgsql-bugs@lists.postgresql.org; Wed, 21 Oct 2026 05:56:51 +0000 Received: from fout-a3-smtp.messagingengine.com ([103.168.172.146]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJPJg-000000008Ic-0oka for pgsql-bugs@lists.postgresql.org; Wed, 21 Oct 2026 05:56:49 +0000 Received: from phl-compute-03.internal (phl-compute-03.internal [10.202.2.43]) by mailfout.phl.internal (Postfix) with ESMTP id 4E1A4EC01E7 for ; Wed, 21 Oct 2026 01:56:47 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-03.internal (MEProxy); Wed, 21 Oct 2026 01:56:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1792562207; x=1792648607; bh=IGmfE/Fb4C LSJWSpo1KQKBNUc5Tc4ZIkk14dEFfxxHc=; b=Cl0yVbn3BSwLES348hYY7EwJtu VkUQ9pYIVzZ1QdPRqQ2Jua+yejkTi4cjeqTZkoR0SHzO/I4e3bAOvpOO8e8sbnFn 5UepIzvrMeHKjqP9/6jODT33RvEA1EWK8Q1v2GgZz6+H5j7R8TH9iQaChv3DULiU e6BVrTSNULC/+w7TNo/XclFzGs62q4pqAyAiw1rtMlxHHF47xol5SBYrcSzcY81l 5g7ajMPXxmg3QqW8w1YhHfruq4AQxs3dHevC3/028LIW907T7Jwb/cZBUzTesXUo A8FcGO2HdmZ9P+cx/eVkNDlHx/fMKW6DDZCPmdEAASg18gauURYzMhYfX/Og== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1792562207; x=1792648607; bh=IGmfE/Fb4CLSJWSpo1KQKBNUc5Tc4ZIkk14 dEFfxxHc=; b=TUGbredAEWKdW/wIwsaLqhN9+EEeb3KcFE7kLAvFZpmOrY0vXBu Oh5j6oHPb2xzkZjIcwQD1VJmfbbAlEQgvzkFqkxEI+fNYGZ7IvtbBv5ZAVinnkCi YZsDdHOSziJfpa0NFJbMO8EktGkBHEwkFZV+/6eYFtbTim4keLWM9nGgAXzHgNKb hcexS57Om8gsgAFoX9OlKgNvnt5qUNa2w82aDq+HM/wMBLogiKbspIh0Vnw6Jnkx yn4PC4F4BaYwRBKcY8xNDfr5PQG9Nhpguo0bO2oIufcDwPy4xk2/vJnqTaLvKnO/ 55ielIR5QxGTavyKziib7PL6xZZqn8VHo3A== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=sign d=paquier.xyz a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1792562207; d=paquier.xyz; mf=PG1pY2hhZWxAcGFxdWllci54eXo+; rt=PHBnc3FsLWJ1Z3NAbGlzdHMucG9zdGdyZXNxbC5vcmc+; s=fm2:rsa-sha256:aixr7tPeh+AHBO3JXYl3yt/ZJSIn5Xw2K77UQKR0l0QrREA 3oTAS0zt4dy/xvy0n8MkXoz9kYox5n7J/bvKGUbjrn8hf8PdE9MfAwQOV/YS4X1/ HsifMoRjbM9+ZzjaMN4sxh9w3h/NJ9jCFn3A7bmylSoF7/JnKAhm+LxKvteHBvCw 8+PL5fOACdNMAtI9X/NiQI8wA6HzKOGkeli1V9wRWBOZAQ8dOwGAUZsYXIm/f03p I8M4wL339OAjtc7G3GtCNqm5Y89jndujQvmOiEx/SdLTwq5yifJmBDy07e7GumG3 IDuuzvFEt63ECk3T+LqO6w8Kp5od9Vjbc0CCbGw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-disposition,content-type,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:3PV2BRvGtZrVvwnLdJWa+iB6bLBzPj3E27IX4RjARvE=:8fiBQKit0DcxSOjX3Gx5UctHN8lVEjBxyeXlA8R0xdA=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFK9wPSb42quatiWozGnVP2x57T1l8MmkqY8Qk2HxKxKsYY3ApooHAFWTlAzZMfyU vPryGMkjTawUN3P5ZM6qxpVQPkjkU7e2CKPpZo35wqpgz3cZPumWb4UdJ6UNSVxI1I9DT4 Rr2bkDULKqeGChJPPthcU6aEGg1IReDhyGBMy6gu2ngP6SwlOTlx/yKqc95AMdvAufA2Ii gsj4otc4CAksRdDwqEeo3/8uk1REFPmK0akd6d7hliCpGVRCaqUU0tNXmHv9uRFqlIy/oi GqBOD+P9NQ6T59QapzYLVlS4N2na+2yucv69ABtA0D/VwaUAdP1i/0n5PRkNLsNpJJG7Dw m9Lp9sdIlocCWRWyi5JrYeDgfAFJ8ypKFkPYAYuO85wUFFkKg3DKupTrzBAsAH+wqj5DnK /kbDn7AFMHNcTL5u5JitVyVH05KvQdsSJ/B8Qlz1ZVlfygUVjjtXZ51oqncguo1yNxz74l +3SmFWXqiAVJQ/zWs2lu9Ycz26k5nMKaJ+8xNYq4Md1cDCfZeRinrtDupaKdubUQeNUyQ/ 44aZu8sbRR/GDxxyzh0uUKbmnIWoOzQbReG7Us1QGOuDsV3aAYvn236wpU2w+4X3U3aT+n LS7F75fySobv5hTTEhDpy9RGpmeqJNo7Irg9Uc24/YkGLwAwLvRtKkyWwtJg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Oct 2026 01:56:45 -0400 (EDT) Date: Wed, 21 Oct 2026 14:56:41 +0900 From: Michael Paquier To: shihao zhong Cc: Tomas Vondra , 1217816127@qq.com, pgsql-bugs@lists.postgresql.org, PG Bug reporting form Subject: Re: BUG #19763: ManualBug2 NULL pointer dereference in make_build_data via examine_expression bypass of lookup_var_a Message-ID: References: <19763-14da3f96c02f07e8@postgresql.org> <4a008244-3d3f-4563-8caf-0976fc59816f@vondra.me> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="4H2GKLoKoMM7k9SA" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --4H2GKLoKoMM7k9SA Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Oct 20, 2026 at 08:29:28PM -0400, shihao zhong wrote: > v2 checks the result there too and skips the object with the same > warning. I did not add a test for it, since it needs another fancy > callback. Fancy typanalyze callbacks are what make the DNA of the test module test_custom_types. I'd suggest to add a test for it. Your previous duplicated test had little meaning. This would be a second test for a separated code path, that acts as its own check. -- Michael --4H2GKLoKoMM7k9SA Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmrYVBkACgkQnvQgOdby QH0HJA//UjUvIMSEzf1302HEgLlfHI7YYrBJv2UUVCDbI8tmPLAxW3htp6V/zdGj ys9OcTMDnv07G00N2JjWTjhHlJwQbSM8HpBzDEj/OD14oa7hOX+KCYjLKnNaVqtc FSKcSLLMDCjP4n1/ySJrVJsR5g0+gqdsw0SPGd7u+ce5j365T4Hc/atimYLAnKlc /VebPhg2NRwArG8ZYh1jZ43lUuZTpdWemYOAQek5NCVe/zgJnNU3sz7KT+xCzcvq vFWBbiW1Z/KU6sztO+hVrKkQ2e/7XjWp4zpdt7RTFKxRhgHtcc/SEKKZxOlbNJTw gEylvDMzFU7JxN9TtaIGZDxORMhmWVmaNRi/aGjlKOJXUaN8MduXpYrsFw9Ivodx naWDUbzeQQsIdtlM5jn3eBK/caOcOYSCzgkJY9ZtKVEVNjujgm1LtPgPgdSE3m8d GvXGtRuASPfIBJ+27D/SmsobDGGH2fTxtc9V6dzM/6C2L/NwKopQBdzwlOE6sdiV yqkxDqsmdNAm5hgw5SRHL51Rs5md836knCsDx5Ac6ppZM70byB2n7vUjUwRTdjqN GXjlQQSNh7X+I1aGq84CbOeNvjN8VmIaaHwAHz+HmOQ9oWAN8aLns22QxVq1KCbu pbrnvUN6ZLJtby57EHqwilyqHduLoOmBjM7cYMuuXt6SmK6FOpc= =AJg1 -----END PGP SIGNATURE----- --4H2GKLoKoMM7k9SA--