Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJjEz-00000000OLR-3Ybd for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Oct 2026 03:13:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xJjEz-000000087uc-1hLs for pgsql-bugs@arkaria.postgresql.org; Thu, 22 Oct 2026 03:13:17 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJjEz-000000087uU-0i2m for pgsql-bugs@lists.postgresql.org; Thu, 22 Oct 2026 03:13:17 +0000 Received: from fhigh-a5-smtp.messagingengine.com ([103.168.172.156]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xJjEw-00000000KeX-1TnD for pgsql-bugs@lists.postgresql.org; Thu, 22 Oct 2026 03:13:16 +0000 Received: from phl-compute-01.internal (phl-compute-01.internal [10.202.2.41]) by mailfhigh.phl.internal (Postfix) with ESMTP id BA05614001DF for ; Wed, 21 Oct 2026 23:13:13 -0400 (EDT) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-01.internal (MEProxy); Wed, 21 Oct 2026 23:13:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1792638793; x=1792725193; bh=dOGyScfiz8 7poOT2ke5IFKAzRuHi57ypp67x6UOllQ8=; b=JkglZTrFoZctxy4j4lFiTH56lk V1TqOiLRAhRtVsp/NWSJpGyllfi8mUpQlEGEGBqkbxKfKacrXd8XM3fxl1RlkJt0 c/Or1Ll6qmkT3R20oerVg5KTqv/r+wnQ9WuFk1czzFSKHXUgPmbGOdqj5/iHiCVJ Y2k/reYXcygEPwk20ZLIsUJrmcGTW2F5cxdq5xdscmDBmhkFr+Nh81pJ6o22kuR/ qkLPcj5SO95R5zDrIglsfskEmHKMxgcw8ZgAKIs7ZHCbla485hMfidN5m2EgMMeI QjA6uWqhGH0mpSjhrNkq65r7VwCWE9sgZiQLvEV20VfYeJtPaGDT/CwKumqg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1792638793; x=1792725193; bh=dOGyScfiz87poOT2ke5IFKAzRuHi57ypp67 x6UOllQ8=; b=wz4gckf7GxpOOgQS5jnMyQbp/slXTek7VSMTjcIRVQjy8pwaHe4 ezdEg68ybNSJq6OeT4Xw/MydC5Jb0vWZYKTwaeh3Mr6EtF+f8WCUtoAh6SI4KWT/ WjkKy2RKrezOyWnrL8Dvpb3hUtXjgMwFVdbV0vtolWSbcVtPMNt7ccYgcjESsN9j 2caBDeDHvv1a1gzOdS+vxc8LKa4EZHo6q8Ru58KaAif9cNesU2NbbRfKTGQyNDgZ 8eZh+cIai+Z9Q0IU4/4ujPZfa8J04r4wUhWXko31O2/7vJyctVgWSOTRs9/LUznQ a0UO0VcIiKkvtVIBNrRdwlxLZ+SyHLmgQ8g== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=sign d=paquier.xyz a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1792638793; d=paquier.xyz; mf=PG1pY2hhZWxAcGFxdWllci54eXo+; rt=PHBnc3FsLWJ1Z3NAbGlzdHMucG9zdGdyZXNxbC5vcmc+; s=fm2:rsa-sha256:hlUchpMeb2jhoKhh3D9L+Vd8CIOEZcTAEfRM+xIajvrwCQx m9wottra2aawqhQ8nXJyL4qQsRPOafvAk1Qc0XQXM/vWsExVAeVaFqldT5VubjaK W+WbkZcccu+32v8ONNutWIwukfduB/gk+YXUUlC4NF7abEuFDsUS59obBt9TZ27j ryxv71Gt0QpjEosprCEw9MDznhTmoRgVU0HeBk2IKzIh3lEhrIM28+ka5wWbB+C3 zUVOq10fRNb3K64iQr8LIqKxQgXe/M+Bi1mt5z1lmUlWzylszUoXjUJ9NjUxbxhz WIewy1jzabKewSm6DPD0qv0LkKkAGqzHSKsp2dQ==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-disposition,content-type,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:qYmCivfukgCMtvev1UE0vHKE5r/rrnoeGFWqP/TxdIY=:Hm4lVAQvm5A5nHPyXCpBq5FrFK6WoT9el/SJCh+r890=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFWWfF3u1ix3MU3/m9j4r0nV4oYPPpYoIkUU+OGaubVYzjXK7QXifptfxPMP0ZVxG SoVqqGQvZwufImzexI7Gj3yKxbZWW87GNIlKBnRWGP6C2L4INzdc8qiUxhYpkKRMqHusVp 7j/TMxPhmxf234N5tIE2iLaeAQVL8UyItH0LCJoRfHQQ+dSOS7H7GBuvTZg5y4TR/urc5E nSuBmMNx/VcvpqO6Q0cQa8Ewj+KS9Qao6i+ERtc9eZ6hLsHgNovD4jsjQ0Juhl+P7sqqdw nbCQ6LBxQ3XZAz3H2a0a3p3S6odbPVAXxrr3+AyZb4ENQksOU26KeeK8ys75wmjupmyAAW Px3za8/RlAODzLV44xzS6ksVbkweqDkHlywrJ57fFkhvmAzUIwaBMy7WnlyO+1YE+/UTts wyFpQvrwe10Qs+iVIkiaSa31mOWIM+SepPFe+tR454MkFk1HOq0N/dtTB5E5+43kwOBl2M ivOoG9I79joEpOag81NHPKh8JuWy2ueh8hm6/Lo1wJ6eaFBIkNuslGj+NkYqwUKoolilUt 9AzA0KeYo0oatO5NnzOTMBkvrsVaSoWKc4c6w2VfTLAa4osEd0gtlgXh5NBY3UpjUvfzzi tymqa7qil+A9pzGCvgYOLM6Wxb69HwMoWruIUBtRIFV4DUenTq6G+nxWXlfA X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Oct 2026 23:13:11 -0400 (EDT) Date: Thu, 22 Oct 2026 12:13:09 +0900 From: Michael Paquier To: Takeshi Ideriha Cc: Zhijie Hou , shihao zhong , Ayush Tiwari , alpkeles99@gmail.com, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #19760: CLUSTER loses a row the transaction inserted and then updated in a rolled-back subtransaction Message-ID: References: <5fff280b-96c4-497f-bbfc-0af95b9844b3@gmail.com> <949ad7b3-2b0e-40dc-b6ac-e84da432149b@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Bn/wyDr4Iatswp2E" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --Bn/wyDr4Iatswp2E Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 22, 2026 at 11:53:29AM +0900, Takeshi Ideriha wrote: > Thank you for sorting the issue out and setting the direction. I was > thinking of leaving first SetHintBits() in > HeapTupleSatisfiesVacuumHorizon() and moving the second SetHintBits() to > heapam_relation_copy_for_cluster() to solve the performance issue. Yeah, I don't think that we should begin using SetHintBits() outside of heapam_visibility.c when it comes down to heap as a table AM. > However, it would still be another API violation, wouldn't it? We also > needs to figure out the multixact race issue. I'm trying to look into > multixact part as much as possible. What do you think about the first SetHintBits() added for the subtransaction aborted case? This one seems acceptable here, by itself.. -- Michael --Bn/wyDr4Iatswp2E Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmrZf0UACgkQnvQgOdby QH1VgxAAibXxk8tzutCc5ZqbtgTO7ptlmBTP7dAMMsoBpFwOWivDkP+/JOhqbFNC a5i0TtJVo84xcXjuXi7tbkCzaZmacZCZoVQNRliNtZcGKKzcbpf7bpARxtEiVc6H 46xS+bE0szdTlEvkFR5kVt0MRYp7lPZDCNq17222zyBK7yGZ7jdyGwdtPOTawvlN 5XfmmGX0mGZORJ/Xa8XwNGcZdVgAwVbDnLRdS1fng3XuLBnVi8eXqRofZSuCootE 0z4lmgB8j811lqMF63yn6Xd27VthIkm219gKUeWubFXNrVKag9bBH4nPsf6jlHIy +J7M3kgqczqKu2ByQOGZKCc1+GUKEz0FLDoDF3dtXv6O2fckLYIAyddUVjyneM11 jLWEoG6NnHODkdtryMjz4lczsTTTBHO34242ySDXHxBYCVuUGH1Pr4x300JdLf1v tvu7s15pj/PIAwI2m6bUOObwzp3lnl1CIG+q1148Xi3AxGRkYXXRC+BibAn4cRuu DQTP4MGgXYPg8PAlf9tAvznYEiJd3nLmaEi2MUQVYj10YODBFwi77wjIWpzdG4v9 1FQxidJnlbl49vcHGAM5amO4ywtuSOOxI7kQUY+R9F1PIDPVUst0Axru/KnIy53a tI0UC3R8iB5C4h5TkrMkZLng082o5AgqvIT4O7w6WxbvdGrhUT0= =pPae -----END PGP SIGNATURE----- --Bn/wyDr4Iatswp2E--