Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xKAGT-00000000gnT-0WQ8 for pgsql-bugs@arkaria.postgresql.org; Fri, 23 Oct 2026 08:04:37 +0000 Received: from localhost ([127.0.0.1]:40336 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xKAGS-0000000EsTX-0aTl for pgsql-bugs@arkaria.postgresql.org; Fri, 23 Oct 2026 08:04:36 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:38778) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xKAEA-0000000EqW7-2kWS for pgsql-bugs@lists.postgresql.org; Fri, 23 Oct 2026 08:02:15 +0000 Received: from fhigh-b7-smtp.messagingengine.com ([202.12.124.158]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xKAE8-00000000X3o-3t1A for pgsql-bugs@lists.postgresql.org; Fri, 23 Oct 2026 08:02:13 +0000 Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailfhigh.stl.internal (Postfix) with ESMTP id D928E7A0136 for ; Fri, 23 Oct 2026 04:02:11 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Fri, 23 Oct 2026 04:02:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1792742531; x=1792828931; bh=p0NkdEUAq7 tVF/PX85sZpyGA0H+e0nKmCqRZ0JcQue0=; b=LdGcn19AbGV5Gwe1Ho8czNmoDI 4wm/MUCcZRODhHRStq4LlXIX0sW68QiUOrkcMsXJmbeLJCd0ZdDSeHlJghL3+DRK RH/xXZ6gdSuWdGTTvCa+iLASf/1Sl/9HYIZfFn9uf6MXy5vM0hyqpEgP6C0WilzB bSHiz6GwKVD4kK6aejb2zLVR78mNAHNBhAm9eVC4DY6S5AMiLDWJg9h+CGEW4F4P 5kFZfelooyE9z81N9xmGZQhhX4uHnkggtTVKPvvej4A0bFWEMQZ2akBTtW0UiQT+ MSIrQyHjQAG7s/0w+TRlRNiWMNSOHUlwf2CLltzPTxsuyXfLyYm4usR1CL+w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1792742531; x=1792828931; bh=p0NkdEUAq7tVF/PX85sZpyGA0H+e0nKmCqR Z0JcQue0=; b=Y6ntupf3L0//Xfa/czl2Pd/kWzPMiejANGb6VcQos//Zm7JAK40 lmgRB42WxsHuXER0n4VWIo6qw1Thp7UEQ2V67X2/tPiJRc6d5Xt6hPyIP7Dww03j W44sUMBTzJb78Dp58M2Jem2u1BZCwejmVJZLPIl1J5NiivyixUbBXayitt8ooDcP YbvJaIQR+YLdsjOLGu4SO0IFXVWOypWEPSE1EaU6dtOR+WdB0wsy/NUuJB33MqxS 7zhKmq4csYQqQIhyU85QV71X51Xf3BV7nxsG4dB2Dm2ez22wQeL7K+fXgYyoPuLz 2lta9HGM6surr3LDRtO5xe2p7EeYeq2mnIQ== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=sign d=paquier.xyz a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1792742531; d=paquier.xyz; mf=PG1pY2hhZWxAcGFxdWllci54eXo+; rt=PHBnc3FsLWJ1Z3NAbGlzdHMucG9zdGdyZXNxbC5vcmc+; s=fm2:rsa-sha256:knjXehb5EjVna/dTE4JsbKO2fYym2nMM0VRrqBCWkCoGK5a cdhhWXSXWwA4eXLDRUclne8fo/eslbUD1Fnjv0/PPBOZ3Mf4h8FglLHaEYQliK/4 tN+5FEVleMHh2DJsQf1fXF6cqI57MwQ3Df77Fpb3+5LKwLoA4Ad8Y0/KAIBRSALh aFrzCEht2kt6fF9pTFPRlSltyIXAcW6Ec6ddR7LudIxIqCFbjYkHh6g59+wyY53C /vyiOkhklcoc7KMyZEuUKR1hIwn/i87dlefRYDLdiwqu/oSU+WgwBd/nXpO8jI7o z5CilrrI+2HXyrkwAYHuwvsDyiPUTJNT5EOGxTg==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-07; repo=github.com/dkim2wg/interop; date=2026-10-18; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-disposition,content-type,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:GZBoirkEE0Hb/kCQW0+/sLEwYLvaCq+XIt7PadyOMJI=:o3csANu+/Wnwd2XyFnpniszo0aNSWVJckAopMzsOi/s=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTEN08r593PfK++QE1iDUqHinN6D8CxsOOFBLPx32qgptg8hMt2dhv7OXoCWwoBQek RVG/KCNplY5mK/NGEkxWTz7MJHEr+xyJiUeA6rDufyy1DzaHYhLigU5Wb0ZorEcdm+eVN5 1D2qli5w8AR2vllU+L1Fb3JKo7KGPMosNO8jEpW8RgjqJWQD/UUcCNv//x9f3qe3SXHksn kLquSQcpNof9PwiIEuaX3AfauPt9URmneoyKDafeyLw4NSFfli/ULrIE6QORZUEwsINAsS QQpF6Wm92Y9sXpHb5CQmiEIuzZGAM+dpisTurdhUsfAhqaSqHJu2Z0PeUoJt5Ce8Bf+qZD 5yWsf01Gqg9yL1voKiY+5h9S521AqWncojUXzqDm2qdj8yEXMi3soISCGPOiIs21GK8QeU b+WjdjwZ1eD1QPOIGXXeI3AZiQjARsUd0f8oZu1NKaRD7eme1ZVeowLBz2S8D/G+XBsGvQ t3zC1qAY6lQUYikeig92oOP/DdkhJwBtXwSLor5nv4HgJQ6binmGsC5UuuCasUdL9aZtVy JXbZRwm7wdOFnQKO5b4Mz0nDM8kqWM7Vy3ZrSRsN0smZH8mTgOddxGYGNX4Wzla0k3B9ki Y/5XnTUWzPFTb+kcIu0A3MP2Zvj+uNnkAnIa/gWarUjNc2zfhGWoRfAI9JWQ X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Oct 2026 04:02:09 -0400 (EDT) Date: Fri, 23 Oct 2026 17:02:06 +0900 From: Michael Paquier To: Staroverov Ilja Cc: Sami Imseih , "pgsql-bugs@lists.postgresql.org" Subject: Re: pg_stat_statements replaces SQL/JSON ON EMPTY / ON ERROR keywords with parameters Message-ID: References: <457969A9-5D24-422F-B09E-F388053DE028@localhost.localdomain> <83202E93-9039-410B-B4F2-A141DD7D80E1@localhost.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="I0naXy5/kPnFoxbT" Content-Disposition: inline In-Reply-To: <83202E93-9039-410B-B4F2-A141DD7D80E1@localhost.localdomain> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --I0naXy5/kPnFoxbT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 22, 2026 at 10:52:28AM +0000, Staroverov Ilja wrote: > 0001 fixes all of them in the new tests, for example: errmsg("cannot cast behavior expression of type %s to %s", format_type_be(exprType(expr)), format_type_be(returning->typid)), - parser_errposition(pstate, exprLocation(expr))); + parser_errposition(pstate, location)); While looking at v5-0001, I have been puzzled by this piece, because it is actually not reachable with any normal means or even SQL. Anyway, I get that Amit wanted this part to be defensive, so your suggestion of using the behavior's location sounds good to me. Applied this part. -- Michael --I0naXy5/kPnFoxbT Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmrbFH4ACgkQnvQgOdby QH0fXg//cYEM2zeLqoXKKT05iKzUoFkk2sSMkMZ4MstCZx+cNEIHSpj8nPfOYNf2 uyw8NAcAQ/RPIwtbcRvwfYBCsDOkuLS4xXBLixiw+y7ip7hfg1x+XOf2+hhkErJb V88c37sIx0hJl0jP+IBHiTSXJy0VqgfSoSGKTBRZxylEYmqlAeBP/w0s+i9pvnD+ 6be9FLzYWeilbKCXhrbJEG5hAyKUQip35i5YaH4W0MeselGZTcNtLquLedhJzy2l HYfxy2Zh+h9L55nktniPBNZZRFHHGuiVng+icI+gVnhaz7mOkKoTSin7bxNGfdvg GWrJ5vRPRCwNvs507iFeXyvsgJ/bQ1K4+sW4Bgr/2O7s0YFumSIZoFZIMB9x8vYw 8XIMsXfPXVTlQlrDay5eWq/infcULqpLF9Uqu6JfQ8ckekbCW+abQbZvTGbebx4S ARJIujUHr2UnEbuzsFn1D/Sk4A0Cus4LY0+TPRD9S2xrm5A+1OAHhd5W30hF+lH3 1mBHFJdpqXHTTd347N6beYp85Xan3DSit7gZqXCIf0DOerBwtu/No6x9Q3OuQ3c+ HH0uI1utQy4t8UHlKyfK/AVMSBfWotk/KJgqenl3QNX1Y99bGo+A3azsDEGJfo/H euLz2U7ipzJ7+WukcOztGWlY4irL45zK4F+oYs8qg0wW2lcUIgI= =RiSj -----END PGP SIGNATURE----- --I0naXy5/kPnFoxbT--