Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xNemI-00000002fTd-11Pa for pgsql-bugs@arkaria.postgresql.org; Sun, 01 Nov 2026 23:15:55 +0000 Received: from localhost ([127.0.0.1]:39432 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xNemH-00000000P0t-35lk for pgsql-bugs@arkaria.postgresql.org; Sun, 01 Nov 2026 23:15:53 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]:57844) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xNemG-00000000P0l-4788 for pgsql-bugs@lists.postgresql.org; Sun, 01 Nov 2026 23:15:53 +0000 Received: from fhigh-b8-smtp.messagingengine.com ([202.12.124.159]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xNemF-000000024LR-19Kv for pgsql-bugs@lists.postgresql.org; Sun, 01 Nov 2026 23:15:52 +0000 Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48]) by mailfhigh.stl.internal (Postfix) with ESMTP id 3D1CA7A01BD for ; Sun, 1 Nov 2026 18:15:50 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Sun, 01 Nov 2026 18:15:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm2; t=1793574949; x=1793661349; bh=gZWMHMCZIg W4Idj6SL08/1aWizmG1i6z98oIGfChyQk=; b=bzk8X0Qj5sCNf8ou6bOGs0NtYF K/dhkRWuhFhnFJm+rq96POfIFbLxX/WxHeGltr8rJgZW0CpnrWBiAT/ChRFmOE6q AGBRkXuWvLDsv34Zkjj8uoLOi578pNywbWmp2Xc8LjXDm0I2+wZBwCJv1NBAkz0D DYLVLcxpyBzL45BPlKVzYEUuHoqxJ7VHb6l4DgCKbol5sS1ExBWzwdn/ef+E09p+ cxG8ueKjgW8/SqfCfsokaDuQv/EGeCAK+aRV98bhFqMtcKsHB2i0DMlH5c44Wt9p Zqa9jrhpZAV3RNyfQVExCKevI9UfpDWMeEOCqJM3pq0ftQDx7IKqkqMy9Rwg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1793574949; x=1793661349; bh=gZWMHMCZIgW4Idj6SL08/1aWizmG1i6z98o IGfChyQk=; b=lFkQUkLnpfe0tLc2JPq4Mj/3p/ylOlNXlgZnGqjP1bkujNWw0qA VsTD5GVND8zntyeZYaXA/VtLnUpzL0VVEXkvLeSmz2o/c7E42C00Cxe5FpWNwuqu iLUIHVp8bYA+ITv0gOXs27GNkzxelOWUpjAwypGnsHdRhF+tTPKJquLT6Z1ha2M0 kVS4SZXajAKWvkhZ4GG4g2DDA0Kee4R92GDfwVILM5LKViRH4HEcUJp6E9Uc7o0m T75VclPWrLe3/1sWZrpMcnyrfJ952VzFUBtvXOF/QNqyZA5SoP0XmjXprO8bqMZ2 s8cFpdS4TPS11zuQxo6IHGqsbGnL2/tl3qw== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-08; repo=github.com/dkim2wg/interop; date=2026-10-28; sw=lmtpprox; action=sign d=paquier.xyz a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1793574949; d=paquier.xyz; mf=PG1pY2hhZWxAcGFxdWllci54eXo+; rt=PHBnc3FsLWJ1Z3NAbGlzdHMucG9zdGdyZXNxbC5vcmc+; s=fm2:rsa-sha256:EDJbNVyqbKUrBEN51dAeJ14/ZRmg4v6d9C9z5MLziEADIEV wUIT9yXvkwmSuPchu1BX63eBAKNy8StWz1oOBOGXCdU7zIqxxlboYmBRYNBBn9Z4 Rs3f11GSlL+1bg5A6+fv5j4h63FtCgcVF01lJcIeuL2P6byXxRaj8Ubyi8PG95vd OGhCcbjtzfvw3csWJFgy5f2gsiEoLbU7fFXfKBvFQZS05J/D2+lZ8jEQs+h+An2K 3QvXnpGO5W4IQ1dqYsBzDkaQtE00e1RGO9qS9/v6xiPObmMec1I2INl7ok/NV7aI q0P8QV3YeMAwohG05RHegf4pvry3fkhO94NGRtw==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-08; repo=github.com/dkim2wg/interop; date=2026-10-28; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-disposition,content-type,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:wb6Xgcjn9wBbJpN91j6juBqsB8+xDcddxE9qdjKg+fI=:Vy4eJTURqIExto2gIBA8F0yB1HQ/IurbAQjrn2oGkUY=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTFdltdo83rEfVYS+I/0dtNZa0+S0bm+33AWCWzaIjhSo8Dyfeje6bR838MqFJVK3D 48tdfSNz1wYzDEBDu1zv9BCKXe6a3JdouA1lu6Kd9egq5Lu0M15T3I1EEKF99tHrxEukTq X6ATT6TTcp2y9fPIDYCr6Nq2cnbS9g1AS9xrLIYcwnQKRG2SPKBdAouLyCABhNj4pxlLqb I9zf3+RG5lEdMJJFhmREc93sGfTdQ7SNBgyuDQ0L67+/d4Gf9o/nQyJO7YmA3pPI3GNJww z22w8wjMHgRNplNIwGV4kRFqXy8Bzd/kmZMPtH1wytiQ20MlbQGx6onrA+OPaRnlSbZmOQ tFzTEuxaloqywuOCZLwXXO70YGJQCUW3xdOax7QZWf0vtbAQ97gzWnZN22UjM9RKgsgra+ 4VqSo+Cm4B4e5evCz5mP1bOwObaUbhSJUjJvHP76EOTh3wQVcCDWzSFy+bR0vLQF7Y0Y7a 2/nnx5pH2Fg8AE7DfPTHnzXsQXp8Ij8LvZQUZoEp7LZXd14LmI3jSnH9H9MnZcnM9GYMZX yPa9rYcUrB50nTYaESflrgVvGC9/FXH3ukcaLNjb1Tr0rDHQqg+oSTIq7/Tea6sS5DjA4o zL7++1qdE+c5jsPyKeVGmDdcE1vs4vkFusTt8cpLCRt/s2GHAPRIbUddnzmg X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 1 Nov 2026 18:15:47 -0500 (EST) Date: Mon, 2 Nov 2026 08:15:44 +0900 From: Michael Paquier To: Zhijie Hou Cc: "Hayato Kuroda (Fujitsu)" , "brar@gmx.de" , "pgsql-bugs@lists.postgresql.org" Subject: Re: BUG #19795: pgoutput: walsender crashes on START_REPLICATION option without a value Message-ID: References: <19795-6d7d506133b7f062@postgresql.org> <9bcab85a-edda-4302-bdd0-1c1cf5b7a66c@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zj1aYkdCFAXmvgrT" Content-Disposition: inline In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --zj1aYkdCFAXmvgrT Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Nov 01, 2026 at 05:00:31PM +0900, Michael Paquier wrote: > Thanks for the patch, nice catch. I'll handle that and backpatch. > I regret missing that during the lookup of this code for 290bb8afe6b4, > especially as the crash was possible before it for the two code paths > you are pointing at with the two direct accesses to defel->arg. Applied down to v14 as of 35848657c67d. Thanks, all. -- Michael --zj1aYkdCFAXmvgrT Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmrnyCAACgkQnvQgOdby QH1vgA//cbOWEsxadan+fvcupkhTnOPwPouwxWyGtHorHQXorWYBknOMzNsdbGND BOBA7v9O0Y4Yo0opVWLs0DooA+luN+oT6A50btARinvWfK9Onq+KfRJBRdA0uK+L jJKqAnF3HprWgoN6n5FVa3hyjMOoCpT3wa1Idy1cZdskDRMHoGQiPjrMCwIN8Azk QDtRxI0PTP2MXY2sHAZNf9mhcEflAzFnK868ctEmp9JFPZuHdrBXRTA8alPApxPc TSuAWlrXef76wT/s3r/kKMrb2JGXvvndh4APsWyPNmY8O3GlmkBrqMyd71Y82CE1 fvhUBB4DTzs31eFMeAlDXfUtxTm3BcBVLo40ESPSh6JndQh7W7hRZrQThQHeoqQu 9oyVJAZuYNy4Ytq5EAevH88dXSBhSzkX/DbCnBnT/kBHg5Yu0zdNu9tiC/JcjOjV y84iOQEJmzDNOnYvbVF+ikYBJXvTEvaCO09CY7EibVUzz6Ej2u75qxYpxFsZ8Tq9 5ZWet8Mf8fvXXRuLMqLs93vDKcZ20fQa2KvG+KtN6sz5LUt/Cr4B7XoUiExt15ZH o9Hhlz8iu/kmKV18j9mDNRtJIUHbhCCao7+pHFus8hCOW+2EBG6cXvWEbRt4qdIS DwGSkKaRkEMn3XWoTji163zZyEOoVoAYdzSB9Hd1gM1aAt3qcKw= =Kppv -----END PGP SIGNATURE----- --zj1aYkdCFAXmvgrT--