Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xQuPQ-00000000V0P-1K16 for pgsql-bugs@arkaria.postgresql.org; Tue, 10 Nov 2026 22:33:44 +0000 Received: from localhost ([127.0.0.1]:36616 helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.98.2) (envelope-from ) id 1xQuPO-00000006oW7-3tcu for pgsql-bugs@arkaria.postgresql.org; Tue, 10 Nov 2026 22:33:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]:59932) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xQuPO-00000006oVw-0EK7 for pgsql-bugs@lists.postgresql.org; Tue, 10 Nov 2026 22:33:42 +0000 Received: from fhigh-a6-smtp.messagingengine.com ([103.168.172.157]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1xQuPL-00000000JH8-2Fx2 for pgsql-bugs@lists.postgresql.org; Tue, 10 Nov 2026 22:33:42 +0000 Received: from phl-compute-08.internal (phl-compute-08.internal [10.202.2.48]) by mailfhigh.phl.internal (Postfix) with ESMTP id 3D16E14000F2 for ; Tue, 10 Nov 2026 17:33:36 -0500 (EST) Received: from phl-frontend-04 ([10.202.2.163]) by phl-compute-08.internal (MEProxy); Tue, 10 Nov 2026 17:33:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paquier.xyz; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1794350016; x=1794436416; bh=nnsuienRk1 Fnj2CF3uAccSXVSOnaEFg5xfImAXlaxsY=; b=QCuC3UorzeKssu/c0dD6/9IssV Q6VCNUCpKrHO9qmy/AvK6cwTTjhgMrGQhX7Oj8relCDIZe6+tsC2GzDB0BBoN4ri o3izCatTdVJIMKQFEyREWVTtohek/v3+PsVu4tuYhgkal6TotO5YQpNEuI/VC4Zu EnflLiw4fKe5JB2jmDEDXv/8q60tgrp9TUD5OLcPFPqFHP3LqDG6yqPWiIWyvh3N Sjpc1LWB32DnPesq88UGpkL9LozSlvOJ3J9Z9M7gNcM+PwBDc8pFUAYeyHvaAlQv JIvstZQ4/8H/24U44CrlDBWzf3J+aCDsFGZ86RodN69AOeeFwCqLCv7YMCqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1794350016; x=1794436416; bh=nnsuienRk1Fnj2CF3uAccSXVSOnaEFg5xfI mAXlaxsY=; b=hEi57if7f8IAe/9lLd8ca/FRwW9IBBYanmq2DMtp+ZeEwbEfAVW 40bIRb+oDiar3PNB1yMN21hA3zk7trsoB4duekTLK0XfiDHkj/MkdBVakIfx6jw1 u1Cr/kQOwrfPMARLtzwRf5i+anqPoHJfg8lpIOI8r8kyV2HF8XBEiWA6ousAnbmL zGxdd+SaF4rPuKTAg95ZotBL9ksaKxObh93YbkyW6hCz9gKRoMAGnFGFJPJRg79t /z0yAWT0SieVdCzhAshlgORECdukIWRhNoy9oB9Z8f4vHzaswFhNAYANNtZWJYhc 2MB2key73kom8S2R/R2E1+aNQuCcm6mdV9g== X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=sign d=paquier.xyz a=rsa-sha256; DKIM2-Signature: i=1; m=1; t=1794350016; d=paquier.xyz; mf=PG1pY2hhZWxAcGFxdWllci54eXo+; rt=PHBnc3FsLWJ1Z3NAbGlzdHMucG9zdGdyZXNxbC5vcmc+; s=fm3:rsa-sha256:E9up9phJW2C80w5OBRVhNecDCrQb0NDFnFLs+qSGHqNUoY+ uVOAbnR1EMMIhO2I4Sq+/Um7u6TLg1VLRDDCOc7cK10hqve4Icb/hMnQcyp6lYyD pCoERxm2d8hqoxpl/Ku08GRsuh0C8y0xgb91JK9NS3Qa7Et3t4u54rBMnFnJCwBo i8hfakx3d2yiolflKkApYxnQCns99/DQ7uyWpPdotDdFun6GfZKVF5lgXwMwiMpQ 60D61/aMsYR1BrRzNHLpvv0RH7aBMwBOn6oYoTGqHyO5hiMNUmCcnmVuVv1O6vZO IDDMMe15Lk2PkqFj3oxF4ZSM5IL19A6dw5UHexg==; X-DKIM2-Info: draft=ietf-dkim-dkim2-spec-09; repo=github.com/dkim2wg/interop; date=2026-11-03; sw=lmtpprox; action=mi-m=1; hc=12; hn=cc,content-disposition,content-type,date,feedback-id,from, in-reply-to,message-id,mime-version,references,subject,to; Message-Instance: m=1; h=sha256:cWsT0AWRyaftTHgnXAJ0AjADdpboWBkINwh77grAedg=:r+KhsBdY434AkrmkKluYSniMrxOk5IfnpoE0J2939is=; X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTE9vT5/iVYFLhP/cwc25JXm9RVsz6XW36shc29D+vNrXCKsde2zAFHdK2jKdnQwcA RFgjNKBgJKltkBcgCIqnlNxv89TnaNtUJfp4wgI+udACA32dWxz1nmtPP6uDkPRZ/8oa29 JJAhD4T5PZVRltnVImgAND53vOQEkrQC2+Z+xKzYORzYXYZMzmknr9CoNlA4aLCUhorv/G 85mdpTO45ihoIHDFOjTL4t2may7pVS+dRA3aN+6haK8Ad4ih555eMiATAV/2vkZQ6UVErJ zImD6l7KauunaCo7aoLhJZdWtYfNzR29TnE/tq/EiXPO5jumqclN4VNo9AdwWnZQYjMbPQ qbdLVQgZvVvAQujGSXU2iZgY8GGew25KBVCDvzr1z4n+XO0vFJVzOxeylffj2YTYu9ePf+ +Oz/cyi3gw55XeqwZKcgj/0kl4pfsFJ5DwWVWxY0iCK99q0Fqm1jc+8+W8y1PuhzBwbfWB zWzynkMwK6yjDYnPwHy6il/Q5hjgkb57y31slA4Pu8pi+x99xORX3oJbCocEp685PCQeRL QN8OK63uIWlR57R8cU5EmA1KicayAjXNqKvsUgHPQ5er9wWABP1bO3MsFMRkiEfrW6CMZj NI+eX8Om5Wv69zbUQoaORcVqNHi1iLZICPt1gGyQL3IbOJjqHg2tCpEk9Hiw X-ME-Proxy: Feedback-ID: i0fe9450f:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 10 Nov 2026 17:33:34 -0500 (EST) Date: Wed, 11 Nov 2026 07:33:30 +0900 From: Michael Paquier To: Tom Lane Cc: shihao zhong , Atisss hh <125atishprak@gmail.com>, pgsql-bugs@lists.postgresql.org Subject: Re: BUG #19849: queries fail after ANALYZE with expression stats on arrays Message-ID: References: <19849-38b8bd2fea807154@postgresql.org> <2492770.1794253395@sss.pgh.pa.us> <2925331.1794336781@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SZg+Ee5j9Sd6LawG" Content-Disposition: inline In-Reply-To: <2925331.1794336781@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --SZg+Ee5j9Sd6LawG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Nov 10, 2026 at 01:53:01PM -0500, Tom Lane wrote: > Yeah, I didn't love this particular refactorization either. I think > it'd be nicer to have the values[] and nulls[] arrays totally inside > the shared function and do the tuple-building within it, as attached. Including the tuple build in the routine sounds good here. That takes care of my worries with the previous patch. > One thing that bugs me slightly about this is that it seems weird to > be passing starelid and stainherit explicitly while digging staattnum > out of the VacAttrStats struct. It works, because examine_expression > is careful to set stats->tupattnum = InvalidAttrNumber, but maybe > it would be cleaner to pass all three parts of the primary key as > explicit arguments. Does anyone else feel that way? None here. Passing down tupattnum as an argument coming from "stats" also felt a bit strange.. -- Michael --SZg+Ee5j9Sd6LawG Content-Type: application/pgp-signature; name=signature.asc -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEG72nH6vTowiyblFKnvQgOdbyQH0FAmrzm7oACgkQnvQgOdby QH2iww/6AhoSgLCa0NE4Qy5rzQRwD4nZxqTa0ghFv4VwQ7zaaAEhIq4yK4SebX1m WJ/rYpl3+FothJ8tT42gBHpGhOOZ0iOBcb7W/5VoGRESthlzMa8h1paAP28OOhgh fjuo3vpkzyzgh3Srml+lAyIh85fehiy2twQ8cMA8smoHY2mOh9axHkEQEJwYkIE7 ybwZyS7FxJ0VZB0yiQWCM38Tru6SBO7J4Wznlt3lFFJ1Y8DmZXqbvMnOEEiR4h8D JoOMAk9t++Q6ySL8Z+DQ+sliPPHUIyrEqGLV4sPkjaUTBX8358BiMHaht/w5ZwCF +szE2wZo2lnTph52nsxXVV3LIZrcEHm5i7z+rZsAoAPTP4aE3o8RidPBxRkFmXzf GNkzPVzmvBaOUGZcPI/XyV/hBcAEnGCqVRqT48RAhd9ByVJGR0CSakrcY9tuz1ws RTPzqhx7/5cTpEbrAknhwe2zRYauIqHfFkgS/gSNcBX6jsUX9uO9T13WENhNmBcV OXIS3uYiq4+MB32OzXjb7K00/usz/YOrcgHaMbw/BJMrQVtC9xfKd1Ul4XrWHF7w 3167wxnG1ZwCTQVn7a9XoPmCBlFOlO5yZlT783pYKQ83cT57ESvDhawN9ii/kMPW 7qtWwSgr2UP59+uxu22UzSoQS9F1ZX347BxWJJUW7XLpT32TRsA= =eykL -----END PGP SIGNATURE----- --SZg+Ee5j9Sd6LawG--