Message-ID: <b1c12dfa471f9fa98faee3b30bcae7911f397ddb.camel@j-davis.com>
Subject: Re: hashing bpchar for nondeterministic collations is broken
From: Jeff Davis <pgsql@j-davis.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: pgsql-bugs@postgresql.org
Date: Fri, 02 Dec 2022 13:21:08 -0800
In-Reply-To: 
 <CAMbWs48dYCWaMaPxFCC4hDTf5ZOFX1xcDdAs4kuPq1b7CCTDAA@mail.gmail.com>
References: <eb83d0ac7b299eb08f9b900dd08a5a0c5d90e517.camel@j-davis.com>
	 <CAMbWs48dYCWaMaPxFCC4hDTf5ZOFX1xcDdAs4kuPq1b7CCTDAA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu1 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/b1c12dfa471f9fa98faee3b30bcae7911f397ddb.camel%40j-davis.com>
Precedence: bulk

On Fri, 2022-12-02 at 10:30 +0800, Richard Guo wrote:
>=20
> I'm not familiar with the backporting policy, but I also think we
> need
> to as this fixes an obvious oversight.


The standard I use is that backpatching something should be safe enough
that users feel safer updating to a minor release (containing ~100 such
fixes) than *not* updating to a minor release.

The only demonstrable problem that I'm aware of[1] relies on an
undocumented type (undocumented before 16, that is) combined with a
non-deterministic collation and hash partitioning. The intersection of
those users is likely to be the empty set.

But assuming someone does use that combination of features in 15.1, and
we release 15.2 with my fix in it, then the consequences could be
severe: a pg_dump with default options on their bpchar-
nondeterministic-collation-hash-partitioned table in 15.1 would be
unrestorable in 15.2. They'd need to take a new pg_dump from 15.1 with
"--load-via-partition-root" and then restore it in 15.2. Obviously that
would be bad in any case, but it's more tolerable going between servers
of different major versions.

So, given that this fix is unlikely to help many people in 15 and
earlier, and that there's a chance that the fix is really painful for
someone; I'm electing not to backpatch it.


[1]=20
https://www.postgresql.org/message-id/7692740d4736e79032a5dac689cf2e304c03f=
a78.camel@j-davis.com