Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDT8f-0005Yo-7w for pgsql-bugs@arkaria.postgresql.org; Fri, 28 Jan 2022 15:26:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nDT8d-0006bm-AD for pgsql-bugs@arkaria.postgresql.org; Fri, 28 Jan 2022 15:26:11 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nDT8d-0006bV-0S for pgsql-bugs@lists.postgresql.org; Fri, 28 Jan 2022 15:26:11 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nDT8a-0004CQ-UX for pgsql-bugs@lists.postgresql.org; Fri, 28 Jan 2022 15:26:10 +0000 Received: from [192.168.28.32] (cyclops.postgrespro.ru [93.174.131.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id AD9AE21C2E36; Fri, 28 Jan 2022 18:26:07 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1643383567; bh=+RUglfjwcVKS47QkFsk7kbhlki6gcVBPBLj2MnmxPtU=; h=Date:Subject:To:References:From:In-Reply-To; b=DVcYilkKug+V7W1Vl4rWjmcg9juvyw3RwHdeiKbXBVFHKFSiB7sIX9aMwLnxfO70S oIdTUX79A+MUQlq5bDUOvCUfhxsYiu8L3ppLoJj+2yjpk78rHgIC6FEV+HaM3InbaW NUZ95fCImFUBFVbND/s6XkTVMYAyCGWGDhm2LWBA= Content-Type: multipart/mixed; boundary="------------a509SU9X9hpqK30zSkTNLFoC" Message-ID: Date: Fri, 28 Jan 2022 18:26:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: BUG #17385: "RESET transaction_isolation" inside serializable transaction causes Assert at the transaction end Content-Language: en-US To: andrewbille@gmail.com, pgsql-bugs@lists.postgresql.org References: <17385-9ee529fb091f0ce5@postgresql.org> From: Dmitry Koval In-Reply-To: <17385-9ee529fb091f0ce5@postgresql.org> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------a509SU9X9hpqK30zSkTNLFoC Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Additional information. Query "RESET transaction_isolation;" in previous message can be replaced to synonym "SET transaction_isolation=DEFAULT;" (error will be the same). I attached file with simple fix for branch "master". I not sure that need to use a separate block of code for the "transaction_isolation" GUC-variable. But this is a special variable and there are several places in the code with handling of this variable. With best regards, Dmitry Koval. --------------a509SU9X9hpqK30zSkTNLFoC Content-Type: text/plain; charset=UTF-8; name="v1-0001-Fixed-reset-transaction_isolation.patch" Content-Disposition: attachment; filename="v1-0001-Fixed-reset-transaction_isolation.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3ZhcmlhYmxlLmMgYi9zcmMvYmFj a2VuZC9jb21tYW5kcy92YXJpYWJsZS5jCmluZGV4IGU1ZGRjZGEwYjQuLjAzOGRhOTY4YjYg MTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3ZhcmlhYmxlLmMKKysrIGIvc3Jj L2JhY2tlbmQvY29tbWFuZHMvdmFyaWFibGUuYwpAQCAtNTMxLDE0ICs1MzEsMTYgQEAgY2hl Y2tfWGFjdElzb0xldmVsKGludCAqbmV3dmFsLCB2b2lkICoqZXh0cmEsIEd1Y1NvdXJjZSBz b3VyY2UpCiAJCWlmIChGaXJzdFNuYXBzaG90U2V0KQogCQl7CiAJCQlHVUNfY2hlY2tfZXJy Y29kZShFUlJDT0RFX0FDVElWRV9TUUxfVFJBTlNBQ1RJT04pOwotCQkJR1VDX2NoZWNrX2Vy cm1zZygiU0VUIFRSQU5TQUNUSU9OIElTT0xBVElPTiBMRVZFTCBtdXN0IGJlIGNhbGxlZCBi ZWZvcmUgYW55IHF1ZXJ5Iik7CisJCQlHVUNfY2hlY2tfZXJybXNnKCIlcyBUUkFOU0FDVElP TiBJU09MQVRJT04gTEVWRUwgbXVzdCBiZSBjYWxsZWQgYmVmb3JlIGFueSBxdWVyeSIsCisJ CQkJCQkJIChzb3VyY2UgPT0gUEdDX1NfT1ZFUlJJREUpID8gIlJFU0VUIiA6ICJTRVQiKTsK IAkJCXJldHVybiBmYWxzZTsKIAkJfQogCQkvKiBXZSBpZ25vcmUgYSBzdWJ0cmFuc2FjdGlv biBzZXR0aW5nIGl0IHRvIHRoZSBleGlzdGluZyB2YWx1ZS4gKi8KIAkJaWYgKElzU3ViVHJh bnNhY3Rpb24oKSkKIAkJewogCQkJR1VDX2NoZWNrX2VycmNvZGUoRVJSQ09ERV9BQ1RJVkVf U1FMX1RSQU5TQUNUSU9OKTsKLQkJCUdVQ19jaGVja19lcnJtc2coIlNFVCBUUkFOU0FDVElP TiBJU09MQVRJT04gTEVWRUwgbXVzdCBub3QgYmUgY2FsbGVkIGluIGEgc3VidHJhbnNhY3Rp b24iKTsKKwkJCUdVQ19jaGVja19lcnJtc2coIiVzIFRSQU5TQUNUSU9OIElTT0xBVElPTiBM RVZFTCBtdXN0IG5vdCBiZSBjYWxsZWQgaW4gYSBzdWJ0cmFuc2FjdGlvbiIsCisJCQkJCQkJ IChzb3VyY2UgPT0gUEdDX1NfT1ZFUlJJREUpID8gIlJFU0VUIiA6ICJTRVQiKTsKIAkJCXJl dHVybiBmYWxzZTsKIAkJfQogCQkvKiBDYW4ndCBnbyB0byBzZXJpYWxpemFibGUgbW9kZSB3 aGlsZSByZWNvdmVyeSBpcyBzdGlsbCBhY3RpdmUgKi8KZGlmZiAtLWdpdCBhL3NyYy9iYWNr ZW5kL3V0aWxzL21pc2MvZ3VjLmMgYi9zcmMvYmFja2VuZC91dGlscy9taXNjL2d1Yy5jCmlu ZGV4IDRjOTRmMDljNjQuLjJmZmQ2ZmI4NDQgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0 aWxzL21pc2MvZ3VjLmMKKysrIGIvc3JjL2JhY2tlbmQvdXRpbHMvbWlzYy9ndWMuYwpAQCAt ODAyMSw2ICs4MDIxLDE3IEBAIHNldF9jb25maWdfb3B0aW9uKGNvbnN0IGNoYXIgKm5hbWUs IGNvbnN0IGNoYXIgKnZhbHVlLAogCQkJCQluZXdleHRyYSA9IGNvbmYtPnJlc2V0X2V4dHJh OwogCQkJCQlzb3VyY2UgPSBjb25mLT5nZW4ucmVzZXRfc291cmNlOwogCQkJCQljb250ZXh0 ID0gY29uZi0+Z2VuLnJlc2V0X3Njb250ZXh0OworCisJCQkJCS8qCisJCQkJCSAqIFJlc2V0 ZWQgdHJhbnNhY3Rpb25faXNvbGF0aW9uIHZhbHVlIGNhbiBiZSBub3QKKwkJCQkJICogYXBw bGljYWJsZSB0byBjdXJyZW50IHRyYW5zYWN0aW9uCisJCQkJCSAqLworCQkJCQlpZiAoc3Ry Y21wKG5hbWUsICJ0cmFuc2FjdGlvbl9pc29sYXRpb24iKSA9PSAwKQorCQkJCQl7CisJCQkJ CQlpZiAoIWNhbGxfZW51bV9jaGVja19ob29rKGNvbmYsICZuZXd2YWwsICZuZXdleHRyYSwK KwkJCQkJCQkJCQkJCSAgc291cmNlLCBlbGV2ZWwpKQorCQkJCQkJCXJldHVybiAwOworCQkJ CQl9CiAJCQkJfQogCiAJCQkJaWYgKHByb2hpYml0VmFsdWVDaGFuZ2UpCg== --------------a509SU9X9hpqK30zSkTNLFoC--