Content-Type: multipart/mixed; boundary="------------IVvZbmIbo2SiHrYrdzIRcZiY"
Message-ID: <b54507e4-6fa6-4198-92be-ea9118d131da@oss.nttdata.com>
Date: Thu, 26 Sep 2024 23:19:33 +0900
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: vacuumdb: permission denied for schema "pg_temp_7"
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Christophe Pettus <xof@thebuild.com>,
 Nathan Bossart <nathandbossart@gmail.com>,
 vaibhave postgres <postgresvaibhave@gmail.com>, Tom Lane
 <tgl@sss.pgh.pa.us>, Noah Misch <noah@leadboat.com>,
 pgsql-bugs@lists.postgresql.org, vsekar@microsoft.com
References: <Zu3iMzfiGBTbg3iy@nathan> <20240920215030.8d.nmisch@google.com>
 <2603142.1726873660@sss.pgh.pa.us>
 <5f37ee56-14fb-44fe-9150-9eb97e10538b@oss.nttdata.com>
 <2649165.1726898595@sss.pgh.pa.us>
 <CAM_eQjyWnu_LUt6JWjh3boNFHAT9DBrcbamhG3Xy39Q4Ph=2rg@mail.gmail.com>
 <ZvGye19tHrhLCpFl@nathan> <E9660D68-5B26-488E-9AB2-2CA1E8EDDDA1@thebuild.com>
 <ZvIRG6282T33q3Ku@paquier.xyz>
 <00d98a9f-bec1-4cd0-b59e-1043ae04c8bc@oss.nttdata.com>
 <ZvNJNoumGREYshTF@paquier.xyz>
From: Fujii Masao <masao.fujii@oss.nttdata.com>
In-Reply-To: <ZvNJNoumGREYshTF@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/b54507e4-6fa6-4198-92be-ea9118d131da%40oss.nttdata.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------IVvZbmIbo2SiHrYrdzIRcZiY
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2024/09/25 8:20, Michael Paquier wrote:
>> We should probably add a condition like "relpersistence != CppAsString2(RELPERSISTENCE_TEMP)"
>> to the queries in get_parallel_object_list().
> 
> Missed your point.  An extra filter based on relpersistence can indeed
> make sense for this path.

Patch attached.

Should reindexdb skip temporary tables or indexes even when specified explicitly
with the -t or -i options? Currently, the patch doesn't change this behavior;
reindexdb will still not skip them if specified.

If we agree to back-patch, it should be applied to v13, as parallel mode was
introduced in that version.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

--------------IVvZbmIbo2SiHrYrdzIRcZiY
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-reindexdb-Skip-reindexing-temporary-tables-and-in.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-reindexdb-Skip-reindexing-temporary-tables-and-in.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSBiMmU4NTdlZWFhOTE2MWFhNDMwOGRmNTE1OGI4ZjExOTM1Y2NhOTc3IE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBGdWppaSBNYXNhbyA8ZnVqaWlAcG9zdGdyZXNxbC5v
cmc+CkRhdGU6IFRodSwgMjYgU2VwIDIwMjQgMjE6MDY6NDkgKzA5MDAKU3ViamVjdDogW1BB
VENIIHYxXSByZWluZGV4ZGI6IFNraXAgcmVpbmRleGluZyB0ZW1wb3JhcnkgdGFibGVzIGFu
ZCBpbmRleGVzLgoKUmVpbmRleGluZyB0ZW1wIHRhYmxlcyBvciBpbmRleGVzIG9mIG90aGVy
IHNlc3Npb25zIGlzIG5vdCBhbGxvd2VkLgpIb3dldmVyLCByZWluZGV4ZGIgaW4gcGFyYWxs
ZWwgbW9kZSBwcmV2aW91c2x5IGxpc3RlZCB0aGVtIGFzCnRoZSBvYmplY3RzIHRvIHByb2Nl
c3MsIGxlYWRpbmcgdG8gZmFpbHVyZXMuCgpUaGlzIGNvbW1pdCBlbnN1cmVzIHJlaW5kZXhk
YiBpbiBwYXJhbGxlbCBtb2RlIHNraXBzIHRlbXBvcmFyeSB0YWJsZXMKYW5kIGluZGV4ZXMg
YnkgYWRkaW5nIGEgY29uZGl0aW9uIGJhc2VkIG9uIHRoZSByZWxwZXJzaXN0ZW5jZSBjb2x1
bW4KaW4gcGdfY2xhc3MgdG8gdGhlIG9iamVjdCBsaXN0aW5nIHF1ZXJpZXMsIHByZXZlbnRp
bmcgdGhlc2UgaXNzdWVzLgoKTm90ZSB0aGF0IHRoaXMgY29tbWl0IGRvZXMgbm90IGFmZmVj
dCByZWluZGV4ZGIgd2hlbiB0ZW1wb3JhcnkgdGFibGVzCm9yIGluZGV4ZXMgYXJlIGV4cGxp
Y2l0bHkgc3BlY2lmaWVkIHVzaW5nIHRoZSAtdCBvciAtaiBvcHRpb25zOwpyZWluZGV4ZGIg
c3RpbGwgZG9lcyBub3Qgc2tpcCB0aGVtIGFuZCBjYW4gY2F1c2UgYW4gZXJyb3IuCgpCYWNr
LXBhdGNoIHRvIHYxMyB3aGVyZSBwYXJhbGxlbCBtb2RlIHdhcyBpbnRyb2R1Y2VkIGluIHJl
aW5kZXhkYi4KCkRpc2N1c3Npb246IGh0dHBzOi8vcG9zdGdyLmVzL20vNWYzN2VlNTYtMTRm
Yi00NGZlLTkxNTAtOWViOTdlMTA1MzhiQG9zcy5udHRkYXRhLmNvbQotLS0KIHNyYy9iaW4v
c2NyaXB0cy9yZWluZGV4ZGIuYyB8IDQgKysrKwogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0
aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9iaW4vc2NyaXB0cy9yZWluZGV4ZGIuYyBiL3Ny
Yy9iaW4vc2NyaXB0cy9yZWluZGV4ZGIuYwppbmRleCA5MDRjMTk2ZmJiLi5hZjA3MzhkOTMz
IDEwMDY0NAotLS0gYS9zcmMvYmluL3NjcmlwdHMvcmVpbmRleGRiLmMKKysrIGIvc3JjL2Jp
bi9zY3JpcHRzL3JlaW5kZXhkYi5jCkBAIC02NDksNiArNjQ5LDggQEAgZ2V0X3BhcmFsbGVs
X29iamVjdF9saXN0KFBHY29ubiAqY29ubiwgUmVpbmRleFR5cGUgdHlwZSwKIAkJCQkJCQkJ
ICIgICBBTkQgYy5yZWxraW5kIElOICgiCiAJCQkJCQkJCSBDcHBBc1N0cmluZzIoUkVMS0lO
RF9SRUxBVElPTikgIiwgIgogCQkJCQkJCQkgQ3BwQXNTdHJpbmcyKFJFTEtJTkRfTUFUVklF
VykgIilcbiIKKwkJCQkJCQkJICIgICBBTkQgYy5yZWxwZXJzaXN0ZW5jZSAhPSAiCisJCQkJ
CQkJCSBDcHBBc1N0cmluZzIoUkVMUEVSU0lTVEVOQ0VfVEVNUCkgIlxuIgogCQkJCQkJCQkg
IiBPUkRFUiBCWSBjLnJlbHBhZ2VzIERFU0M7Iik7CiAJCQlicmVhazsKIApAQCAtNjcxLDYg
KzY3Myw4IEBAIGdldF9wYXJhbGxlbF9vYmplY3RfbGlzdChQR2Nvbm4gKmNvbm4sIFJlaW5k
ZXhUeXBlIHR5cGUsCiAJCQkJCQkJCQkgIiBXSEVSRSBjLnJlbGtpbmQgSU4gKCIKIAkJCQkJ
CQkJCSBDcHBBc1N0cmluZzIoUkVMS0lORF9SRUxBVElPTikgIiwgIgogCQkJCQkJCQkJIENw
cEFzU3RyaW5nMihSRUxLSU5EX01BVFZJRVcpICIpXG4iCisJCQkJCQkJCQkgIiAgIEFORCBj
LnJlbHBlcnNpc3RlbmNlICE9ICIKKwkJCQkJCQkJCSBDcHBBc1N0cmluZzIoUkVMUEVSU0lT
VEVOQ0VfVEVNUCkgIlxuIgogCQkJCQkJCQkJICIgQU5EIG5zLm5zcG5hbWUgSU4gKCIpOwog
CiAJCQkJZm9yIChjZWxsID0gdXNlcl9saXN0LT5oZWFkOyBjZWxsOyBjZWxsID0gY2VsbC0+
bmV4dCkKLS0gCjIuNDUuMgoK

--------------IVvZbmIbo2SiHrYrdzIRcZiY--