Message-ID: <b69236c25061d5ee1e4fcd5fb7de1193db3f1338.camel@cybertec.at>
Subject: Re: Unexpected behavior when setting "idle_replication_slot_timeout"
From: Laurenz Albe <laurenz.albe@cybertec.at>
To: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, 'Amit Kapila'
	 <amit.kapila16@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, Tom Lane <tgl@sss.pgh.pa.us>,
  "David G. Johnston" <david.g.johnston@gmail.com>, Nisha Moond
 <nisha.moond412@gmail.com>, Gunnar Morling	
 <gunnar.morling@googlemail.com>, "pgsql-bugs@lists.postgresql.org"	
 <pgsql-bugs@lists.postgresql.org>
Date: Thu, 10 Jul 2025 07:51:36 +0200
In-Reply-To: 
 <OS7PR01MB14968E808BF18FC2915D82671F548A@OS7PR01MB14968.jpnprd01.prod.outlook.com>
References: 
	<CADGJaX_0+FTguWpNSpgVWYQP_7MhoO0D8=cp4XozSQgaZ40Odw@mail.gmail.com>
	 <CABdArM76e8-XChodqKxEiRK3tR_Yv3cymn_AWfP4bOsLDscZAg@mail.gmail.com>
	 <30e91649-06dd-453e-8658-5f4acd03a3bd@oss.nttdata.com>
	 <b26f13d7-769a-4b64-8bed-cb3a833c0604@oss.nttdata.com>
	 <686577f2379e4b978803e72746dcf0dd7baf3937.camel@cybertec.at>
	 <e0789f10-5b48-4d6b-a32c-0f4426d254df@oss.nttdata.com>
	 <CAA4eK1LOyUeCHk3hMtjT-bpqXLAnjODwcO+o7+bTnB2es-fSqw@mail.gmail.com>
	 <70b183fb-f66e-40d8-b0de-be8c1052fa93@oss.nttdata.com>
	 <CAKFQuwYVEgy+fiHMvSoykiEef-VF-ZV9Gxv4rynk9NNK9UMPYQ@mail.gmail.com>
	 <472687.1751731008@sss.pgh.pa.us> <474268.1751731988@sss.pgh.pa.us>
	 <f12271e6aea3b87eaa430d0c9008ca1f3154c31e.camel@cybertec.at>
	 <CAA4eK1JaYNQtTj5u-YP3G2UJbJoevD4PnUiM+sQy8DerjNPJFA@mail.gmail.com>
	 <1cea80b2ed4f355ae6a68e36f56a1410b59ea4a8.camel@cybertec.at>
	 <OSCPR01MB14966D811DB105E49289B8298F549A@OSCPR01MB14966.jpnprd01.prod.outlook.com>
	 <2dcea297694d9ab8eafd1db70d385ec0b49e3d27.camel@cybertec.at>
	 <49b70ae1-acbe-41ec-9d2d-8284b3462fc1@oss.nttdata.com>
	 <9bda06ec9ad0a3e3df898dfb542db53b54b55368.camel@cybertec.at>
	 <CAA4eK1J1Npia9J7zS4LzJqeO4uy5pcJ8BmzF7r1YeoFpa4-7jw@mail.gmail.com>
	 <OS7PR01MB14968E808BF18FC2915D82671F548A@OS7PR01MB14968.jpnprd01.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) 
MIME-Version: 1.0
Archived-At: 
 <https://www.postgresql.org/message-id/b69236c25061d5ee1e4fcd5fb7de1193db3f1338.camel%40cybertec.at>
Precedence: bulk

On Thu, 2025-07-10 at 05:27 +0000, Hayato Kuroda (Fujitsu) wrote:
> > > The "hybrid approach" saves the two seconds on system with injection =
points,
> > > but cannot simplify the code.
> >=20
> > I feel that would be a needless complexity in the test.
>=20
> Yeah, it is the down side of the approach. If it do not have enough advan=
tage, let's drop the idea.

Great, then I think that we have consensus.
Let's change to seconds and leave the injectsion points and tests as they a=
re.

I'd still like to see the documentation improved, like my patch tried to do=
.

Yours,
Laurenz Albe