Feedback-ID: i0c21471d:Fastmail
MIME-Version: 1.0
Date: Tue, 25 Mar 2025 22:55:52 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: "Tender Wang" <tndrwang@gmail.com>, "Tom Lane" <tgl@sss.pgh.pa.us>
Cc: tharakan@gmail.com, pgsql-bugs@lists.postgresql.org,
 "Heikki Linnakangas" <hlinnaka@iki.fi>
Message-Id: <b6ea023a-703d-4afa-8561-9e867db1b5f0@app.fastmail.com>
In-Reply-To: 
 <CAHewXNm8rkn9Vu-WhmMQMJS2hSqztbJO1cRv5-+Rp99+k43aJw@mail.gmail.com>
References: <18866-d68926d0f1c72d44@postgresql.org>
 <CAHewXNk6uX0VBROmoMrnKs_AOzbAQo+i9pouUiYj01y50HZRSw@mail.gmail.com>
 <1280897.1742920635@sss.pgh.pa.us>
 <CAHewXNm8rkn9Vu-WhmMQMJS2hSqztbJO1cRv5-+Rp99+k43aJw@mail.gmail.com>
Subject: Re: BUG #18866: Running pg_freespace() on views triggers an Abort
Content-Type: multipart/mixed;
 boundary=25839b2278254617b9e4f9efbb1a2cc8
Archived-At: 
 <https://www.postgresql.org/message-id/b6ea023a-703d-4afa-8561-9e867db1b5f0%40app.fastmail.com>
Precedence: bulk

--25839b2278254617b9e4f9efbb1a2cc8
Content-Type: multipart/alternative;
 boundary=78440ae4a5ad4496887ebd8745de79a3

--78440ae4a5ad4496887ebd8745de79a3
Content-Type: text/plain
Content-Transfer-Encoding: 7bit

On Tue, Mar 25, 2025, at 10:18 PM, Tender Wang wrote:
> Thanks for the advice. Please see the attached patch.

Your patch needs some adjustments. There is no need to include pg_class.h. I
don't like the proposed error message. I prefer saying the relation cannot be
opened because that's what will happen if it reaches this code path. This is an
existing message so no need for translation. The output will be like:

postgres=# SELECT pg_freespace('f', 0); 
ERROR:  cannot open relation "f"
DETAIL:  This operation is not supported for foreign tables.
postgres=# SELECT pg_freespace('pg_roles', 0); 
ERROR:  cannot open relation "pg_roles"
DETAIL:  This operation is not supported for views.
postgres=# SELECT pg_freespace('pg_class', 0); 
pg_freespace 
--------------
         7520
(1 row)

I'm attaching a patch that includes these modifications.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--78440ae4a5ad4496887ebd8745de79a3
Content-Type: text/html
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}=0Ap.MsoNormal,p.MsoNoSpacing{margin:0}</=
style></head><body><div>On Tue, Mar 25, 2025, at 10:18 PM, Tender Wang w=
rote:<br></div><blockquote type=3D"cite" id=3D"qt" style=3D""><div dir=3D=
"ltr"><div dir=3D"ltr">Thanks for the advice. Please see the attached pa=
tch.<br></div></div></blockquote><div><br></div><div>Your patch needs so=
me adjustments. There is no need to include pg_class.h. I<br></div><div>=
don't like the proposed error message. I prefer saying the relation cann=
ot be<br style=3D"max-width:100%;height:auto;"></div><div>opened because=
 that's what will happen if it reaches this code path. This is an<br sty=
le=3D"max-width:100%;height:auto;"></div><div>existing message so no nee=
d for translation. The output will be like:<br style=3D"max-width:100%;h=
eight:auto;"></div><div><br></div><div>postgres=3D# SELECT pg_freespace(=
'f', 0);&nbsp;<br></div><div>ERROR:&nbsp; cannot open relation "f"<br></=
div><div>DETAIL:&nbsp; This operation is not supported for foreign table=
s.<br></div><div>postgres=3D# SELECT pg_freespace('pg_roles', 0);&nbsp;<=
br></div><div>ERROR:&nbsp; cannot open relation "pg_roles"<br></div><div=
>DETAIL:&nbsp; This operation is not supported for views.<br></div><div>=
postgres=3D# SELECT pg_freespace('pg_class', 0);&nbsp;<br></div><div>pg_=
freespace&nbsp;<br></div><div>--------------<br></div><div>&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; 7520<br></div><div>(1 row)<br></div>=
<div><br></div><div>I'm attaching a patch that includes these modificati=
ons.<br></div><div><br></div><div><br></div><div id=3D"sig112409080"><di=
v class=3D"signature">--<br></div><div class=3D"signature">Euler Taveira=
<br></div><div class=3D"signature">EDB&nbsp;&nbsp; <a href=3D"https://ww=
w.enterprisedb.com/">https://www.enterprisedb.com/</a><br></div></div><d=
iv><br></div></body></html>
--78440ae4a5ad4496887ebd8745de79a3--

--25839b2278254617b9e4f9efbb1a2cc8
Content-Disposition: attachment; filename="fsm.patch"
Content-Type: text/x-patch; name="fsm.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2NvbnRyaWIvcGdfZnJlZXNwYWNlbWFwL3BnX2ZyZWVzcGFjZW1hcC5j
IGIvY29udHJpYi9wZ19mcmVlc3BhY2VtYXAvcGdfZnJlZXNwYWNlbWFwLmMKaW5kZXggNTY1
MTY3YWFlZjAuLjQ5ZWVhMjgyM2I5IDEwMDY0NAotLS0gYS9jb250cmliL3BnX2ZyZWVzcGFj
ZW1hcC9wZ19mcmVlc3BhY2VtYXAuYworKysgYi9jb250cmliL3BnX2ZyZWVzcGFjZW1hcC9w
Z19mcmVlc3BhY2VtYXAuYwpAQCAtMTEsNiArMTEsNyBAQAogI2luY2x1ZGUgImFjY2Vzcy9y
ZWxhdGlvbi5oIgogI2luY2x1ZGUgImZtZ3IuaCIKICNpbmNsdWRlICJzdG9yYWdlL2ZyZWVz
cGFjZS5oIgorI2luY2x1ZGUgInV0aWxzL3JlbC5oIgogCiBQR19NT0RVTEVfTUFHSUM7CiAK
QEAgLTMwLDYgKzMxLDEzIEBAIHBnX2ZyZWVzcGFjZShQR19GVU5DVElPTl9BUkdTKQogCiAJ
cmVsID0gcmVsYXRpb25fb3BlbihyZWxpZCwgQWNjZXNzU2hhcmVMb2NrKTsKIAorCWlmICgh
UkVMS0lORF9IQVNfU1RPUkFHRShyZWwtPnJkX3JlbC0+cmVsa2luZCkpCisJCWVyZXBvcnQo
RVJST1IsCisJCQkJKGVycmNvZGUoRVJSQ09ERV9XUk9OR19PQkpFQ1RfVFlQRSksCisJCQkJ
IGVycm1zZygiY2Fubm90IG9wZW4gcmVsYXRpb24gXCIlc1wiIiwKKwkJCQkJCVJlbGF0aW9u
R2V0UmVsYXRpb25OYW1lKHJlbCkpLAorCQkJCSBlcnJkZXRhaWxfcmVsa2luZF9ub3Rfc3Vw
cG9ydGVkKHJlbC0+cmRfcmVsLT5yZWxraW5kKSkpOworCiAJaWYgKGJsa25vIDwgMCB8fCBi
bGtubyA+IE1heEJsb2NrTnVtYmVyKQogCQllcmVwb3J0KEVSUk9SLAogCQkJCShlcnJjb2Rl
KEVSUkNPREVfSU5WQUxJRF9QQVJBTUVURVJfVkFMVUUpLAo=

--25839b2278254617b9e4f9efbb1a2cc8--