Message-ID: <b8ee2352-4866-b8ef-5d94-e267104bab37@gmail.com>
Date: Sat, 21 Oct 2023 09:30:00 +0300
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: BUG #18165: Could not duplicate handle for
 "Global/PostgreSQL.xxxxxxxxxx": Bad file descriptor
Content-Language: en-US
To: Thomas Munro <thomas.munro@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>, maxime.boyer@cra-arc.gc.ca,
 pgsql-bugs@lists.postgresql.org
References: <18165-bf4f525cea6e51de@postgresql.org>
 <3998077.1697840164@sss.pgh.pa.us>
 <20231020225433.yhcw4qjbeixpgglh@awork3.anarazel.de>
 <4019765.1697851177@sss.pgh.pa.us>
 <CA+hUKG+W8cPyMpRNoao_bsKBH-2=1KM59sSPh-c3kA=TDyWeVw@mail.gmail.com>
 <CA+hUKGJCQKTeAVDXRvsLeEwh=H2-NGoy7DaVcwxOsR9638ZniA@mail.gmail.com>
 <CA+hUKG+gFC2LT7NW76k=EVJEUwa7nWgma=Y6hthzxQRW0JXQAg@mail.gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
In-Reply-To: 
 <CA+hUKG+gFC2LT7NW76k=EVJEUwa7nWgma=Y6hthzxQRW0JXQAg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/b8ee2352-4866-b8ef-5d94-e267104bab37%40gmail.com>
Precedence: bulk

Hi Thomas,

21.10.2023 08:26, Thomas Munro wrote:
> And concretely this would be the fix, I think.  But I don't have
> Windows, and for reasons I haven't fathomed I haven't yet managed to
> reproduce it by pushing a change of default min_dynamic_shared_memory
> to CI.  Is there any chance that a Postgres hacker on Windows could
> confirm the above theory, and that the attached fixes it?

I've tried on master:
echo min_dynamic_shared_memory = 10MB >c:\temp\extra.config
set TEMP_CONFIG=c:\temp\extra.config
vcregress check

and got:
...
Installation complete.
# initializing database system by running initdb
# postmaster failed, examine ".../src/test/regress/log/postmaster.log" for the reasonBail out!

 >cat ../../../src/test/regress/log/postmaster.log
2023-10-20 23:12:46.110 PDT postmaster[3140] LOG:  starting PostgreSQL 17devel, compiled by Visual C++ build 1928, 64-bit
2023-10-20 23:12:46.113 PDT postmaster[3140] LOG:  listening on IPv6 address "::1", port 55312
2023-10-20 23:12:46.113 PDT postmaster[3140] LOG:  listening on IPv4 address "127.0.0.1", port 55312
2023-10-20 23:12:46.129 PDT startup[6188] LOG:  database system was shut down at 2023-10-20 23:12:41 PDT
2023-10-20 23:12:46.130 PDT startup[6188] FATAL:  could not duplicate handle for "Global/PostgreSQL.753594369": Bad file 
descriptor
2023-10-20 23:12:46.132 PDT postmaster[3140] LOG:  startup process (PID 6188) exited with exit code 1
2023-10-20 23:12:46.132 PDT postmaster[3140] LOG:  aborting startup due to startup process failure
2023-10-20 23:12:46.132 PDT postmaster[3140] LOG:  database system is shut down

With your patch applied, `vcregress check` passes just fine.

Best regards,
Alexander