Content-Type: multipart/mixed; boundary="------------aLbqR6c0jhs1xh2XqipMbipI"
Message-ID: <b97f1850-fc7b-43c4-9b04-4e97bb9e7dc0@gmail.com>
Date: Wed, 15 Apr 2026 14:48:35 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>,
 Masahiko Sawada <sawada.mshk@gmail.com>
Content-Language: en-US
From: Andrei Lepikhov <lepihov@gmail.com>
Subject: TRAP: failed Assert("offsets[i] > offsets[i - 1]"), File:
 "tidstore.c"
Archived-At: <https://www.postgresql.org/message-id/b97f1850-fc7b-43c4-9b04-4e97bb9e7dc0%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------aLbqR6c0jhs1xh2XqipMbipI
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

While experimenting with query plans, I periodically see test_tidstore 
fail on the assertion in TidStoreSetBlockOffsets().

The cause is that the harness function do_set_block_offsets() forwards 
the SQL array straight to TidStoreSetBlockOffsets(), which has an 
explicit contract:

"The offset numbers 'offsets' must be sorted in ascending order."

array_agg() without ORDER BY gives no such guarantee, and plan shapes 
that reshuffle the input can deliver the offsets out of order and trip 
the Assert.

The issue is minor and doesn't expose any underlying bug, but it is 
still worth fixing: it removes a source of flaky test runs and makes 
life easier for extension developers who reuse the same pattern.

Patch attached.

-- 
regards, Andrei Lepikhov,
pgEdge

--------------aLbqR6c0jhs1xh2XqipMbipI
Content-Type: text/plain; charset=UTF-8;
 name="v0-0001-Sort-offsets-in-test_tidstore-s-do_set_block_offs.patch"
Content-Disposition: attachment;
 filename*0="v0-0001-Sort-offsets-in-test_tidstore-s-do_set_block_offs.pa";
 filename*1="tch"
Content-Transfer-Encoding: base64

RnJvbSA5OWM5YWJiM2I3NTFlYzM2MDNiNmFkODI0OGZiOTRlYzUyOWQyOTMyIE1vbiBTZXAg
MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiQW5kcmVpIFYuIExlcGlraG92IiA8bGVwaWhvdkBn
bWFpbC5jb20+CkRhdGU6IFdlZCwgMTUgQXByIDIwMjYgMTQ6NDE6NTEgKzAyMDAKU3ViamVj
dDogW1BBVENIIHYwXSBTb3J0IG9mZnNldHMgaW4gdGVzdF90aWRzdG9yZSdzIGRvX3NldF9i
bG9ja19vZmZzZXRzKCkuCgpUaWRTdG9yZVNldEJsb2NrT2Zmc2V0cygpIHJlcXVpcmVzIGl0
cyBvZmZzZXRzW10gYXJndW1lbnQgdG8gYmUKc3RyaWN0bHkgYXNjZW5kaW5nLCBhbmQgYXNz
ZXJ0cyB0aGUgcHJlY29uZGl0aW9uLgoKVGhlIHRlc3QgaGFybmVzcyB3YXMgZm9yd2FyZGlu
ZyB0aGUgT2Zmc2V0TnVtYmVyIGFycmF5IHN0cmFpZ2h0IGZyb20KU1FMLCB3aGljaCB3b3Jr
cyBvbmx5IGJlY2F1c2UgdGhlIGN1cnJlbnQgcGxhbm5lciBoYXBwZW5zIHRvIHByZXNlbnQK
YXJyYXlfYWdnKCkgaW5wdXQgaW4gdGhlIG9yZGVyIHRoZSBWQUxVRVMgY2xhdXNlIHdhcyB3
cml0dGVuLiAgVGhhdApvcmRlcmluZyBpcyBub3QgYSBTUUwgZ3VhcmFudGVlOiBhcnJheV9h
Z2coKSB3aXRob3V0IE9SREVSIEJZIGlzCnVub3JkZXJlZCBieSBzcGVjaWZpY2F0aW9uLCBh
bmQgYW55IHBsYW4gY2hhbmdlIHRoYXQgcmVzaHVmZmxlcyB0aGUKQ2FydGVzaWFuIHByb2R1
Y3QgdXNlZCBpbiB0ZXN0X3RpZHN0b3JlLnNxbCAtLSBwYXJhbGxlbCBhZ2dyZWdhdGlvbiwK
YSBkaWZmZXJlbnQgam9pbiBvcmRlciwgb3IgYSByYW5kb21pc2VkIHBsYW5uZXIgLS0gY2Fu
IGRlbGl2ZXIgdGhlCm9mZnNldHMgb3V0IG9mIG9yZGVyIGFuZCBjYXVzZSB0aGUgQXNzZXJ0
LgoKRml4IGJ5IHNvcnRpbmcgb2ZmcyBpbiBwbGFjZSBpbnNpZGUgZG9fc2V0X2Jsb2NrX29m
ZnNldHMoKSBiZWZvcmUKY2FsbGluZyBUaWRTdG9yZVNldEJsb2NrT2Zmc2V0cygpLiBEdXBs
aWNhdGVzIGFyZSBpbnRlbnRpb25hbGx5IGxlZnQgdG8gZmFpbAp0aGUgc3RyaWN0LWluZXF1
YWxpdHkgQXNzZXJ0LgotLS0KIHNyYy90ZXN0L21vZHVsZXMvdGVzdF90aWRzdG9yZS90ZXN0
X3RpZHN0b3JlLmMgfCAxNiArKysrKysrKysrKysrKysrCiAxIGZpbGUgY2hhbmdlZCwgMTYg
aW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L21vZHVsZXMvdGVzdF90aWRz
dG9yZS90ZXN0X3RpZHN0b3JlLmMgYi9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfdGlkc3RvcmUv
dGVzdF90aWRzdG9yZS5jCmluZGV4IGM5YTAzNWZhNDk0Li5iZmM0MGJjZTI0YyAxMDA2NDQK
LS0tIGEvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X3RpZHN0b3JlL3Rlc3RfdGlkc3RvcmUuYwor
KysgYi9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfdGlkc3RvcmUvdGVzdF90aWRzdG9yZS5jCkBA
IC03NSw2ICs3NSwxOSBAQCBpdGVtcHRyX2NtcChjb25zdCB2b2lkICpsZWZ0LCBjb25zdCB2
b2lkICpyaWdodCkKIAlyZXR1cm4gMDsKIH0KIAorc3RhdGljIGludAorb2Zmc2V0bnVtYmVy
X2NtcChjb25zdCB2b2lkICphLCBjb25zdCB2b2lkICpiKQoreworCU9mZnNldE51bWJlciBs
ID0gKihjb25zdCBPZmZzZXROdW1iZXIgKikgYTsKKwlPZmZzZXROdW1iZXIgciA9ICooY29u
c3QgT2Zmc2V0TnVtYmVyICopIGI7CisKKwlpZiAobCA8IHIpCisJCXJldHVybiAtMTsKKwll
bHNlIGlmIChsID4gcikKKwkJcmV0dXJuIDE7CisJcmV0dXJuIDA7Cit9CisKIC8qCiAgKiBD
cmVhdGUgYSBUaWRTdG9yZS4gSWYgc2hhcmVkIGlzIGZhbHNlLCB0aGUgdGlkc3RvcmUgaXMg
Y3JlYXRlZAogICogb24gVG9wTWVtb3J5Q29udGV4dCwgb3RoZXJ3aXNlIG9uIERTQS4gQWx0
aG91Z2ggdGhlIHRpZHN0b3JlCkBAIC0xNzgsNiArMTkxLDkgQEAgZG9fc2V0X2Jsb2NrX29m
ZnNldHMoUEdfRlVOQ1RJT05fQVJHUykKIAlub2ZmcyA9IEFycmF5R2V0Tkl0ZW1zKEFSUl9O
RElNKHRhKSwgQVJSX0RJTVModGEpKTsKIAlvZmZzID0gKChPZmZzZXROdW1iZXIgKikgQVJS
X0RBVEFfUFRSKHRhKSk7CiAKKwkvKiBUaWRTdG9yZVNldEJsb2NrT2Zmc2V0cygpIHJlcXVp
cmVzIG9mZnNldHMgdG8gYmUgc3RyaWN0bHkgYXNjZW5kaW5nLiAqLworCXFzb3J0KG9mZnMs
IG5vZmZzLCBzaXplb2YoT2Zmc2V0TnVtYmVyKSwgb2Zmc2V0bnVtYmVyX2NtcCk7CisKIAkv
KiBTZXQgVElEcyBpbiB0aGUgc3RvcmUgKi8KIAlUaWRTdG9yZUxvY2tFeGNsdXNpdmUodGlk
c3RvcmUpOwogCVRpZFN0b3JlU2V0QmxvY2tPZmZzZXRzKHRpZHN0b3JlLCBibGtubywgb2Zm
cywgbm9mZnMpOwotLSAKMi41My4wCgo=

--------------aLbqR6c0jhs1xh2XqipMbipI--